Merged
Conversation
- All settings are now phrased in the imperative form stating what the setting does rather than talking about what it controls. (E.g.: "Show `Debug` action." instead of "Whether to show `Debug` action" - Categories are now displayed in title case - Categories are now sorted lexicographically - General category is removed (and all the settings are moved to the top level) - Language for a few descriptions is made a bit less ambiguous
And add assert_eq, assert_ne, assert_matches support
Input:
```rust
pub fn $0foo(x: bool) {
debug_assert!(x);
}
```
Old:
```rust
/// .
///
/// # Panics
///
/// Panics if .
pub fn foo(x: bool) {
debug_assert!(x);
}
```
This PR fixes:
```rust
/// .
pub fn foo(x: bool) {
debug_assert!(x);
}
```
Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
…` to SyntaxEditor Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
…ditor' Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
- this removes one external dependency, mdbook-toc - this steals code from rustc book
…-gen Fix gen panics doc template for debug_assert
fix: Do not require all rename definitions to be renameable
Use GH app for authenticating sync PRs
…t support snippets
…l-snippet fix: In generate_mut_trait_impl, don't add a tabstop if the client does not support snippets
Improve settings tree title and descriptions
… `impl Trait`, collect only the bounds of this projection It used to collect the bounds of them all.
…hints fix: When displaying a projection into a type parameter that has bounds as `impl Trait`, collect only the bounds of this projection
…le_struct_to_named_struct Migrate `convert_tuple_struct_to_named_struct` assist to use `SyntaxEditor`
…_alias_to_syntax_editor Migrate `inline_type_alias` assist to use `syntax_editor`
Reorganize proc-macro-srv more, add `--format` and `--version` args
coverage: Various small cleanups This PR is a collection of small coverage-related changes that I accumulated while working towards other coverage improvements. Each change should hopefully be fairly straightforward.
`rust-analyzer` subtree update Subtree update of `rust-analyzer` to rust-lang/rust-analyzer@8d75311. Created using https://github.com/rust-lang/josh-sync. r? `@ghost`
Add `InterpCx::project_fields` I was hoping for a much bigger improvement and this is lukewarm at best ^^' Still, I think this makes sense.
…enton Delete `tests/ui/threads-sendsync/tcp-stress.rs` This stress test was originally introduced in 65cca4b to detect a UAF in `libuv` (see rust-lang#12823), but we no longer use `libuv`, so remove this test as it no longer serves its original purpose, and is causing flaky timeout failures. Closes rust-lang#144878 (by removing the test). r? libs
rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@1263fc2. Created using https://github.com/rust-lang/josh-sync. r? ``@ghost``
Dont print arg span in MIR dump for tail call r? WaffleLapkin This makes the MIR dump for tail call terminators consistent w/ regular calls.
rustbot
added
A-attributes
Member
Author
|
@bors r+ p=5 rollup=never |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 0060d5a (parent) -> 0f35336 (this PR) Test differencesShow 137 test diffsStage 1
Stage 2
Additionally, 41 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0f353363965ebf05e0757f7679c800b39c51a07e --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 0060d5a2a8 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (0f35336): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.2%, secondary -0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -3.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 466.337s -> 468.338s (0.43%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
crossoriginwhen needed #144467 (rustdoc template font links only emitcrossoriginwhen needed)tests/ui/issues/tests to other subdirectories undertests/ui/#144548 (Rehome 21tests/ui/issues/tests to other subdirectories undertests/ui/)[const]s inside blocks within legal positions #144741 (fix: Error on illegal[const]s inside blocks within legal positions)Printercleanups #144776 (Printercleanups)tests/ui/#144813 (Add a tidy check to prevent adding UI tests directly undertests/ui/)&FnPtror&FnDef#144817 (Properly reject tail calls to&FnPtror&FnDef)rust_panic_without_hooktoresume_unwind#144852 (Renamerust_panic_without_hooktoresume_unwind)SHOULD_EMIT_LINTSin favor ofshould_emit#144866 (RemoveSHOULD_EMIT_LINTSin favor ofshould_emit)as_arrayin PartialEq for arrays #144867 (Useas_arrayin PartialEq for arrays)LazyCellandLazyLock#144872 (Document Poisoning inLazyCellandLazyLock)rust-analyzersubtree update #144887 (rust-analyzersubtree update)InterpCx::project_fields#144890 (AddInterpCx::project_fields)tests/ui/threads-sendsync/tcp-stress.rs#144894 (Deletetests/ui/threads-sendsync/tcp-stress.rs)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup