Closed
Conversation
Currently the Args new function is scope constrained to pub(super) but this stops me from being able to construct Args structs in unit tests.
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
…szelmann Port `#[coroutine]` to the new attribute system Related to rust-lang#131229 (comment). r? ```@jdonszelmann```
Change visibility of Args new function Currently the Args new function is constrained to pub(super) but this stops me from being able to construct Args structs in unit tests. This pull request is to change this to pub.
… r=fee1-dead Add regression tests for seemingly fixed issues Closes rust-lang#104314 Closes rust-lang#125866
…iper Correct the use of `must_use` on btree::IterMut I'm working on stricter target checking for attributes and found this one
…eLapkin Autolabel PRs that change explicit tail call tests as `F-explicit_tail_calls` mrrrow~
rustbot
added
A-attributes
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
crossoriginwhen needed #144467 (rustdoc template font links only emitcrossoriginwhen needed)tests/ui/issues/tests to other subdirectories undertests/ui/#144548 (Rehome 21tests/ui/issues/tests to other subdirectories undertests/ui/)#[coroutine]to the new attribute system #144794 (Port#[coroutine]to the new attribute system)InterpCx::project_fields#144890 (AddInterpCx::project_fields)must_useon btree::IterMut #144926 (Correct the use ofmust_useon btree::IterMut)rust-versionfromrustc_thread_pool#144928 (Droprust-versionfromrustc_thread_pool)F-explicit_tail_calls#144945 (Autolabel PRs that change explicit tail call tests asF-explicit_tail_calls)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup