regression test for intrinsics may not inline properly on pclmulqdq#145001
Open
lucarlig wants to merge 1 commit intorust-lang:mainfrom
Open
regression test for intrinsics may not inline properly on pclmulqdq#145001lucarlig wants to merge 1 commit intorust-lang:mainfrom
lucarlig wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-author
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
Contributor
|
Since Nikita requested the test |
tgross35
reviewed
Aug 6, 2025
nikic
reviewed
Aug 6, 2025
nikic
reviewed
Aug 6, 2025
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Aug 8, 2025
regression test for intrinsics may not inline properly on pclmulqdq https://rust.godbolt.org/z/dWsa9ET99 Fixes rust-lang#139029
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Aug 8, 2025
regression test for intrinsics may not inline properly on pclmulqdq https://rust.godbolt.org/z/dWsa9ET99 Fixes rust-lang#139029
bors
added a commit
that referenced
this pull request
Aug 8, 2025
Rollup of 7 pull requests Successful merges: - #144039 (Use `tcx.short_string()` in more diagnostics) - #144192 (atomicrmw on pointers: move integer-pointer cast hacks into backend) - #144823 (coverage: Extract HIR-related helper code out of the main module) - #144987 (Enable f16 and f128 on targets that were fixed in LLVM21) - #145001 (regression test for intrinsics may not inline properly on pclmulqdq) - #145080 (Escape diff strings in MIR dataflow graphviz) - #145083 (Fix cross-compilation of Cargo) r? `@ghost` `@rustbot` modify labels: rollup
Contributor
|
@bors r- Failed in #145090 (comment) |
bors
added
S-waiting-on-author
Contributor
|
Maybe this needs a |
Member
|
The problem here appears to be an open-ended |
nikic
reviewed
Aug 8, 2025
| // CHECK-NOT: call | ||
| // CHECK: call <2 x i64> @llvm.x86.pclmulqdq | ||
| // CHECK: call <2 x i64> @llvm.x86.pclmulqdq | ||
| // CHECK-NOT: call |
Contributor
There was a problem hiding this comment.
The problem is that this can match the nocallback attribute. I think we can avoid it by adding an extra // CHECK: ret after it.
Member
|
@lucarlig |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://rust.godbolt.org/z/dWsa9ET99
Fixes #139029