std: use a TAIT to define `SplitPaths` on UNIX by joboet · Pull Request #145242 · rust-lang/rust

joboet · 2025-08-11T10:09:45Z

Defining SplitPaths as a TAIT allows using closures instead of function pointers for split and map.

rustbot · 2025-08-11T10:09:50Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

joboet · 2025-08-11T10:51:02Z

Note that this does not concern the public SplitPaths, but rather the inner SplitPaths that is wrapped by it.

danielhenrymantilla · 2025-08-11T13:33:18Z

library/std/src/sys/pal/unix/os.rs

-pub struct SplitPaths<'a> {
-    iter: iter::Map<slice::Split<'a, u8, fn(&u8) -> bool>, fn(&'a [u8]) -> PathBuf>,
-}
+pub type SplitPaths<'a> = impl Iterator<Item = PathBuf> + 'a;


Should these items be pub(crate) if so?

We'd rather not be exposing a TAIT to downstream code, I imagine, so it might be better to enforce that with proper visibility:

Suggested change

pub type SplitPaths<'a> = impl Iterator<Item = PathBuf> + 'a;

pub(crate) type SplitPaths<'a> = impl Iterator<Item = PathBuf> + 'a;

None of the items in sys is exposed publicly, but we still use pub instead of pub(crate) almost everywhere. I don't really want to break the pattern and cause unnecessary confusion.

library/std/src/sys/pal/unix/os.rs

bors · 2025-08-19T00:31:24Z

☔ The latest upstream changes (presumably #145489) made this pull request unmergeable. Please resolve the merge conflicts.

Mark-Simulacrum · 2025-08-21T01:36:01Z

r=me

rustbot · 2025-08-29T14:16:32Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

joboet · 2025-08-29T15:36:51Z

@bors r=@Mark-Simulacrum

bors · 2025-08-29T15:36:54Z

📌 Commit 85cefab has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2025-08-29T19:40:18Z

⌛ Testing commit 85cefab with merge c180adc...

std: use a TAIT to define `SplitPaths` on UNIX Defining `SplitPaths` as a TAIT allows using closures instead of function pointers for `split` and `map`.

bors · 2025-08-29T19:46:04Z

💔 Test failed - checks-actions

joboet · 2025-08-29T19:56:24Z

That's definitely spurious.
@bors r=Mark-Simulacrum

bors · 2025-08-29T19:56:26Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: resolve: Avoid a regression from splitting prelude into two scopes #145961

bors · 2025-08-29T19:56:27Z

📌 Commit 85cefab has been approved by Mark-Simulacrum

It is now in the queue for this repository.

rust-log-analyzer · 2025-08-29T19:57:41Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[endgroup]
Image input checksum 63a9e41071b3c3ad1fb0b603c94c8c10649e229cd0cf518479399112965ddbeaf3d6b6c5e3de88f5dc848f1dcf4a9c36010d1ee210f92e860529d0cd0e87ac2b
##[group]Building docker image for aarch64-gnu
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
Post job cleanup.

…mulacrum std: use a TAIT to define `SplitPaths` on UNIX Defining `SplitPaths` as a TAIT allows using closures instead of function pointers for `split` and `map`.

Rollup of 6 pull requests Successful merges: - #144964 (std: clarify `OpenOptions` error for create without write access) - #145242 (std: use a TAIT to define `SplitPaths` on UNIX) - #145467 (Stabilize `strict_provenance_atomic_ptr` feature) - #145990 (`AutoDeref::final_ty` is already resolved) - #145991 (std: haiku: fix `B_FIND_PATH_IMAGE_PATH`) - #146000 (Improve librustdoc error when a file creation/modification failed) r? `@ghost` `@rustbot` modify labels: rollup

…mulacrum std: use a TAIT to define `SplitPaths` on UNIX Defining `SplitPaths` as a TAIT allows using closures instead of function pointers for `split` and `map`.

Rollup of 9 pull requests Successful merges: - #145242 (std: use a TAIT to define `SplitPaths` on UNIX) - #145467 (Stabilize `strict_provenance_atomic_ptr` feature) - #145756 (str: Stabilize `round_char_boundary` feature) - #145967 (compiler: Include span of too huge enum with `-Cdebuginfo=2`) - #145990 (`AutoDeref::final_ty` is already resolved) - #145991 (std: haiku: fix `B_FIND_PATH_IMAGE_PATH`) - #146000 (Improve librustdoc error when a file creation/modification failed) - #146017 (Mark pipe2 supported in Android) - #146022 (compiler-builtins subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145242 - joboet:tait-split-paths, r=Mark-Simulacrum std: use a TAIT to define `SplitPaths` on UNIX Defining `SplitPaths` as a TAIT allows using closures instead of function pointers for `split` and `map`.

Rollup of 9 pull requests Successful merges: - rust-lang/rust#145242 (std: use a TAIT to define `SplitPaths` on UNIX) - rust-lang/rust#145467 (Stabilize `strict_provenance_atomic_ptr` feature) - rust-lang/rust#145756 (str: Stabilize `round_char_boundary` feature) - rust-lang/rust#145967 (compiler: Include span of too huge enum with `-Cdebuginfo=2`) - rust-lang/rust#145990 (`AutoDeref::final_ty` is already resolved) - rust-lang/rust#145991 (std: haiku: fix `B_FIND_PATH_IMAGE_PATH`) - rust-lang/rust#146000 (Improve librustdoc error when a file creation/modification failed) - rust-lang/rust#146017 (Mark pipe2 supported in Android) - rust-lang/rust#146022 (compiler-builtins subtree update) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Mark-Simulacrum Aug 11, 2025

rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 11, 2025

This comment was marked as off-topic.

Sign in to view

danielhenrymantilla reviewed Aug 11, 2025

View reviewed changes

library/std/src/sys/pal/unix/os.rs Outdated Show resolved Hide resolved

joboet force-pushed the tait-split-paths branch from 3a4164f to cb388c6 Compare August 11, 2025 14:37

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2025

std: use a TAIT to define SplitPaths on UNIX

85cefab

joboet force-pushed the tait-split-paths branch from cb388c6 to 85cefab Compare August 29, 2025 14:16

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 29, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 29, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2025

matthiaskrgr mentioned this pull request Aug 29, 2025

Rollup of 7 pull requests #146012

Closed

matthiaskrgr mentioned this pull request Aug 29, 2025

Rollup of 6 pull requests #146014

Closed

tgross35 mentioned this pull request Aug 29, 2025

Rollup of 9 pull requests #146020

Closed

tgross35 mentioned this pull request Aug 29, 2025

Rollup of 9 pull requests #146021

Closed

tgross35 mentioned this pull request Aug 30, 2025

Rollup of 9 pull requests #146023

Merged

bors merged commit 19ae976 into rust-lang:master Aug 30, 2025
10 of 11 checks passed

rustbot added this to the 1.91.0 milestone Aug 30, 2025

dtolnay mentioned this pull request Aug 31, 2025

env::split_paths regression in nightly-2025-08-31 #146045

Closed

joboet mentioned this pull request Aug 31, 2025

std: fix SplitPaths regression #146053

Merged

	pub type SplitPaths<'a> = impl Iterator<Item = PathBuf> + 'a;
	pub(crate) type SplitPaths<'a> = impl Iterator<Item = PathBuf> + 'a;

Uh oh!

Conversation

joboet commented Aug 11, 2025

Uh oh!

rustbot commented Aug 11, 2025

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

joboet commented Aug 11, 2025

Uh oh!

danielhenrymantilla Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

joboet Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bors commented Aug 19, 2025

Uh oh!

Mark-Simulacrum commented Aug 21, 2025

Uh oh!

rustbot commented Aug 29, 2025

Uh oh!

joboet commented Aug 29, 2025

Uh oh!

bors commented Aug 29, 2025

Uh oh!

bors commented Aug 29, 2025

Uh oh!

bors commented Aug 29, 2025

Uh oh!

joboet commented Aug 29, 2025

Uh oh!

bors commented Aug 29, 2025

Uh oh!

bors commented Aug 29, 2025

Uh oh!

rust-log-analyzer commented Aug 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants