Skip to content

Rollup of 4 pull requests#145254

Merged
bors merged 9 commits intorust-lang:masterfrom
GuillaumeGomez:rollup-7bp43pv
Aug 11, 2025
Merged

Rollup of 4 pull requests#145254
bors merged 9 commits intorust-lang:masterfrom
GuillaumeGomez:rollup-7bp43pv

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Aug 11, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

scrabsha and others added 9 commits August 5, 2025 09:28
@scrabsha
Add test for "missing function argument" on multiline call
bdaabc1
@scrabsha
Allow function argument mismatch suggestion to be multiline
1e271d6
@fee1-dead
remove some unused private trait impls
57dc64e
@Kobzol
Fix Cargo cross-compilation (take two)
23946b7
@GuillaumeGomez
Update sysinfo version to 0.37.0
eff5315
@GuillaumeGomez
Rollup merge of rust-lang#144966 - scrabsha:push-rozroqqmurvu, r=jdon…
180e7ce 
…szelmann

 Improve suggestion for "missing function argument" on multiline call

`rustc` has a very neat suggestion when the argument count does not match, with a nice placeholder that shows where an argument may be missing. Unfortunately the suggestion is always single-line, even when the function call spans across multiple lines. With this PR, `rustc` tries to guess if the function call is multiline or not, and emits a multiline suggestion when required.

r? `@jdonszelmann`
@GuillaumeGomez
Rollup merge of rust-lang#145111 - fee1-dead-contrib:push-rlvnyrztlkp…
77d7a2c 
…q, r=jieyouxu

remove some unused private trait impls

they're neither required for completeness nor used
@GuillaumeGomez
Rollup merge of rust-lang#145221 - Kobzol:cargo-dist-fix-2, r=jieyouxu
eee9e60 
Fix Cargo cross-compilation (take two)

In rust-lang#145083, I fixed the case of manually invoking `x dist cargo`, but I realized that `x install` creates the `tool::Cargo` step through the `from_build_frompiler` constructor, which doesn't go through `get_tool_target_compiler`. So we just prepare both the host and target stdlibs directly before building Cargo. Ideally we would get rid of `from_build_compiler`, but that will require refactoring the dist and test steps, which is upcoming.

Hopefully fixes rust-lang#145059 for good.
@GuillaumeGomez
Rollup merge of rust-lang#145247 - GuillaumeGomez:update-sysinfo, r=K…
c291505 
…obzol

Update `sysinfo` version to `0.37.0`

Some small performance improvements and internal cleanups.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 11, 2025
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Aug 11, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Aug 11, 2025

📌 Commit c291505 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2025
@bors
Copy link
Collaborator

bors commented Aug 11, 2025

⌛ Testing commit c291505 with merge 1ebbd87...

@bors
Copy link
Collaborator

bors commented Aug 11, 2025

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 1ebbd87 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 11, 2025
@bors bors merged commit 1ebbd87 into rust-lang:master Aug 11, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 11, 2025
@rust-timer
Copy link
Collaborator

rust-timer commented Aug 11, 2025

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#144966 Improve suggestion for "missing function argument" on mult… e80eb40f0b01ac52c03b84439be3bebb2041a1b5 (link)
#145111 remove some unused private trait impls 1537297bde06ba0ca5fd82b6569f1747493210e8 (link)
#145221 Fix Cargo cross-compilation (take two) a61715c6aa707991062d9cb2d251d1cf5a9db760 (link)
#145247 Update sysinfo version to 0.37.0 475947505ab3043f07bf39a9c2d8bd0e12c6be7c (link)

previous master: 6355cd39c8

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6355cd3 (parent) -> 1ebbd87 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1ebbd87a62ce96a72b22da61b7c2c43893534842 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 3833.2s -> 4549.4s (18.7%)
  2. x86_64-gnu-llvm-19-3: 8068.9s -> 6680.4s (-17.2%)
  3. dist-aarch64-apple: 8056.3s -> 9397.3s (16.6%)
  4. tidy: 125.9s -> 107.6s (-14.6%)
  5. dist-android: 2889.1s -> 2526.6s (-12.5%)
  6. x86_64-gnu-miri: 4510.3s -> 4979.1s (10.4%)
  7. aarch64-apple: 4975.5s -> 5489.5s (10.3%)
  8. dist-apple-various: 4811.2s -> 4335.1s (-9.9%)
  9. x86_64-gnu-llvm-19-1: 3631.1s -> 3279.2s (-9.7%)
  10. dist-aarch64-msvc: 5698.0s -> 5213.0s (-8.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Aug 12, 2025

Finished benchmarking commit (1ebbd87): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.7% [-3.7%, -3.7%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.7% [-3.7%, -3.7%] 1

Cycles

Results (primary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.9% [-2.9%, -2.9%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.9% [-2.9%, -2.9%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 463.68s -> 465.929s (0.49%)
Artifact size: 377.35 MiB -> 377.31 MiB (-0.01%)

@GuillaumeGomez GuillaumeGomez deleted the rollup-7bp43pv branch August 12, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

7 participants

@GuillaumeGomez @bors @rust-timer @rustbot @scrabsha @fee1-dead @Kobzol