Switch Instant to use CLOCK_BOOTTIME on Android.#145360
Closed
jfgoog wants to merge 1 commit intorust-lang:masterfrom
Closed
Switch Instant to use CLOCK_BOOTTIME on Android.#145360jfgoog wants to merge 1 commit intorust-lang:masterfrom
jfgoog wants to merge 1 commit intorust-lang:masterfrom
Conversation
This is a long-term patch we have carried for the Android platform: https://android.googlesource.com/toolchain/android_rust/+/refs/heads/main/patches/longterm/rustc-0018-Switch-Instant-to-use-CLOCK_BOOTTIME.patch
Collaborator
rustbot
added
O-unix
Member
|
Near-duplicate of #132331 (esp. #132331 (comment))
And personally I think android shouldn't be carrying this patch, since it indicates you have broken code somewhere else that relies on explicitly disclaimed behavior. |
Contributor
|
Closing because as @the8472 mentioned, this was discussed in #132331 (comment) and the plan is to introduce an alternative clock that has the needed guarantees. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a long-term patch we have carried for the Android platform:
https://android.googlesource.com/toolchain/android_rust/+/refs/heads/main/patches/longterm/rustc-0018-Switch-Instant-to-use-CLOCK_BOOTTIME.patch