Refactor attribute parsing to improve ergonomics and some diagnostics#145507
Merged
bors merged 4 commits intorust-lang:masterfrom Aug 22, 2025
Merged
Refactor attribute parsing to improve ergonomics and some diagnostics#145507bors merged 4 commits intorust-lang:masterfrom
bors merged 4 commits intorust-lang:masterfrom
Conversation
rustbot
added
A-attributes
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
Collaborator
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
refactor-attr-parsing
branch
from
920a37c to
e5c14c3
Compare
Contributor
Author
|
@rustbot review |
davidtwco
approved these changes
Aug 18, 2025
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Member
|
Merge conflict. |
bors
added
S-waiting-on-author
jdonszelmann
force-pushed
the
refactor-attr-parsing
branch
from
e5c14c3 to
a59705e
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@rustbot review |
rustbot
added
S-waiting-on-review
jdonszelmann
force-pushed
the
refactor-attr-parsing
branch
from
a59705e to
0d2b46c
Compare
jdonszelmann
force-pushed
the
refactor-attr-parsing
branch
from
0d2b46c to
4791dc5
Compare
Contributor
Author
|
the rangediff shows a test output changed related to attrs on foreign types which got introduced very recently, hence the conflict. That's why I pushed again to fix that, that was unintentional but the current version is good in that regard. |
Contributor
Author
|
i.e. the rangediff shows this bit as removed but I added it back in afterwards: |
Collaborator
|
☔ The latest upstream changes (presumably #145600) made this pull request unmergeable. Please resolve the merge conflicts. |
jdonszelmann
force-pushed
the
refactor-attr-parsing
branch
from
4791dc5 to
e1188c4
Compare
This comment has been minimized.
This comment has been minimized.
Member
|
@bors delegate+ |
Collaborator
|
✌️ @jdonszelmann, you can now approve this pull request! If @davidtwco told you to " |
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
refactor-attr-parsing
branch
2 times, most recently
from
1152a2c to
49d030b
Compare
Contributor
Author
|
@bors r=davidtwco |
Collaborator
bors
added
S-waiting-on-bors
jdonszelmann
force-pushed
the
refactor-attr-parsing
branch
from
49d030b to
becefdd
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@bors r=davidtwco |
Collaborator
bors
added a commit
that referenced
this pull request
Aug 21, 2025
Rollup of 16 pull requests Successful merges: - #137494 (libstd: init(): dup() subsequent /dev/nulls instead of opening them again) - #144541 (c-variadic: multiple ABIs in the same program for arm) - #144613 (aarch64-nintendo-switch-freestanding - Enable CPU features that are always available in a live system (crypto instructions, plus explicit NEON).) - #144780 (Add a method to dump MIR in the middle of MIR building) - #145137 (Consolidate panicking functions in `slice/index.rs`) - #145507 (Refactor attribute parsing to improve ergonomics and some diagnostics) - #145604 (Gate static closures behind a parser feature) - #145648 (Add two tidy dependency checks) - #145661 (update some s390x codegen tests) - #145672 (Instantiate higher-ranked binder with erased when checking `IntoIterator` predicate for query instability) - #145689 (Migrate `panic_unwind` to use `cfg_select!`) - #145700 (Handle `ReEarlyParam` in `type_name`.) - #145703 (Remove MIPS targets from CI LLVM platforms) - #145704 (ci: don't cleanup windows disk) - #145705 (remove an `as` cast in prefetch codegen) - #145712 (Update outdated link in bound region comments) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Aug 22, 2025
Rollup merge of #145507 - jdonszelmann:refactor-attr-parsing, r=davidtwco Refactor attribute parsing to improve ergonomics and some diagnostics
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Aug 22, 2025
Rollup of 16 pull requests Successful merges: - rust-lang/rust#137494 (libstd: init(): dup() subsequent /dev/nulls instead of opening them again) - rust-lang/rust#144541 (c-variadic: multiple ABIs in the same program for arm) - rust-lang/rust#144613 (aarch64-nintendo-switch-freestanding - Enable CPU features that are always available in a live system (crypto instructions, plus explicit NEON).) - rust-lang/rust#144780 (Add a method to dump MIR in the middle of MIR building) - rust-lang/rust#145137 (Consolidate panicking functions in `slice/index.rs`) - rust-lang/rust#145507 (Refactor attribute parsing to improve ergonomics and some diagnostics) - rust-lang/rust#145604 (Gate static closures behind a parser feature) - rust-lang/rust#145648 (Add two tidy dependency checks) - rust-lang/rust#145661 (update some s390x codegen tests) - rust-lang/rust#145672 (Instantiate higher-ranked binder with erased when checking `IntoIterator` predicate for query instability) - rust-lang/rust#145689 (Migrate `panic_unwind` to use `cfg_select!`) - rust-lang/rust#145700 (Handle `ReEarlyParam` in `type_name`.) - rust-lang/rust#145703 (Remove MIPS targets from CI LLVM platforms) - rust-lang/rust#145704 (ci: don't cleanup windows disk) - rust-lang/rust#145705 (remove an `as` cast in prefetch codegen) - rust-lang/rust#145712 (Update outdated link in bound region comments) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.