Rollup of 19 pull requests by Zalathar · Pull Request #145552 · rust-lang/rust

Zalathar · 2025-08-18T05:33:37Z

Successful merges:

impl PartialEq<{str,String}> for {Path,PathBuf} #140956 (impl PartialEq<{str,String}> for {Path,PathBuf})
Stabilize ip_from #141744 (Stabilize ip_from)
Don't warn on never to any as casts as unreachable #144804 (Don't warn on never to any as casts as unreachable)
Rehome 37 tests/ui/issues/ tests to other subdirectories under tests/ui/ #144983 (Rehome 37 tests/ui/issues/ tests to other subdirectories under tests/ui/)
run spellcheck as a tidy extra check in ci #145025 (run spellcheck as a tidy extra check in ci)
rework GAT borrowck limitation error #145041 (rework GAT borrowck limitation error)
take attr style into account in diagnostics #145243 (take attr style into account in diagnostics)
Fix bug where rustdoc-js tester would not pick the right search.js file if there is more than one #145359 (Fix bug where rustdoc-js tester would not pick the right search.js file if there is more than one)
Couple of codegen_fn_attrs improvements #145429 (Couple of codegen_fn_attrs improvements)
Do not strip binaries in bootstrap everytime if they are unchanged #145452 (Do not strip binaries in bootstrap everytime if they are unchanged)
Fix unicode_data.rs mention message #145486 (Fix unicode_data.rs mention message)
library: Migrate from cfg_if to cfg_select #145489 (library: Migrate from cfg_if to cfg_select)
remove should_render in PrintAttribute derive #145493 (remove should_render in PrintAttribute derive)
Port must_use to the new target checking #145500 (Port must_use to the new target checking)
Simplify span caches #145505 (Simplify span caches)
Rust build fails on OpenBSD after using file_lock feature #145511 (Rust build fails on OpenBSD after using file_lock feature)
Weekly cargo update #145516 (Weekly cargo update)
Reorder lto options from most to least optimizing #145533 (Reorder lto options from most to least optimizing)
Avoid using () in derive(From) output. #145550 (Avoid using () in derive(From) output.)

r? @ghost
@rustbot modify labels: rollup

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions. ACP: rust-lang/libs-team#151

Migrate the standard library from using the external `cfg_if` crate to using the now-built-in `cfg_select` macro. This does not yet eliminate the dependency from `library/std/Cargo.toml`, because while the standard library itself no longer uses `cfg_if`, it also incorporates the `backtrace` crate, which does. Migration assisted by the following vim command (after selecting the full `cfg_if!` invocation): ``` '<,'>s/\(cfg_if::\)\?cfg_if/cfg_select/ | '<,'>s/^\( *\)} else {/\1}\r\1_ => {/c | '<,'>s/^\( *\)} else if #\[cfg(\(.*\))\] /\1}\r\1\2 => /e | '<,'>s/if #\[cfg(\(.*\))\] {/\1 => {/e ``` This is imperfect, but substantially accelerated the process. This prompts for confirmation on the `} else {` since that can also appear inside one of the arms. This also requires manual intervention to handle any multi-line conditions.

…` file if there is more than one

Zalathar · 2025-08-18T05:33:57Z

Rollup of everything not in #145551.

@bors r+ rollup=never p=5

bors · 2025-08-18T05:33:59Z

📌 Commit 052b913 has been approved by Zalathar

It is now in the queue for this repository.

Zalathar · 2025-08-18T05:36:16Z

@bors try jobs=test-various,x86_64-gnu-llvm-19-3,dist-ohos-x86_64,aarch64-apple

Rollup of 19 pull requests try-job: test-various try-job: x86_64-gnu-llvm-19-3 try-job: dist-ohos-x86_64 try-job: aarch64-apple

rust-bors · 2025-08-18T07:51:25Z

☀️ Try build successful (CI)
Build commit: 516ae4f (516ae4fb01ea79a2fc18c179312f529434633068, parent: 425a9c0a0e365c0b8c6cfd00c2ded83a73bed9a0)

bors · 2025-08-18T10:21:14Z

⌛ Testing commit 052b913 with merge 867877d...

Rollup of 19 pull requests Successful merges: - #140956 (`impl PartialEq<{str,String}> for {Path,PathBuf}`) - #141744 (Stabilize `ip_from`) - #144804 (Don't warn on never to any `as` casts as unreachable) - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145025 (run spellcheck as a tidy extra check in ci) - #145041 (rework GAT borrowck limitation error) - #145243 (take attr style into account in diagnostics) - #145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one) - #145429 (Couple of codegen_fn_attrs improvements) - #145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - #145486 (Fix `unicode_data.rs` mention message) - #145489 (library: Migrate from `cfg_if` to `cfg_select`) - #145493 (remove `should_render` in `PrintAttribute` derive) - #145500 (Port must_use to the new target checking) - #145505 (Simplify span caches) - #145511 (Rust build fails on OpenBSD after using file_lock feature) - #145516 (Weekly `cargo update`) - #145533 (Reorder `lto` options from most to least optimizing) - #145550 (Avoid using `()` in `derive(From)` output.) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-08-18T10:56:28Z

The job dist-loongarch64-musl failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


error[E0659]: `STATX_NLINK` is ambiguous
   --> /rust/deps/rustix-1.0.8/src/fs/statx.rs:79:26
    |
 79 |         const NLINK = c::STATX_NLINK;
    |                          ^^^^^^^^^^^ ambiguous name
    |
    = note: ambiguous because of multiple glob imports of a name in the same module
note: `STATX_NLINK` could refer to the constant imported here
   --> /rust/deps/rustix-1.0.8/src/backend/libc/c.rs:7:16
    |
---
512 | pub(crate) use statx_flags::*;
    |                ^^^^^^^^^^^^^^
    = help: consider adding an explicit import of `STATX_NLINK` to disambiguate

error[E0659]: `STATX_UID` is ambiguous
   --> /rust/deps/rustix-1.0.8/src/fs/statx.rs:82:24
    |
 82 |         const UID = c::STATX_UID;
    |                        ^^^^^^^^^ ambiguous name
    |
    = note: ambiguous because of multiple glob imports of a name in the same module
note: `STATX_UID` could refer to the constant imported here
   --> /rust/deps/rustix-1.0.8/src/backend/libc/c.rs:7:16
    |
---
512 | pub(crate) use statx_flags::*;
    |                ^^^^^^^^^^^^^^
    = help: consider adding an explicit import of `STATX_UID` to disambiguate

error[E0659]: `STATX_GID` is ambiguous
   --> /rust/deps/rustix-1.0.8/src/fs/statx.rs:85:24
    |
 85 |         const GID = c::STATX_GID;
    |                        ^^^^^^^^^ ambiguous name
    |
    = note: ambiguous because of multiple glob imports of a name in the same module
note: `STATX_GID` could refer to the constant imported here
   --> /rust/deps/rustix-1.0.8/src/backend/libc/c.rs:7:16
    |
---

error[E0659]: `STATX_ATIME` is ambiguous
   --> /rust/deps/rustix-1.0.8/src/fs/statx.rs:88:26
    |
 88 |         const ATIME = c::STATX_ATIME;
    |                          ^^^^^^^^^^^ ambiguous name
    |
    = note: ambiguous because of multiple glob imports of a name in the same module
note: `STATX_ATIME` could refer to the constant imported here
   --> /rust/deps/rustix-1.0.8/src/backend/libc/c.rs:7:16
    |
---

error[E0659]: `STATX_MTIME` is ambiguous
   --> /rust/deps/rustix-1.0.8/src/fs/statx.rs:91:26
    |
 91 |         const MTIME = c::STATX_MTIME;
    |                          ^^^^^^^^^^^ ambiguous name
    |
    = note: ambiguous because of multiple glob imports of a name in the same module
note: `STATX_MTIME` could refer to the constant imported here
   --> /rust/deps/rustix-1.0.8/src/backend/libc/c.rs:7:16
    |
---
512 | pub(crate) use statx_flags::*;
    |                ^^^^^^^^^^^^^^
    = help: consider adding an explicit import of `STATX_CTIME` to disambiguate

error[E0659]: `STATX_INO` is ambiguous
   --> /rust/deps/rustix-1.0.8/src/fs/statx.rs:97:24
    |
 97 |         const INO = c::STATX_INO;
    |                        ^^^^^^^^^ ambiguous name
    |
    = note: ambiguous because of multiple glob imports of a name in the same module
note: `STATX_INO` could refer to the constant imported here
   --> /rust/deps/rustix-1.0.8/src/backend/libc/c.rs:7:16
    |
---

error[E0659]: `STATX_BTIME` is ambiguous
   --> /rust/deps/rustix-1.0.8/src/fs/statx.rs:109:26
    |
109 |         const BTIME = c::STATX_BTIME;
    |                          ^^^^^^^^^^^ ambiguous name
    |
    = note: ambiguous because of multiple glob imports of a name in the same module
note: `STATX_BTIME` could refer to the constant imported here
   --> /rust/deps/rustix-1.0.8/src/backend/libc/c.rs:7:16
    |
---
512 | pub(crate) use statx_flags::*;
    |                ^^^^^^^^^^^^^^
    = help: consider adding an explicit import of `STATX_BTIME` to disambiguate

error[E0659]: `STATX_MNT_ID` is ambiguous
   --> /rust/deps/rustix-1.0.8/src/fs/statx.rs:112:27
    |
112 |         const MNT_ID = c::STATX_MNT_ID;
    |                           ^^^^^^^^^^^^ ambiguous name
    |
    = note: ambiguous because of multiple glob imports of a name in the same module
note: `STATX_MNT_ID` could refer to the constant imported here
   --> /rust/deps/rustix-1.0.8/src/backend/libc/c.rs:7:16
    |
---
512 | pub(crate) use statx_flags::*;
    |                ^^^^^^^^^^^^^^
    = help: consider adding an explicit import of `STATX_MNT_ID` to disambiguate

error[E0659]: `STATX_DIOALIGN` is ambiguous
   --> /rust/deps/rustix-1.0.8/src/fs/statx.rs:115:29
    |
115 |         const DIOALIGN = c::STATX_DIOALIGN;
    |                             ^^^^^^^^^^^^^^ ambiguous name
    |
    = note: ambiguous because of multiple glob imports of a name in the same module
note: `STATX_DIOALIGN` could refer to the constant imported here
   --> /rust/deps/rustix-1.0.8/src/backend/libc/c.rs:7:16
    |
  7 | pub(crate) use libc::*;
    |                ^^^^^^^
    = help: consider adding an explicit import of `STATX_DIOALIGN` to disambiguate
note: `STATX_DIOALIGN` could also refer to the constant imported here
   --> /rust/deps/rustix-1.0.8/src/backend/libc/c.rs:512:16
    |
512 | pub(crate) use statx_flags::*;
    |                ^^^^^^^^^^^^^^
    = help: consider adding an explicit import of `STATX_DIOALIGN` to disambiguate

error[E0659]: `STATX_ALL` is ambiguous
   --> /rust/deps/rustix-1.0.8/src/fs/statx.rs:118:24
    |
118 |         const ALL = c::STATX_ALL;
---
512 | pub(crate) use statx_flags::*;
    |                ^^^^^^^^^^^^^^
    = help: consider adding an explicit import of `STATX_ATTR_APPEND` to disambiguate

error[E0659]: `STATX_ATTR_NODUMP` is ambiguous
   --> /rust/deps/rustix-1.0.8/src/fs/statx.rs:140:27
    |
140 |         const NODUMP = c::STATX_ATTR_NODUMP as u64;
    |                           ^^^^^^^^^^^^^^^^^ ambiguous name
    |
    = note: ambiguous because of multiple glob imports of a name in the same module
note: `STATX_ATTR_NODUMP` could refer to the constant imported here
   --> /rust/deps/rustix-1.0.8/src/backend/libc/c.rs:7:16
    |
  7 | pub(crate) use libc::*;
    |                ^^^^^^^
    = help: consider adding an explicit import of `STATX_ATTR_NODUMP` to disambiguate
note: `STATX_ATTR_NODUMP` could also refer to the constant imported here
   --> /rust/deps/rustix-1.0.8/src/backend/libc/c.rs:512:16
    |
512 | pub(crate) use statx_flags::*;
    |                ^^^^^^^^^^^^^^
    = help: consider adding an explicit import of `STATX_ATTR_NODUMP` to disambiguate

error[E0659]: `STATX_ATTR_ENCRYPTED` is ambiguous
   --> /rust/deps/rustix-1.0.8/src/fs/statx.rs:143:30
    |
143 |         const ENCRYPTED = c::STATX_ATTR_ENCRYPTED as u64;
---
512 | pub(crate) use statx_flags::*;
    |                ^^^^^^^^^^^^^^
    = help: consider adding an explicit import of `STATX_ATTR_VERITY` to disambiguate

error[E0659]: `STATX_ATTR_DAX` is ambiguous
   --> /rust/deps/rustix-1.0.8/src/fs/statx.rs:155:24
    |
155 |         const DAX = c::STATX_ATTR_DAX as u64;
    |                        ^^^^^^^^^^^^^^ ambiguous name
    |
    = note: ambiguous because of multiple glob imports of a name in the same module
note: `STATX_ATTR_DAX` could refer to the constant imported here
   --> /rust/deps/rustix-1.0.8/src/backend/libc/c.rs:7:16
    |
  7 | pub(crate) use libc::*;
    |                ^^^^^^^
    = help: consider adding an explicit import of `STATX_ATTR_DAX` to disambiguate
note: `STATX_ATTR_DAX` could also refer to the constant imported here
   --> /rust/deps/rustix-1.0.8/src/backend/libc/c.rs:512:16
    |
512 | pub(crate) use statx_flags::*;
    |                ^^^^^^^^^^^^^^
    = help: consider adding an explicit import of `STATX_ATTR_DAX` to disambiguate

[RUSTC-TIMING] tracing_attributes test:false 2.563
   Compiling tracing v0.1.37
[RUSTC-TIMING] proc_macro_hack test:false 1.085
[RUSTC-TIMING] unic_langid_impl test:false 0.440

bors · 2025-08-18T10:57:12Z

💔 Test failed - checks-actions

Kixunil and others added 30 commits May 13, 2025 23:41

impl PartialEq<{str,String}> for {Path,PathBuf}

aab1563

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions. ACP: rust-lang/libs-team#151

Stabilize ip_from

964eb82

refactor unreachable/expr_cast.rs test

a067c6a

don't warn on explicit casts of never to any

d2e133d

avoid duplicate error string

4e2d420

also consider HR bounds

d62e857

rework add_placeholder_from_predicate_note

a95a2ac

add comment

5c716bd

it's not a borrow checker limitation :<

3ebf611

All weak lang items have an explicit link name and vice versa

4d62bf1

Combining no_mangle and rustc_std_internal_symbol is not allowed

f3ef465

Merge link_name and export_name

460519a

Remove unused feature gate

f94a0d0

Do not strip binaries in bootstrap everytime if they are unchanged

ef3bb6f

take attr style into account in attr diagnostics

70e26c1

Fix unicode_data.rs mention message

e906a59

remove should_render in PrintAttribute derive

3450975

run spellcheck as a tidy extra check in ci

e31fed0

Make tool-only suggestion to remove attributes on invalid targets

4de539b

Port must_use to the new target checking

83701e0

Update uitests

b9d3145

Simplify decode_span.

6c15339

Simplify span_data_to_lines_and_cols.

a843730

tidy now installs typos-cli as-needed via cargo

1cb4fd7

tidy: run typos check in src root, not current dir

6a51eef

tidy: add better error reporting for if typos can't be run

d73e6b4

typos: allow moreso

0d797d2

std: fix more typos

2050a3b

Fix bug where rustdoc-js tester would not pick the right `search.js…

80d3234

…` file if there is more than one

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Aug 18, 2025

Auto merge of #145552 - Zalathar:rollup-l0f96kg, r=<try>

516ae4f

Rollup of 19 pull requests try-job: test-various try-job: x86_64-gnu-llvm-19-3 try-job: dist-ohos-x86_64 try-job: aarch64-apple

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 18, 2025

This was referenced Aug 18, 2025

Update cargo #145478

Merged

Weekly cargo update #145516

Open

Rollup of 18 pull requests #145566

Closed

Zalathar closed this Aug 18, 2025

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2025

Zalathar deleted the rollup-l0f96kg branch August 18, 2025 11:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 19 pull requests#145552

Rollup of 19 pull requests#145552
Zalathar wants to merge 57 commits intorust-lang:masterfrom
Zalathar:rollup-l0f96kg

Zalathar commented Aug 18, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Aug 18, 2025

Uh oh!

bors commented Aug 18, 2025

Uh oh!

Zalathar commented Aug 18, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Aug 18, 2025

Uh oh!

bors commented Aug 18, 2025

Uh oh!

rust-log-analyzer commented Aug 18, 2025

Uh oh!

bors commented Aug 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Uh oh!

Conversation

Zalathar commented Aug 18, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Aug 18, 2025

Uh oh!

bors commented Aug 18, 2025

Uh oh!

Zalathar commented Aug 18, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Aug 18, 2025

Uh oh!

bors commented Aug 18, 2025

Uh oh!

rust-log-analyzer commented Aug 18, 2025

Uh oh!

bors commented Aug 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Zalathar commented Aug 18, 2025 •

edited by rustbot

Loading