Skip to content

Add -Awarnings on tests for ignoring warning from xcrun#145570

Closed
Shunpoco wants to merge 1 commit intorust-lang:masterfrom
Shunpoco:issue-145543-warning-on-macos
Closed

Add -Awarnings on tests for ignoring warning from xcrun#145570
Shunpoco wants to merge 1 commit intorust-lang:masterfrom
Shunpoco:issue-145543-warning-on-macos

Conversation

@Shunpoco
Copy link
Contributor

@Shunpoco Shunpoco commented Aug 18, 2025 •
edited by rustbot
Loading

Context

close #145543
Those two tests fail on MacOS because xcrun puts a warning on StdErr.
The warning is only shown when we put -Zverbose-internals flag to the compiler.

Change

I added -Awarnings to those two tests to ignore the warning, because

  1. verbose output from 3rd party tools like xcrun are sometimes useful for debugging
  2. the warning doesn't ask us to take any actions (it looks just info-level log, I'm not sure why xcrun decided to output the message as warning), so we can safely ignore it I think

@Shunpoco
Add -Awarnings flag on tests
fa10fc4 
Those tests fail because wcrun on MacOS outputs.
This is because they have -Zverbose-internals flag,
Since it only happens on MacOS and we can't manage
the 3rd party warning, ignoring the warning is better.

Signed-off-by: Shunpoco <tkngsnsk313320@gmail.com>
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 18, 2025
@Shunpoco Shunpoco changed the title [WIP] Add -Awarnings flag on tests for ignoring warning from xcrun Add -Awarnings on tests for ignoring warning from xcrun Aug 18, 2025
@Shunpoco
Copy link
Contributor Author

Shunpoco commented Aug 18, 2025

r? @jieyouxu

@Shunpoco Shunpoco marked this pull request as ready for review August 18, 2025 13:33
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 18, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Aug 18, 2025

To me, this seems like papering over the root problem that -Z verbose-internals seem to be ... confusing, in terms of what it is supposed to do. That is, I feel like showing more output from xcrun when -Z verbose-internals based on flag name verbatim seems like a very reasonable thing to do. But it looks like the root problem is we probably need different flags between -ZI-want-verbose-type-system-details versus -ZI-want-linker-output...

Based on at least #103428, I don't think allowing warnings here is the right thing to do.

@jieyouxu jieyouxu mentioned this pull request Aug 18, 2025
Closed
@jieyouxu
Copy link
Member

jieyouxu commented Aug 18, 2025

I don't quite have the bandwidth to look into this ATM, sorry.
r? @madsmtm

@rustbot rustbot assigned madsmtm and unassigned jieyouxu Aug 18, 2025
@madsmtm
Copy link
Contributor

madsmtm commented Aug 25, 2025 •
edited
Loading

Sorry for the delay. I agree that this isn't the right thing to do, and I have filed #145847 to fix it by not tying xcrun verbosity to -Zverbose-internals.

Thanks for the initiative though @Shunpoco!

@madsmtm madsmtm closed this Aug 25, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2025
@Shunpoco Shunpoco deleted the issue-145543-warning-on-macos branch August 25, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@madsmtm madsmtm

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Two ui tests fail with warning on MacOS

4 participants

@Shunpoco @jieyouxu @madsmtm @rustbot