Closed
Conversation
Update "between" to "among" (more than two items), connect the "which" dependent clause to the independent part, and remove the redundant "here".
I was just looking at the specifics of how the parsing is handled here and I wasn't sure if the examples were incomplete or the grammar below was misleading. The grammar was correct so I figured I'd add these examples to clarify.
Fix adjacent code Fix duplicate warning; merge test into `tests/ui-fulldeps/internal-lints` Use `rustc_middle::ty::FnSig::inputs` Address two review comments - rust-lang#139345 (comment) - rust-lang#139345 (comment) Use `Instance::try_resolve` Import `rustc_middle::ty::Ty` as `Ty` rather than `MiddleTy` Simplify predicate handling Add more `#[allow(rustc::potential_query_instability)]` following rebase Remove two `#[allow(rustc::potential_query_instability)]` following rebase Address review comment Update compiler/rustc_lint/src/internal.rs Co-authored-by: lcnr <rust@lcnr.de>
PR 130999 added the file_lock feature, but doesn't included OpenBSD in the supported targets (Tier 3 platform), leading to a compilation error ("try_lock() not supported").
rustbot
added
T-rustdoc-frontend
Member
Author
|
Let's do a try build due to the enormous size. @bors2 try |
Contributor
rust-bors bot
added a commit
that referenced
this pull request
Aug 18, 2025
Rollup of 33 pull requests
Member
|
Note that the default try build doesn't run any tests and doesn't actually build much stuff, apart from what would already get built on PR CI. |
Member
Author
|
In that case, @bors2 try cancel What should be run instead? |
Contributor
|
Try build cancelled. Cancelled workflows: |
Member
Author
|
After discussion on Zulip, @bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Aug 19, 2025
Rollup of 33 pull requests Successful merges: - #139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - #140740 (Add `-Zindirect-branch-cs-prefix`) - #142079 (nll-relate: improve hr opaque types support) - #142938 (implement std::fs::set_permissions_nofollow on unix) - #144767 (Correct some grammar in integer documentation) - #144906 (Require approval from t-infra instead of t-release on tier bumps) - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145025 (run spellcheck as a tidy extra check in ci) - #145166 (suggest using `pub(crate)` for E0364) - #145255 (dec2flt: Provide more valid inputs examples) - #145306 (Add tracing to various miscellaneous functions) - #145336 (Hide docs for `core::unicode`) - #145429 (Couple of codegen_fn_attrs improvements) - #145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - #145464 (Stabilize `const_pathbuf_osstring_new` feature) - #145474 (Properly recover from parenthesized use-bounds (precise capturing lists) plus small cleanups) - #145486 (Fix `unicode_data.rs` mention message) - #145493 (remove `should_render` in `PrintAttribute` derive) - #145505 (Simplify span caches) - #145510 (Visit and print async_fut local for async drop.) - #145511 (Rust build fails on OpenBSD after using file_lock feature) - #145532 (resolve: debug for block module) - #145533 (Reorder `lto` options from most to least optimizing) - #145537 (Do not consider a `T: !Sized` candidate to satisfy a `T: !MetaSized` obligation.) - #145538 (bufreader::Buffer::backshift: don't move the uninit bytes) - #145542 (triagebot: Don't warn no-mentions on subtree updates) - #145549 (Update rust maintainers in openharmony.md) - #145550 (Avoid using `()` in `derive(From)` output.) - #145556 (Allow stability attributes on extern crates) - #145560 (Remove unused `PartialOrd`/`Ord` from bootstrap) - #145568 (ignore frontmatters in `TokenStream::new`) - #145571 (remove myself from some adhoc-groups and pings) - #145576 (Add change tracker entry for `--timings`) r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
|
GitHub is once again refusing to show useful logs, so I'm going to assume that the GHA runners exploded again. @bors retry |
bors
added
S-waiting-on-bors
Member
Author
|
Looks like either msvc or mingw failed, judging from the status icons alone. Given that I agree it's reasonable to retry. |
Contributor
For the failed job, click the "annotations" dropdown to see this (indeed it was spurious) 
|
Member
bors
added
S-waiting-on-author
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
QueryStabilityto handleIntoIteratorimplementations #139345 (ExtendQueryStabilityto handleIntoIteratorimplementations)-Zindirect-branch-cs-prefix#140740 (Add-Zindirect-branch-cs-prefix)tests/ui/issues/tests to other subdirectories undertests/ui/#144983 (Rehome 37tests/ui/issues/tests to other subdirectories undertests/ui/)pub(crate)for E0364 #145166 (suggest usingpub(crate)for E0364)core::unicode#145336 (Hide docs forcore::unicode)const_pathbuf_osstring_newfeature #145464 (Stabilizeconst_pathbuf_osstring_newfeature)unicode_data.rsmention message #145486 (Fixunicode_data.rsmention message)should_renderinPrintAttributederive #145493 (removeshould_renderinPrintAttributederive)ltooptions from most to least optimizing #145533 (Reorderltooptions from most to least optimizing)T: !Sizedcandidate to satisfy aT: !MetaSizedobligation. #145537 (Do not consider aT: !Sizedcandidate to satisfy aT: !MetaSizedobligation.)()inderive(From)output. #145550 (Avoid using()inderive(From)output.)PartialOrd/Ordfrom bootstrap #145560 (Remove unusedPartialOrd/Ordfrom bootstrap)TokenStream::new#145568 (ignore frontmatters inTokenStream::new)--timings#145576 (Add change tracker entry for--timings)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup