Rollup of 20 pull requests by jhpratt · Pull Request #145764 · rust-lang/rust

jhpratt · 2025-08-22T20:01:52Z

Successful merges:

Fix overly restrictive lifetime in core::panic::Location::file return type #132087 (Fix overly restrictive lifetime in core::panic::Location::file return type)
Recover param: Ty = EXPR #137396 (Recover param: Ty = EXPR)
Convert moves of references to copies in ReferencePropagation #142185 (Convert moves of references to copies in ReferencePropagation)
Make target pointer width in target json an integer #144443 (Make target pointer width in target json an integer)
Implementation: #[feature(nonpoison_rwlock)] #144648 (Implementation: #[feature(nonpoison_rwlock)])
print raw lifetime idents with r# #144897 (print raw lifetime idents with r#)
[Debuginfo] improve enum value formatting in LLDB for better readability #145218 ([Debuginfo] improve enum value formatting in LLDB for better readability)
Add codegen-llvm regression tests #145380 (Add codegen-llvm regression tests)
Add an experimental unsafe(force_target_feature) attribute. #145573 (Add an experimental unsafe(force_target_feature) attribute.)
resolve: Remove ScopeSet::Late #145597 (resolve: Remove ScopeSet::Late)
On E0277, point at type that doesn't implement bound #145641 (On E0277, point at type that doesn't implement bound)
rustdoc-search: GUI tests check for // in URL #145669 (rustdoc-search: GUI tests check for // in URL)
Introduce ProjectionElem::try_map. #145695 (Introduce ProjectionElem::try_map.)
Fix the ABI parameter inconsistency issue in debug.rs for LoongArch64 #145710 (Fix the ABI parameter inconsistency issue in debug.rs for LoongArch64)
Experiment: Reborrow trait #145726 (Experiment: Reborrow trait)
Make raw pointers work in type-based search #145731 (Make raw pointers work in type-based search)
triagebot: Update style team reviewers #145736 (triagebot: Update style team reviewers)
Uplift rustc_mir_transform::coverage::counters::union_find to rustc_data_structures. #145738 (Uplift rustc_mir_transform::coverage::counters::union_find to rustc_data_structures.)
doc: fix some typos in comment #145743 (doc: fix some typos in comment)
tests: Ignore basic-stepping.rs on LoongArch #145745 (tests: Ignore basic-stepping.rs on LoongArch)

Failed merges:

port sanitize attribute to the new parsing infrastructure #145670 (port sanitize attribute to the new parsing infrastructure)

r? @ghost
@rustbot modify labels: rollup

This commit is a purely cosmetic change to the documentation and ordering of items in the `rwlock.rs` file, which will help discern the actual difference between the `nonpoison` and `poison` variants of `rwlock`. List of changes (lots of small things): - Clean up some of the existing field doc comments - Add documentation for every field in struct definitions - Consolidate related implementation blocks (1 implementation block per guard instead of 2) - Use the lifetime name `'rwlock` instead of `'a` - Reorder implementation blocks to be consistent across the entire file (follows the order `ReadGuard`, `WriteGuard`, `MappedReadGuard`, MappedWriteGuard`) - Move simple trait implementations to the bottom of the file - Rename the `poison` field in `MappedRwLockWriteGuard` to posion_guard` - Cut off comments at 100 columns - Update the documentation of `downgrade` to match stabilization PR # 143191

Adds the equivalent `nonpoison` types to the `poison::rwlock` module. These types and implementations are gated under the `nonpoison_rwlock` feature gate. Also blesses the ui tests that now have a name conflicts (because these types no longer have unique names). The full path distinguishes the different types.

This commit simply helps discern the actual changes needed to test both poison and nonpoison `rwlock`s.

Adds tests for the `nonpoison::RwLock` variant by using a macro to duplicate the existing `poison` tests. Note that all of the tests here are adapted from the existing `poison` tests.

…e classification

Most of these regressions concern elimination of panics and bounds checks that were fixed upstream by LLVM.

When this fails, you get output that looks like: /home/user/rust/tests/rustdoc-gui/search-result-impl-disambiguation.goml search-result-impl-disambiguation... FAILED [ERROR] `tests/rustdoc-gui/utils.goml` around line 49 from `tests/rustdoc-gui/search-result-impl-disambiguation.goml` line 25: JS errors occurred: Event: Event Making the error message more informative requires patching browser-ui-test.

This uses the feature gate for rust-lang#143352, but is described in rust-lang/rfcs#3820 which is strongly tied to the experiment.

jhpratt · 2025-08-22T20:02:22Z

@bors r+ rollup=never p=5

@bors2 try jobs=test-various

bors · 2025-08-22T20:02:24Z

📌 Commit 555ef1c has been approved by jhpratt

It is now in the queue for this repository.

Rollup of 20 pull requests try-job: test-various

rust-bors · 2025-08-22T21:43:45Z

☀️ Try build successful (CI)
Build commit: 43cca68 (43cca68ca1744eb2b70388d4da1b50385ccd4dbe, parent: d20509c2a0c71b60aa2b51566e4d14920e8a1661)

bors · 2025-08-23T00:56:12Z

⌛ Testing commit 555ef1c with merge e7978bd...

Rollup of 20 pull requests Successful merges: - #132087 (Fix overly restrictive lifetime in `core::panic::Location::file` return type) - #137396 (Recover `param: Ty = EXPR`) - #142185 (Convert moves of references to copies in ReferencePropagation) - #144443 (Make target pointer width in target json an integer) - #144648 (Implementation: `#[feature(nonpoison_rwlock)]`) - #144897 (print raw lifetime idents with r#) - #145218 ([Debuginfo] improve enum value formatting in LLDB for better readability) - #145380 (Add codegen-llvm regression tests) - #145573 (Add an experimental unsafe(force_target_feature) attribute.) - #145597 (resolve: Remove `ScopeSet::Late`) - #145641 (On E0277, point at type that doesn't implement bound) - #145669 (rustdoc-search: GUI tests check for `//` in URL) - #145695 (Introduce ProjectionElem::try_map.) - #145710 (Fix the ABI parameter inconsistency issue in debug.rs for LoongArch64) - #145726 (Experiment: Reborrow trait) - #145731 (Make raw pointers work in type-based search) - #145736 (triagebot: Update style team reviewers) - #145738 (Uplift rustc_mir_transform::coverage::counters::union_find to rustc_data_structures.) - #145743 (doc: fix some typos in comment) - #145745 (tests: Ignore basic-stepping.rs on LoongArch) Failed merges: - #145670 (port `sanitize` attribute to the new parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-08-23T01:57:15Z

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2025-08-23T01:57:51Z

💔 Test failed - checks-actions

Read a real target spec JSON so we no longer need to hardcode a target spec JSON here. Cargo itself should not care about the spec schema. Let's stop bothering compiler contributors. * rust-lang/rust#144443 * rust-lang/rust#145764 (comment) * [#t-compiler > Is it possible to add a commit to a submodule? @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Is.20it.20possible.20to.20add.20a.20commit.20to.20a.20submodule.3F/near/535865215)

ijchen and others added 30 commits August 2, 2025 16:43

corrected lifetime in core::panic::Location::file return type

e772f7a

added regression test for core::panic::Location::file's lifetime

9c4a35e

corrected lifetime in core::panic::Location::file return type

5577370

moved new test to updated test location

8a0438f

updated line number in test

792ec3b

allow using target_val! with a rename

8adc296

turn pointer width into an integer in target.json

be42f3f

accept integer target-pointer-width in compiletest

6caa8ff

fix target-pointer-width in tests

51134eb

reorganize rwlock tests

d8a0df0

This commit simply helps discern the actual changes needed to test both poison and nonpoison `rwlock`s.

add nonpoison and poison rwlock tests

ad499d0

Adds tests for the `nonpoison::RwLock` variant by using a macro to duplicate the existing `poison` tests. Note that all of the tests here are adapted from the existing `poison` tests.

Convert moves of references to copies in RefProp

9aa8cfa

feat(lldb debug info): improve enum value formatting in lldb

12eb1a0

feat(lldb debug info): deref pointer types for more accurate rust typ…

c39ebea

…e classification

fix: python formatting error

6be749b

Introduce ProjectionElem::try_map.

37e7f52

Add codegen regression tests

9e28de2

Most of these regressions concern elimination of panics and bounds checks that were fixed upstream by LLVM.

Fix the ABI parameter inconsistency issue in debug.rs for LoongArch64

d07009c

Introduce reborrow unstable feature

719880d

make primitive:pointer work in type-based search.

ead9f58

Introduce Reborrow lang item and trait

5af3591

Add reborrow feature gate test

fd44708

rustdoc search: accept *mut T syntax for raw pointers

4b730a2

add special formatting for displaying raw pointers in signatures

ae9845f

unbox raw pointers in type-based search

eeaad50

rustdoc: add tests for raw pointers in type-based search

3501e4f

Add an experimental unsafe(force_target_feature) attribute.

291da71

This uses the feature gate for rust-lang#143352, but is described in rust-lang/rfcs#3820 which is strongly tied to the experiment.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Aug 22, 2025

Auto merge of #145764 - jhpratt:rollup-uzej5kg, r=<try>

43cca68

Rollup of 20 pull requests try-job: test-various

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 23, 2025

jhpratt closed this Aug 23, 2025

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 23, 2025

jhpratt deleted the rollup-uzej5kg branch August 23, 2025 01:58

jhpratt mentioned this pull request Aug 23, 2025

Make target pointer width in target json an integer #144443

Merged

weihanglo mentioned this pull request Aug 23, 2025

test: avoid hardcoded target spec json rust-lang/cargo#15880

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 20 pull requests#145764

Rollup of 20 pull requests#145764
jhpratt wants to merge 66 commits intorust-lang:masterfrom
jhpratt:rollup-uzej5kg

jhpratt commented Aug 22, 2025 •

edited by rustbot

Loading

Uh oh!

jhpratt commented Aug 22, 2025

Uh oh!

bors commented Aug 22, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Aug 22, 2025

Uh oh!

bors commented Aug 23, 2025

Uh oh!

rust-log-analyzer commented Aug 23, 2025

Uh oh!

bors commented Aug 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

jhpratt commented Aug 22, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Aug 22, 2025

Uh oh!

bors commented Aug 22, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Aug 22, 2025

Uh oh!

bors commented Aug 23, 2025

Uh oh!

rust-log-analyzer commented Aug 23, 2025

Uh oh!

bors commented Aug 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

jhpratt commented Aug 22, 2025 •

edited by rustbot

Loading