Skip to content

Improve dist for gnullvm hosts#145790

Merged
bors merged 2 commits intorust-lang:masterfrom
mati865:gnullvm-improve-dist
Aug 27, 2025
Merged

Improve dist for gnullvm hosts#145790
bors merged 2 commits intorust-lang:masterfrom
mati865:gnullvm-improve-dist

Conversation

@mati865
Copy link
Member

@mati865 mati865 commented Aug 23, 2025 •
edited by rustbot
Loading

LLVM tools cross-compilation has been fixed by #145763 and LLVM downloading from CI no longer causes build error, so let's enable them both.

mati865 added 2 commits August 23, 2025 16:46
@mati865
Enable LLVM tools for gnullvm dist
825bb13 
This issue has been fixed by
<rust-lang#145763>.
@mati865
Enable LLVM download from CI for gnullvm dist
577e181 
It no longer fails with an error locally.
@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 23, 2025
@mati865
Copy link
Member Author

mati865 commented Aug 23, 2025

@bors try jobs=dist-aarch64-windows-gnullvm,dist-x86_64-windows-gnullvm

rust-bors bot added a commit that referenced this pull request Aug 23, 2025
@rust-bors
Auto merge of #145790 - mati865:gnullvm-improve-dist, r=<try>
20f1634 
Improve dist for gnullvm hosts

try-job: dist-aarch64-windows-gnullvm
try-job: dist-x86_64-windows-gnullvm
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Contributor

rust-bors bot commented Aug 23, 2025

☀️ Try build successful (CI)
Build commit: 20f1634 (20f1634aff897ea6a1eff47085b35bd415b14154, parent: 5b6ceb58f800079f8c59f5194b5db08924693927)

@Kobzol
Copy link
Member

Kobzol commented Aug 24, 2025

r? @Kobzol

@mati865
Copy link
Member Author

mati865 commented Aug 26, 2025

Files look fine:

$ comm -3 \
   <(fd . -t f --relative-path --base-directory ~/.rustup/toolchains/20f1634-amd64-gnullvm/ | sort) \
   <(fd . -t f --relative-path --base-directory ~/.rustup/toolchains/5b6ceb5-amd64-gnullvm/ | sort)
lib/rustlib/x86_64-pc-windows-gnullvm/bin/rust-objcopy.exe

$ fd rust-objcopy.exe /home/mateusz/.rustup
/home/mateusz/.rustup/toolchains/20f1634-amd64-gnullvm/lib/rustlib/x86_64-pc-windows-gnullvm/bin/rust-objcopy.exe

This PR compared to the parent adds one file and all files are in the good format.

I cannot speak for build times (I don't know how noisy are the times) but enabling one more binary shouldn't cause big slowdown.
LLVM was not cached, but maybe it just needs to populate the cache?

@mati865 mati865 marked this pull request as ready for review August 26, 2025 16:08
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2025
@Kobzol
Copy link
Member

Kobzol commented Aug 26, 2025

Looks fine, thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 26, 2025

📌 Commit 577e181 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2025
@samueltardieu samueltardieu mentioned this pull request Aug 26, 2025
Merged
bors added a commit that referenced this pull request Aug 26, 2025
@bors
Auto merge of #145906 - samueltardieu:rollup-p8ibzhz, r=samueltardieu
176d8db 
Rollup of 9 pull requests

Successful merges:

 - #144499 (ci: Begin running ui tests with `rust.debuginfo-level-tests=1`)
 - #145790 (Improve dist for gnullvm hosts)
 - #145792 (Use attribute name in message for "outer attr used as inner attr" errors)
 - #145840 (rustc_codegen_ssa: More comprehensive RISC-V ELF flags)
 - #145876 (Enable building/disting standard library in stage 0)
 - #145887 (bootstrap: Don't panic if codegen-backends is set to empty)
 - #145888 (platform-support: Fix LoongArch32 host column)
 - #145892 (add a flag to codegen fn attrs for foreign items)
 - #145901 (Fix typo in comment of library/alloc/src/raw_vec/mod.rs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 87ab2c8 into rust-lang:master Aug 27, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 27, 2025
rust-timer added a commit that referenced this pull request Aug 27, 2025
@rust-timer
Unrolled build for #145790
f2dfff0 
Rollup merge of #145790 - mati865:gnullvm-improve-dist, r=Kobzol

Improve dist for gnullvm hosts

LLVM tools cross-compilation has been fixed by #145763 and LLVM downloading from CI no longer causes build error, so let's enable them both.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Aug 27, 2025
@bors
Auto merge of #145906 - samueltardieu:rollup-p8ibzhz, r=samueltardieu
197d503 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#144499 (ci: Begin running ui tests with `rust.debuginfo-level-tests=1`)
 - rust-lang/rust#145790 (Improve dist for gnullvm hosts)
 - rust-lang/rust#145792 (Use attribute name in message for "outer attr used as inner attr" errors)
 - rust-lang/rust#145840 (rustc_codegen_ssa: More comprehensive RISC-V ELF flags)
 - rust-lang/rust#145876 (Enable building/disting standard library in stage 0)
 - rust-lang/rust#145887 (bootstrap: Don't panic if codegen-backends is set to empty)
 - rust-lang/rust#145888 (platform-support: Fix LoongArch32 host column)
 - rust-lang/rust#145892 (add a flag to codegen fn attrs for foreign items)
 - rust-lang/rust#145901 (Fix typo in comment of library/alloc/src/raw_vec/mod.rs)

r? `@ghost`
`@rustbot` modify labels: rollup
@mati865 mati865 deleted the gnullvm-improve-dist branch August 27, 2025 06:57
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
@bors
Auto merge of #145906 - samueltardieu:rollup-p8ibzhz, r=samueltardieu
dbf7301 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#144499 (ci: Begin running ui tests with `rust.debuginfo-level-tests=1`)
 - rust-lang/rust#145790 (Improve dist for gnullvm hosts)
 - rust-lang/rust#145792 (Use attribute name in message for "outer attr used as inner attr" errors)
 - rust-lang/rust#145840 (rustc_codegen_ssa: More comprehensive RISC-V ELF flags)
 - rust-lang/rust#145876 (Enable building/disting standard library in stage 0)
 - rust-lang/rust#145887 (bootstrap: Don't panic if codegen-backends is set to empty)
 - rust-lang/rust#145888 (platform-support: Fix LoongArch32 host column)
 - rust-lang/rust#145892 (add a flag to codegen fn attrs for foreign items)
 - rust-lang/rust#145901 (Fix typo in comment of library/alloc/src/raw_vec/mod.rs)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kobzol Kobzol

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mati865 @Kobzol @bors @rustbot