Skip to content

Enable building/disting standard library in stage 0#145876

Merged
bors merged 1 commit intorust-lang:masterfrom
Kobzol:dist-std-build
Aug 27, 2025
Merged

Enable building/disting standard library in stage 0#145876
bors merged 1 commit intorust-lang:masterfrom
Kobzol:dist-std-build

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Aug 26, 2025 •
edited
Loading

After the stage0 redesign, building a stage0 library no longer is a thing, because the stage0 compiler normally cannot build libstd anymore. However, there are valid use-cases for having the ability to quickly cross-compile libstd for different targets, when the stage0 compiler is e.g. a stable released version, and you want to cross-compile libstd from the same sources of that compiler.

This PR allows that, as long as you set build.local-rebuild = true, which promises bootstrap that the stage0 compiler actually comes from in-tree sources, and can thus compile libstd.

The change needed to enable this is very minimal, so I think that it is worth it to allow this use-case to work.

Fixes: #145587
Fixes: #145859
Related issue: #94781

r? @jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2025

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@Kobzol Kobzol mentioned this pull request Aug 26, 2025
Closed
@jieyouxu
Copy link
Member

jieyouxu commented Aug 26, 2025 •
edited
Loading

This unfortunately has a merge conflict. I'll review this tmrw.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2025
jieyouxu
jieyouxu approved these changes Aug 26, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually just kidding, the changes look good to me. Please r=me after fixing the change tracker conflict.

View changes since this review

@jieyouxu
Copy link
Member

jieyouxu commented Aug 26, 2025

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2025
@bors
Copy link
Collaborator

bors commented Aug 26, 2025

☔ The latest upstream changes (presumably #145871) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Kobzol
Copy link
Member Author

Kobzol commented Aug 26, 2025

@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented Aug 26, 2025

📌 Commit 5cf9c13 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2025
@samueltardieu samueltardieu mentioned this pull request Aug 26, 2025
Merged
bors added a commit that referenced this pull request Aug 26, 2025
@bors
Auto merge of #145906 - samueltardieu:rollup-p8ibzhz, r=samueltardieu
176d8db 
Rollup of 9 pull requests

Successful merges:

 - #144499 (ci: Begin running ui tests with `rust.debuginfo-level-tests=1`)
 - #145790 (Improve dist for gnullvm hosts)
 - #145792 (Use attribute name in message for "outer attr used as inner attr" errors)
 - #145840 (rustc_codegen_ssa: More comprehensive RISC-V ELF flags)
 - #145876 (Enable building/disting standard library in stage 0)
 - #145887 (bootstrap: Don't panic if codegen-backends is set to empty)
 - #145888 (platform-support: Fix LoongArch32 host column)
 - #145892 (add a flag to codegen fn attrs for foreign items)
 - #145901 (Fix typo in comment of library/alloc/src/raw_vec/mod.rs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5ba3bfc into rust-lang:master Aug 27, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 27, 2025
rust-timer added a commit that referenced this pull request Aug 27, 2025
@rust-timer
Unrolled build for #145876
6114bef 
Rollup merge of #145876 - Kobzol:dist-std-build, r=jieyouxu

Enable building/disting standard library in stage 0

After the stage0 redesign, building a stage0 library no longer is a thing, because the stage0 compiler normally cannot build libstd anymore. However, there are valid use-cases for having the ability to quickly cross-compile libstd for different targets, when the stage0 compiler is e.g. a stable released version, and you want to cross-compile libstd from the same sources of that compiler.

This PR allows that, as long as you set `build.local-rebuild = true`, which promises bootstrap that the stage0 compiler actually comes from in-tree sources, and can thus compile libstd.

The change needed to enable this is very minimal, so I think that it is worth it to allow this use-case to work.

Fixes: #145587
Fixes: #145859
Related issue: #94781

r? `@jieyouxu`
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Aug 27, 2025
@bors
Auto merge of #145906 - samueltardieu:rollup-p8ibzhz, r=samueltardieu
197d503 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#144499 (ci: Begin running ui tests with `rust.debuginfo-level-tests=1`)
 - rust-lang/rust#145790 (Improve dist for gnullvm hosts)
 - rust-lang/rust#145792 (Use attribute name in message for "outer attr used as inner attr" errors)
 - rust-lang/rust#145840 (rustc_codegen_ssa: More comprehensive RISC-V ELF flags)
 - rust-lang/rust#145876 (Enable building/disting standard library in stage 0)
 - rust-lang/rust#145887 (bootstrap: Don't panic if codegen-backends is set to empty)
 - rust-lang/rust#145888 (platform-support: Fix LoongArch32 host column)
 - rust-lang/rust#145892 (add a flag to codegen fn attrs for foreign items)
 - rust-lang/rust#145901 (Fix typo in comment of library/alloc/src/raw_vec/mod.rs)

r? `@ghost`
`@rustbot` modify labels: rollup
@Kobzol Kobzol deleted the dist-std-build branch August 27, 2025 05:15
@OctopusET OctopusET mentioned this pull request Sep 12, 2025
Closed
OctopusET added a commit to OctopusET/rust that referenced this pull request Sep 12, 2025
@OctopusET
Enable building/disting standard library in stage 0
b1b6c0a 
Reference: rust-lang#145876
Disabled from here: rust-lang@52882f6
@OctopusET OctopusET mentioned this pull request Sep 12, 2025
Closed
4 tasks
@OctopusET
Copy link

OctopusET commented Sep 12, 2025

I made a patch for 1.89.0
OctopusET@b1b6c0a

@OctopusET
Copy link

OctopusET commented Sep 12, 2025

Will this be included in 1.90.0 too?

@Kobzol
Copy link
Member Author

Kobzol commented Sep 12, 2025

No, it will be in 1.91.0.

OctopusET added a commit to OctopusET/gentoo that referenced this pull request Sep 12, 2025
@OctopusET
sys-devel/rust-std: Enable stage 0 build for 1.89.0
f08763a 
Rust changed bootstrap design since version 1.89.0, and it doesn't build stage0 stdlib anymore:
https://blog.rust-lang.org/inside-rust/2025/05/29/redesigning-the-initial-bootstrap-sequence/

This upstream PR will fix the issue:
rust-lang/rust#145876

Closes: https://bugs.gentoo.org/962786
Signed-off-by: Sungjoon Moon <sumoon@seoulsaram.org>
OctopusET added a commit to OctopusET/gentoo that referenced this pull request Sep 12, 2025
@OctopusET
sys-devel/rust-std: Enable stage 0 build for 1.89.0
02b4969 
Rust changed bootstrap design since version 1.89.0, and it doesn't build stage0 stdlib anymore:
https://blog.rust-lang.org/inside-rust/2025/05/29/redesigning-the-initial-bootstrap-sequence/

This upstream PR will fix the issue from 1.91.0:
rust-lang/rust#145876

Closes: https://bugs.gentoo.org/962786
Signed-off-by: Sungjoon Moon <sumoon@seoulsaram.org>
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Sep 14, 2025
@OctopusET @thesamesam
sys-devel/rust-std: Enable stage 0 build for 1.89.0
c906cb2 
Rust changed bootstrap design since version 1.89.0, and it doesn't build stage0 stdlib anymore:
https://blog.rust-lang.org/inside-rust/2025/05/29/redesigning-the-initial-bootstrap-sequence/

This upstream PR will fix the issue from 1.91.0:
rust-lang/rust#145876

Closes: https://bugs.gentoo.org/962786
Signed-off-by: Sungjoon Moon <sumoon@seoulsaram.org>
Part-of: #43765
Closes: #43765
Signed-off-by: Sam James <sam@gentoo.org>
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
@bors
Auto merge of #145906 - samueltardieu:rollup-p8ibzhz, r=samueltardieu
dbf7301 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#144499 (ci: Begin running ui tests with `rust.debuginfo-level-tests=1`)
 - rust-lang/rust#145790 (Improve dist for gnullvm hosts)
 - rust-lang/rust#145792 (Use attribute name in message for "outer attr used as inner attr" errors)
 - rust-lang/rust#145840 (rustc_codegen_ssa: More comprehensive RISC-V ELF flags)
 - rust-lang/rust#145876 (Enable building/disting standard library in stage 0)
 - rust-lang/rust#145887 (bootstrap: Don't panic if codegen-backends is set to empty)
 - rust-lang/rust#145888 (platform-support: Fix LoongArch32 host column)
 - rust-lang/rust#145892 (add a flag to codegen fn attrs for foreign items)
 - rust-lang/rust#145901 (Fix typo in comment of library/alloc/src/raw_vec/mod.rs)

r? `@ghost`
`@rustbot` modify labels: rollup
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Feb 2, 2026
@lu-zero
sys-devel/rust-std: Update to the current build system
7b6b241 
See rust-lang/rust#145876

Closes: https://bugs.gentoo.org/966384

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

Build stage 0 rust-std from rust-src with local rust Unable to build cross target's libstd on Rust 1.89

6 participants

@Kobzol @rustbot @jieyouxu @bors @rust-log-analyzer @OctopusET