Add bootstrap.toml option to control debug breaking on ICEs on windows#145976
Add bootstrap.toml option to control debug breaking on ICEs on windows#145976bors merged 1 commit intorust-lang:masterfrom
Conversation
|
r? @clubby789 rustbot has assigned @clubby789. Use |
|
This PR modifies If appropriate, please update This PR modifies If appropriate, please update |
rustbot
added
S-waiting-on-review
beepster4096
force-pushed
the
configure_debugbreak
branch
from
e67380d to
507f6d2
Compare
|
LGTM - r=me if you wouldn't mind squashing |
|
☔ The latest upstream changes (presumably #145663) made this pull request unmergeable. Please resolve the merge conflicts. |
beepster4096
force-pushed
the
configure_debugbreak
branch
from
f9d6708 to
768dcbe
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Done! Sorry about the delay. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Rollup of 4 pull requests Successful merges: - #145976 (Add bootstrap.toml option to control debug breaking on ICEs on windows) - #146151 (fixes auto-run js checks in tidy) - #146194 (fix path str eq) - #146197 (triagebot: fix rustc_allow_const_fn_unstable matcher) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #145976 - beepster4096:configure_debugbreak, r=clubby789 Add bootstrap.toml option to control debug breaking on ICEs on windows When rustc ICEs during bootstrap on Windows, it will call `DebugBreak`. This is intended to trigger a Windows Error Reporting dialog that can launch a debugger. However on some setups (mine for one) this will just abort the process, hiding any ICEs on other threads as well. I also would not want to see this dialog even if it did work for me. This PR adds a new option to bootstrap.toml `rust.break-on-ice` to configure this behavior. By default, it is enabled, matching the existing behavior.
4 participants
When rustc ICEs during bootstrap on Windows, it will call
DebugBreak. This is intended to trigger a Windows Error Reporting dialog that can launch a debugger. However on some setups (mine for one) this will just abort the process, hiding any ICEs on other threads as well. I also would not want to see this dialog even if it did work for me.This PR adds a new option to bootstrap.toml
rust.break-on-iceto configure this behavior. By default, it is enabled, matching the existing behavior.