Fix message style for "crate-level attr used as outer attr" and "invalid custom_mir" errors#146080
Closed
scrabsha wants to merge 6 commits intorust-lang:masterfrom
Closed
Fix message style for "crate-level attr used as outer attr" and "invalid custom_mir" errors#146080scrabsha wants to merge 6 commits intorust-lang:masterfrom
scrabsha wants to merge 6 commits intorust-lang:masterfrom
Conversation
rustbot
added
A-attributes
Contributor
|
@rustbot blocked |
rustbot
added
S-blocked
scrabsha
force-pushed
the
push-lqzlpzowwlrx
branch
from
ad2b60d to
3d9f166
Compare
scrabsha
changed the title
Contributor
Author
|
i reviewed my recent PRs and figured i did the same mistake for |
Contributor
Author
|
just checked the rest of the codebase - there are several other error messages that start with a capitalized letter - i'll find them all and will open a pr over master rather rather than jana's branch. |
scrabsha
added a commit
to scrabsha/rust
that referenced
this pull request
Sep 2, 2025
a more general version of rust-lang#146080. after a bit of hacking in [`fluent.rs`](https://github.com/rust-lang/rust/blob/master/compiler/rustc_fluent_macro/src/fluent.rs), i discovered that i'm not the only one that is bad at following guidelines 😅. this pr lowercases the first letter of all the error messages in the codebase. (i did not change things that are traditionally uppercased such as _MIR_, _ABI_ or _C_) i think it's reasonable to run a `@bors try` so all the test suite is checked, as i cannot run some of the tests on my machine. i double checked (and replaced manually) all the old error messages, but better be safe than sorry. in the future i will try to add a check in `x test tidy` that errors if an error message starts with an uppercase letter.
scrabsha
added a commit
to scrabsha/rust
that referenced
this pull request
Sep 3, 2025
a more general version of rust-lang#146080. after a bit of hacking in [`fluent.rs`](https://github.com/rust-lang/rust/blob/master/compiler/rustc_fluent_macro/src/fluent.rs), i discovered that i'm not the only one that is bad at following guidelines 😅. this pr lowercases the first letter of all the error messages in the codebase. (i did not change things that are traditionally uppercased such as _MIR_, _ABI_ or _C_) i think it's reasonable to run a `@bors try` so all the test suite is checked, as i cannot run some of the tests on my machine. i double checked (and replaced manually) all the old error messages, but better be safe than sorry. in the future i will try to add a check in `x test tidy` that errors if an error message starts with an uppercase letter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mistakenly introduced by me in #145792 and #145206, reported in #145819 (comment).
On top of #145819 (comment).