Revert introduction of [workspace.dependencies].#146113
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 2, 2025
Merged
Revert introduction of [workspace.dependencies].#146113bors merged 1 commit intorust-lang:masterfrom
[workspace.dependencies].#146113bors merged 1 commit intorust-lang:masterfrom
Conversation
This was done in rust-lang#145740 and rust-lang#145947. It is causing problems for people using r-a on anything that uses the rustc-dev rustup package, e.g. Miri, clippy. This repository has lots of submodules and subtrees and various different projects are carved out of pieces of it. It seems like `[workspace.dependencies]` will just be more trouble than it's worth.
Collaborator
|
|
rustbot
added
A-attributes
Member
|
Thanks! @bors r+ p=1 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 05abce5 (parent) -> f6df223 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard f6df223ea8c0017e64ce19c99afa32c0c629142c --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (f6df223): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 467.236s -> 467.107s (-0.03%) |
makai410
pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
…ies, r=Kobzol Revert introduction of `[workspace.dependencies]`. This was done in rust-lang#145740 and rust-lang#145947. It is causing problems for people using r-a on anything that uses the rustc-dev rustup package, e.g. Miri, clippy. This repository has lots of submodules and subtrees and various different projects are carved out of pieces of it. It seems like `[workspace.dependencies]` will just be more trouble than it's worth. r? `@Kobzol`
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 31, 2026
Re-export `hashbrown::hash_table` from `rustc_data_structures` We don't always re-export shared dependencies, but for `hashbrown::hash_table` I think it makes sense, for a few reasons: - The lower-level `HashTable` type is already part of the public API of `rustc_data_structures` via the `ShardedHashMap` type alias, and other compiler crates currently depend on being able to access its internal hash tables. - The `Cargo.toml` entry for `hashbrown` is non-trivial, making it harder to keep in sync and harder to move between crates as needed. - [And we currently aren't using `[workspace.dependencies]` for various reasons.](rust-lang#146113) - It's fine for other compiler crates to use `hash_table` specifically (with care), but they probably shouldn't be using the higher-level `hashbrown::HashMap` and `hashbrown::HashSet` types directly, because they should prefer the various map/set aliases defined by `rustc_data_structures`. Re-exporting only `hash_table` helps to discourage use of those other types. There should be no change to compiler behaviour.
rust-timer
added a commit
that referenced
this pull request
Feb 1, 2026
Rollup merge of #151890 - Zalathar:hash-table, r=Kivooeo Re-export `hashbrown::hash_table` from `rustc_data_structures` We don't always re-export shared dependencies, but for `hashbrown::hash_table` I think it makes sense, for a few reasons: - The lower-level `HashTable` type is already part of the public API of `rustc_data_structures` via the `ShardedHashMap` type alias, and other compiler crates currently depend on being able to access its internal hash tables. - The `Cargo.toml` entry for `hashbrown` is non-trivial, making it harder to keep in sync and harder to move between crates as needed. - [And we currently aren't using `[workspace.dependencies]` for various reasons.](#146113) - It's fine for other compiler crates to use `hash_table` specifically (with care), but they probably shouldn't be using the higher-level `hashbrown::HashMap` and `hashbrown::HashSet` types directly, because they should prefer the various map/set aliases defined by `rustc_data_structures`. Re-exporting only `hash_table` helps to discourage use of those other types. There should be no change to compiler behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done in #145740 and #145947. It is causing problems for people using r-a on anything that uses the rustc-dev rustup package, e.g. Miri, clippy.
This repository has lots of submodules and subtrees and various different projects are carved out of pieces of it. It seems like
[workspace.dependencies]will just be more trouble than it's worth.r? @Kobzol