compiler: Apply target features to the entry function by heiher · Pull Request #146144 · rust-lang/rust

heiher · 2025-09-03T04:04:56Z

rustbot · 2025-09-03T04:05:01Z

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-09-03T04:05:04Z

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

compiler/rustc_codegen_ssa/src/traits/misc.rs

compiler/rustc_codegen_llvm/src/context.rs

compiler/rustc_codegen_ssa/src/base.rs

Link: rust-lang/rust#146144 Signed-off-by: Ilikara <3435193369@qq.com>

rustbot · 2025-09-04T07:06:34Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

compiler/rustc_codegen_llvm/src/context.rs

petrochenkov · 2025-09-04T13:29:40Z

r=me with the nit #146144 (comment) addressed.
@rustbot author

rustbot · 2025-09-04T13:29:44Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

AirFortressIlikara · 2025-09-04T14:52:51Z

We compile oma with flags below to avoid lsx:

[DEBUG]: LDFLAGS=-Wl,-O1,--sort-common,--as-needed -Wl,-build-id=sha1 -Wl,-z,relro -Wl,-z,now -fPIC -fPIE -flto -fuse-linker-plugin
[DEBUG]: CFLAGS=-pipe -Wno-error -fstack-protector-strong --param=ssp-buffer-size=4 -fexceptions -fPIC -fPIC -ggdb -O2 -fno-omit-frame-pointer -flto -mabi=lp64d -mstrict-align -march=loongarch64 -mtune=loongarch64 -msimd=none
[DEBUG]: CPPFLAGS=-D_GLIBCXX_ASSERTIONS -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3
[DEBUG]: CXXFLAGS=-ggdb -fpermissive -pipe -Wno-error -fstack-protector-strong --param=ssp-buffer-size=4 -fexceptions -fPIC -fPIC -ggdb -O2 -fno-omit-frame-pointer -flto -mabi=lp64d -mstrict-align -march=loongarch64 -mtune=loongarch64 -msimd=none
[DEBUG]: OBJCFLAGS=-pipe -Wno-error -fstack-protector-strong --param=ssp-buffer-size=4 -fexceptions -fPIC -fPIC -ggdb -O2 -fno-omit-frame-pointer -flto -mabi=lp64d -mstrict-align -march=loongarch64 -mtune=loongarch64 -msimd=none
[DEBUG]: OBJCXXFLAGS=-fpermissive -ggdb -fpermissive -pipe -Wno-error -fstack-protector-strong --param=ssp-buffer-size=4 -fexceptions -fPIC -fPIC -ggdb -O2 -fno-omit-frame-pointer -flto -mabi=lp64d -mstrict-align -march=loongarch64 -mtune=loongarch64 -msimd=none
[DEBUG]: RUSTFLAGS=-Ccodegen-units=1 -Copt-level=3 -Cdebuginfo=line-tables-only -Cforce-frame-pointers=yes -Cembed-bitcode=yes -Clinker-plugin-lto -Clinker=clang -Clink-arg=-flto -Clink-arg=-fuse-ld=lld -Clink-arg=-Wl,-build-id=sha1 -Clink-arg=-Wl,--lto-O3 -Ctarget-cpu=generic-la64 -Ctarget-feature=-lsx,+d -Clink-arg=-mabi=lp64

When using rustc 1.89.0, lsx exists

Recompile rustc 1.89.0 with this patch (f028b9b) , lsx no longer exists

This patch works as we expected

Link: rust-lang/rust#146144 Signed-off-by: Ilikara <3435193369@qq.com>

petrochenkov · 2025-09-05T12:14:49Z

@bors r+

bors · 2025-09-05T12:14:52Z

📌 Commit 923b892 has been approved by petrochenkov

It is now in the queue for this repository.

Rollup of 11 pull requests Successful merges: - #138944 (Add `__isPlatformVersionAtLeast` and `__isOSVersionAtLeast` symbols) - #139113 (unstable book: in a sanitizer example, check the code) - #145735 (style-guide: Document absence of trailing whitespace) - #146041 (tidy: --bless now makes escheck run with --fix) - #146144 (compiler: Apply target features to the entry function) - #146225 (Simplify `{f16, f32, f64, f128}::midpoint()`) - #146234 (change file-is-generated doc comment to inner) - #146241 (rustc_infer: change top-level doc comment to inner) - #146242 (Ensure that `--html-after-content` option is used to check `scrape_examples_ice` rustdoc GUI test) - #146243 (remove couple of redundant clones) - #146250 (Bump stage0 rustfmt) Failed merges: - #146200 (Simplify rustdoc-gui tester by calling directly browser-ui-test) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-09-05T23:59:31Z

⌛ Testing commit 923b892 with merge 6c699a3...

Rollup merge of #146144 - heiher:entry-func-features, r=petrochenkov compiler: Apply target features to the entry function Fixes #146143

Link: rust-lang/rust#146144 Signed-off-by: Ilikara <3435193369@qq.com>

rustbot assigned petrochenkov Sep 3, 2025

This comment has been minimized.

Sign in to view

heiher force-pushed the entry-func-features branch from 04f812b to f964331 Compare September 3, 2025 04:06

WaffleLapkin reviewed Sep 3, 2025

View reviewed changes

compiler/rustc_codegen_ssa/src/traits/misc.rs Outdated Show resolved Hide resolved

petrochenkov reviewed Sep 3, 2025

View reviewed changes

compiler/rustc_codegen_llvm/src/context.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2025

heiher force-pushed the entry-func-features branch from f964331 to beb0304 Compare September 3, 2025 11:44

bjorn3 reviewed Sep 3, 2025

View reviewed changes

compiler/rustc_codegen_ssa/src/base.rs Outdated Show resolved Hide resolved

AirFortressIlikara added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Sep 3, 2025

rustc: Apply target features to the entry function

dcbc9d9

Link: rust-lang/rust#146144 Signed-off-by: Ilikara <3435193369@qq.com>

heiher force-pushed the entry-func-features branch from beb0304 to 7f26036 Compare September 3, 2025 14:12

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2025

AirFortressIlikara mentioned this pull request Sep 3, 2025

rustc: fix loongarch64-nosimd lto AOSC-Dev/aosc-os-abbs#12376

Merged

7 tasks

MingcongBai mentioned this pull request Sep 4, 2025

arch: loongarch64_nosimd: Pass -mattr=-lsx to the linker plugin for Rust AOSC-Dev/autobuild4#66

Closed

This comment was marked as resolved.

Sign in to view

heiher force-pushed the entry-func-features branch from 7f26036 to f028b9b Compare September 4, 2025 07:06

petrochenkov reviewed Sep 4, 2025

View reviewed changes

compiler/rustc_codegen_llvm/src/context.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2025

compiler: Apply target features to the entry function

923b892

heiher force-pushed the entry-func-features branch from f028b9b to 923b892 Compare September 4, 2025 13:57

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 4, 2025

AirFortressIlikara added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Sep 5, 2025

rustc: Apply target features to the entry function

9f26263

Link: rust-lang/rust#146144 Signed-off-by: Ilikara <3435193369@qq.com>

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2025

fmease mentioned this pull request Sep 5, 2025

Rollup of 11 pull requests #146255

Merged

bors merged commit 1c2d264 into rust-lang:master Sep 5, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Sep 5, 2025

rust-timer added a commit that referenced this pull request Sep 6, 2025

Unrolled build for #146144

2732afb

Rollup merge of #146144 - heiher:entry-func-features, r=petrochenkov compiler: Apply target features to the entry function Fixes #146143

heiher deleted the entry-func-features branch September 6, 2025 01:25

stydxm pushed a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Sep 7, 2025

rustc: Apply target features to the entry function

190daab

Link: rust-lang/rust#146144 Signed-off-by: Ilikara <3435193369@qq.com>

stydxm pushed a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Sep 10, 2025

rustc: Apply target features to the entry function

3cd30e6

Link: rust-lang/rust#146144 Signed-off-by: Ilikara <3435193369@qq.com>

Uh oh!

Conversation

heiher commented Sep 3, 2025

Uh oh!

rustbot commented Sep 3, 2025

Uh oh!

rustbot commented Sep 3, 2025

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

rustbot commented Sep 4, 2025

Uh oh!

Uh oh!

petrochenkov commented Sep 4, 2025

Uh oh!

rustbot commented Sep 4, 2025

Uh oh!

AirFortressIlikara commented Sep 4, 2025

Uh oh!

petrochenkov commented Sep 5, 2025

Uh oh!

bors commented Sep 5, 2025

Uh oh!

Uh oh!

bors commented Sep 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants