tidy: check that error messages don't start with a capitalized letter#146171
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 14, 2025
Merged
tidy: check that error messages don't start with a capitalized letter#146171bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
|
rustbot
added
A-tidy
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-wovnxxwltsun
branch
2 times, most recently
from
0b8a1dd to
4d08e6e
Compare
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred in compiler/rustc_codegen_ssa |
Contributor
Author
|
@rustbot ready |
emilyalbini
removed
the
S-blocked
WaffleLapkin
requested changes
Sep 7, 2025
Comment on lines
+61
to
+62
| &mut |ent, contents| { | ||
| check_lowercase(ent.path().to_str().unwrap(), contents, bad); | ||
| }, |
Member
There was a problem hiding this comment.
q: doesn't this get called for dirs? if so, you should probably add a check for them here.
Contributor
Author
There was a problem hiding this comment.
it is not called on dirs because we filter out dirs right before that:
|path, is_dir| filter_dirs(path) || (!is_dir && filter_fluent(path)),
Member
There was a problem hiding this comment.
that's not what filter_dirs does though? (otherwise you'd just have !is_dir &&) (filter_dirs seems to just ignore common dirs you want to ignore)
Contributor
Author
There was a problem hiding this comment.
that's not what filter_dirs does though?
You're right! My comment was terribly badly worded, sorry :(. (I shouldn't have used words "filter out")
This is not called on dirs due to the !is_dir part of the lign I quoted, not because of the filter_dirs bit
But now that you ask, I have to admit there's something fishy with the && and || in the condition (honestly, I copied this from the other fluent-related checks). I'll try to write down the truth table for this tomorrow.
rustbot
added
S-waiting-on-author
scrabsha
force-pushed
the
push-wovnxxwltsun
branch
from
4d08e6e to
b152974
Compare
rustbot
added
S-waiting-on-review
WaffleLapkin
approved these changes
Sep 13, 2025
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 13, 2025
Rollup of 8 pull requests Successful merges: - #113095 (Document `become` keyword) - #146159 (Some hygiene doc improvements) - #146171 (tidy: check that error messages don't start with a capitalized letter) - #146419 (Update the arm-* and aarch64-* platform docs.) - #146473 (Revert "Constify SystemTime methods") - #146506 (Fix small typo in check-cfg.md) - #146517 (fix Condvar::wait_timeout docs) - #146521 (document `core::ffi::VaArgSafe`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 14, 2025
Rollup merge of #146171 - scrabsha:push-wovnxxwltsun, r=WaffleLapkin tidy: check that error messages don't start with a capitalized letter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next step after #146112. The implementation of this is better than the hacks I wrote earlier, which allowed me to discover more capitalized error messages.
@rustbot blocked
r? @WaffleLapkin