rustdoc_json: Add a test for the size of important types.#146315
Closed
nnethercote wants to merge 1 commit intorust-lang:masterfrom
Closed
rustdoc_json: Add a test for the size of important types.#146315nnethercote wants to merge 1 commit intorust-lang:masterfrom
nnethercote wants to merge 1 commit intorust-lang:masterfrom
Conversation
We have size checks like these for many different parts of the compiler: AST, HIR, MIR, etc. Those ones all use `static_assert_size!` from `rustc_index`, but because rustdoc-json-types is distributed as its own crate it can't depend on `rustc_index`. So I've just put the checks in a unit test. Note that `Item` is currently very large! Making the sizes of these things explicit and tested is the first step towards making them smaller.
Collaborator
|
|
rustbot
added
A-rustdoc-json
Collaborator
|
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing |
obi1kenobi
approved these changes
Sep 7, 2025
Contributor
Author
|
Wait, sorry, I already did this a better way (static assertions) in #142502. |
rustbot
removed
the
S-waiting-on-review
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have size checks like these for many different parts of the compiler: AST, HIR, MIR, etc. Those ones all use
static_assert_size!fromrustc_index, but because rustdoc-json-types is distributed as its own crate it can't depend onrustc_index. So I've just put the checks in a unit test.Note that
Itemis currently very large! Making the sizes of these things explicit and tested is the first step towards making them smaller.r? @aDotInTheVoid