mir-opt: Remove the workaround in UnreachableEnumBranching#146544
mir-opt: Remove the workaround in UnreachableEnumBranching#146544dianqk wants to merge 2 commits intorust-lang:mainfrom
Conversation
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
rustbot has assigned @petrochenkov. Use |
|
cc @nikic because of #120268 (comment) |
|
I believe you meant to pingback LLVM issues, not Rust issues? |
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mir-opt: Remove the workaround in UnreachableEnumBranching
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (c2e723d): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary 3.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 474.182s -> 473.61s (-0.12%) |
I linked back to the PR that introduced the workaround. |
|
r? @nikic |
|
r? wesleywiser |
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
#120268 added a workaround due to the compile time of TailDuplicator.
LLVM 20 has resolved this in llvm/llvm-project#114990 and llvm/llvm-project#132536.