[crater experiment] avx512: remove rustc_legacy_const_generics#146578
Closed
RalfJung wants to merge 1 commit intorust-lang:masterfrom
Closed
[crater experiment] avx512: remove rustc_legacy_const_generics#146578RalfJung wants to merge 1 commit intorust-lang:masterfrom
RalfJung wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-author
Member
Author
|
@bors try |
rust-bors bot
added a commit
that referenced
this pull request
Sep 15, 2025
[crater experiment] avx512: remove rustc_legacy_const_generics
This comment has been minimized.
This comment has been minimized.
Contributor
Member
Author
|
Turns out there wasn't actually a team decision to deprecate this so I guess there's little point in cratering. |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were stabilized very recently, maybe there's still a chance to not use the legacy const generic style here?
Though... is crater even going to be useful here? I assume the crater machines do not have AVX512 so depending on how the intrinsics are used, that code might be disabled anyway. @Amanieu
Context: rust-lang/stdarch#1916