remove unnecessary structurally_resolve_type

[lcnr]

the types returned by Autoderef are always structurally resolved, cc #145990.

r? @BoxyUwU

[lcnr]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 7b0b20b (7b0b20b50949e22139fbb41bcaa65e97622d2e76, parent: eec6bd9d69832f57341c6de6a93fa7b9f47e2111)

[rust-timer]

Finished benchmarking commit (7b0b20b): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.1%]	8
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.8%, secondary -1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.9%	[4.9%, 4.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-8.4%	[-8.4%, -8.4%]	1
Improvements ✅ (secondary)	-1.2%	[-1.2%, -1.2%]	1
All ❌✅ (primary)	-1.8%	[-8.4%, 4.9%]	2

Cycles

Results (secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.048s -> 473.468s (0.09%)
Artifact size: 390.57 MiB -> 390.59 MiB (0.01%)

[lcnr]

this means we no longer eagerly error on infer vars here. surprised we don't have a test for it. needs test + check for infer

[lcnr]

i think

fn foo() {
    let x = &Default::default();
    x[1];
    let _: &Vec<()> = x;
}

would work

[bors]

☔ The latest upstream changes (presumably #146885) made this pull request unmergeable. Please resolve the merge conflicts.

[lcnr]

adding the test in #147180