Rollup of 5 pull requests by Zalathar · Pull Request #146698 · rust-lang/rust

Zalathar · 2025-09-18T01:48:53Z

Successful merges:

Lint more overlapping assignments in MIR. #146566 (Lint more overlapping assignments in MIR.)
Cleanup FnDecl::inner_full_print #146645 (Cleanup FnDecl::inner_full_print)
Clean up ty::Dynamic #146664 (Clean up ty::Dynamic)
cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 4) #146673 (cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 4))
Remove ImplSubject #146694 (Remove ImplSubject)

r? @ghost
@rustbot modify labels: rollup

Lint more overlapping assignments in MIR. In an effort to make bugs like rust-lang#146383 more easily discovered, this PR extends the "overlapping assignment" MIR lint. I had to whitelist some rvalues, as they are actually allowed to alias, like `a = a + 1`.

…full_print, r=fmease Cleanup `FnDecl::inner_full_print` `inner_full_print` was pretty hard to follow IMHO. Hopefully this cleans it up a little bit. Also, it was checking whether `self.inputs` is empty twice, and then handling an unreachable match arm: https://github.com/yotamofek/rust/blob/f836ae4e663b6e8938096b8559e094d18361be55/src/librustdoc/html/format.rs#L1368C1-L1368C33 `last_input_index` could only be `None` if the fn has no parameters, in which case the loop body would never run. r? ``@GuillaumeGomez`` if you have the capacity :) BTW, can we rename `FnDecl::inputs` to `parameters` or something? And `output` to `return_ty`?

Clean up `ty::Dynamic` 1. As a follow-up to PR rust-lang#143036, remove `DynKind` entirely. 2. Inside HIR ty lowering, consolidate modules `dyn_compatibility` and `lint` into `dyn_trait` * `dyn_compatibility` wasn't about dyn compatibility itself, it's about lowering trait object types * `lint` contained dyn-Trait-specific diagnostics+lints only

cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 4) - Part of rust-lang#134001 - Follow-up to rust-lang#146631 --- This is another batch of LLVMDIBuilder binding migrations, replacing some our own LLVMRust bindings with bindings to upstream LLVM-C APIs.

…r-errors Remove ImplSubject It only has one usage in rustdoc.

Zalathar · 2025-09-18T01:49:13Z

@bors r+ rollup=never p=5

bors · 2025-09-18T01:49:15Z

📌 Commit 06cbfd6 has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-09-18T04:25:58Z

⌛ Testing commit 06cbfd6 with merge 4793ef5...

bors · 2025-09-18T07:31:40Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 4793ef5 to master...

rust-timer · 2025-09-18T07:33:09Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#146566	Lint more overlapping assignments in MIR.	`a7976cf2b7fdbd774d8e51c8230a14b51cb6fc76` (link)
#146645	Cleanup `FnDecl::inner_full_print`	`7e99b1fefea2f4e04efbc60819a7835a2c9e6107` (link)
#146664	Clean up `ty::Dynamic`	`aaa59988e7e8235354284fee227535d3ddf4cc66` (link)
#146673	cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bi…	`9daab4c2fbf43137e45fa39ec73e8e5813b438cc` (link)
#146694	Remove ImplSubject	`cf557412b65a81b98b33a861abbb2aed058fbe20` (link)

previous master: 93117677d8

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-09-18T07:34:44Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9311767 (parent) -> 4793ef5 (this PR)

Test differences

Show 72 test diffs

72 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4793ef5cf527339f072c39d129477ad5bb678f9e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

pr-check-1: 1411.5s -> 1691.5s (19.8%)
dist-apple-various: 3512.2s -> 4181.3s (19.1%)
x86_64-gnu-llvm-20: 2844.8s -> 2518.8s (-11.5%)
dist-x86_64-apple: 8203.8s -> 7263.8s (-11.5%)
armhf-gnu: 5091.0s -> 5652.7s (11.0%)
aarch64-apple: 5602.9s -> 6111.6s (9.1%)
dist-various-1: 3999.4s -> 3644.3s (-8.9%)
aarch64-gnu-llvm-20-2: 2516.1s -> 2307.6s (-8.3%)
x86_64-gnu-llvm-20-1: 3275.1s -> 3528.4s (7.7%)
dist-sparcv9-solaris: 5020.7s -> 5408.8s (7.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-18T08:42:34Z

Finished benchmarking commit (4793ef5): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	2
Regressions ❌ (secondary)	0.2%	[0.1%, 0.2%]	16
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	2

Max RSS (memory usage)

Results (secondary 3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.6%	[4.2%, 5.0%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-1.9%, -1.9%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[1.9%, 3.1%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-4.3%, -2.1%]	4
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.663s -> 470.288s (-0.29%)
Artifact size: 387.94 MiB -> 388.07 MiB (0.03%)

Kobzol · 2025-09-23T06:26:08Z

Started a bunch of perf. runs, let's see.

Kobzol · 2025-09-23T09:54:40Z

From the perf. runs it looks like the tiny regressions are distributed amongst multiple PRs. Given that most of them are in secondary benchmarks, and those benchmarks were going a bit up and down recently, I don't think it's worth to dig deeper here.

@rustbot label: +perf-regression-triaged

Rollup of 5 pull requests Successful merges: - rust-lang#146566 (Lint more overlapping assignments in MIR.) - rust-lang#146645 (Cleanup `FnDecl::inner_full_print`) - rust-lang#146664 (Clean up `ty::Dynamic`) - rust-lang#146673 (cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 4)) - rust-lang#146694 (Remove ImplSubject) r? `@ghost` `@rustbot` modify labels: rollup

fmease and others added 14 commits September 17, 2025 04:46

Remove DynKind

26f3337

Merge modules dyn_compatibility and lint into dyn_trait

34062b1

Use LLVMDIBuilderCreateMemberType

923d1be

Use LLVMDIBuilderCreateStaticMemberType

bb21dbe

Use LLVMDIBuilderCreateQualifiedType

002771a

Use LLVMDIBuilderCreateTypedef

6b51f7c

Cleanup FnDecl::inner_full_print

1d8971c

Lint overlapping assignments in MIR.

912785d

Remove ImplSubject

9ecca51

Rollup merge of rust-lang#146694 - camsteffen:impl-subject, r=compile…

06cbfd6

…r-errors Remove ImplSubject It only has one usage in rustdoc.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 18, 2025

bors merged commit 4793ef5 into rust-lang:master Sep 18, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Sep 18, 2025

Zalathar deleted the rollup-0oxl4gx branch September 18, 2025 07:50

rustbot added the perf-regression Performance regression. label Sep 18, 2025

This was referenced Sep 18, 2025

Add field representing types #146307

Open

Allow specifying multiple bounds for same associated item, except in trait objects #146593

Merged

rustc_next_trait_solver: canonical out of EvalCtxt #146638

Merged

github-actions bot mentioned this pull request Sep 22, 2025

Toolchain upgrade to nightly-2025-10-09 flux-rs/flux#1271

Merged

This was referenced Sep 23, 2025

Lint more overlapping assignments in MIR. #146566

Merged

Clean up ty::Dynamic #146664

Merged

cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 4) #146673

Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label Sep 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests#146698

Rollup of 5 pull requests#146698
bors merged 14 commits intorust-lang:masterfrom
Zalathar:rollup-0oxl4gx

Zalathar commented Sep 18, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Sep 18, 2025

Uh oh!

bors commented Sep 18, 2025

Uh oh!

bors commented Sep 18, 2025

Uh oh!

bors commented Sep 18, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Uh oh!

rust-timer commented Sep 18, 2025

Uh oh!

Kobzol commented Sep 23, 2025

Uh oh!

Kobzol commented Sep 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

Zalathar commented Sep 18, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Sep 18, 2025

Uh oh!

bors commented Sep 18, 2025

Uh oh!

bors commented Sep 18, 2025

Uh oh!

bors commented Sep 18, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Sep 18, 2025

Overall result: ❌ regressions - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Kobzol commented Sep 23, 2025

Uh oh!

Kobzol commented Sep 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Zalathar commented Sep 18, 2025 •

edited by rustbot

Loading