test: Use SVG for terminal url test by Muscraft · Pull Request #146731 · rust-lang/rust

Muscraft · 2025-09-18T17:20:54Z

I came across the test for -Zterminal-urls and found its output a bit hard to read. So, I decided to switch it to an SVG test, as I found it easier to differentiate the link and link text.

Note: anstyle-svg needed to be upgraded to at least 0.1.8 to support links in SVGs, so I went ahead and upgraded it to the latest version (0.1.11).

rustbot · 2025-09-18T17:20:58Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2025-09-18T17:21:00Z

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jdonszelmann · 2025-09-18T18:50:17Z

looks good! @bors r+ rollup

bors · 2025-09-18T18:50:21Z

📌 Commit 6375083 has been approved by jdonszelmann

It is now in the queue for this repository.

…jdonszelmann test: Use SVG for terminal url test I came across the test for `-Zterminal-urls` and found its output a bit hard to read. So, I decided to switch it to an SVG test, as I found it easier to differentiate the link and link text. Note: `anstyle-svg` needed to be upgraded to at least `0.1.8` to support links in SVGs, so I went ahead and upgraded it to the latest version (`0.1.11`).

Rollup of 8 pull requests Successful merges: - #146229 (Automatically switch to lto-fat when flag RUSTFLAGS="- Zautodiff=Enable" is set) - #146615 (rustc_codegen_llvm: Feature Conversion Tidying) - #146638 (`rustc_next_trait_solver`: canonical out of `EvalCtxt`) - #146663 (Allow windows resource compiler to be overridden) - #146691 (std: Fix WASI implementation of `remove_dir_all`) - #146709 (stdarch subtree update) - #146731 (test: Use SVG for terminal url test) - #146738 (Fix tidy spellchecking on Windows) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2025-09-19T09:44:14Z

Failed in rollup: #146746 (comment)

@bors r-

Muscraft · 2025-09-20T04:36:48Z

@rustbot review

jdonszelmann · 2025-09-22T23:44:59Z

@bors r+

bors · 2025-09-22T23:45:02Z

📌 Commit 4f02ec2 has been approved by jdonszelmann

It is now in the queue for this repository.

…jdonszelmann test: Use SVG for terminal url test I came across the test for `-Zterminal-urls` and found its output a bit hard to read. So, I decided to switch it to an SVG test, as I found it easier to differentiate the link and link text. Note: `anstyle-svg` needed to be upgraded to at least `0.1.8` to support links in SVGs, so I went ahead and upgraded it to the latest version (`0.1.11`).

Rollup of 13 pull requests Successful merges: - #146632 (Fix uses of "adaptor") - #146731 (test: Use SVG for terminal url test) - #146775 (fixes for numerous clippy warnings) - #146784 ([win] Use find-msvc-tools instead of cc to find the linker and rc on Windows) - #146799 (Fix a dangling reference in `rustc_thread_pool`) - #146802 (mbe: Simplifications and refactoring) - #146806 (add private module override re-export test) - #146827 (Linker-plugin-based LTO: update list of good combinations (inc. beta + nightly)) - #146875 (tests/run-make/crate-loading: Rename source files for clarity) - #146896 (rustc-dev-guide subtree update) - #146898 (Update books) - #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered) - #146907 (add regression test for issue 146537) r? `@ghost` `@rustbot` modify labels: rollup

…jdonszelmann test: Use SVG for terminal url test I came across the test for `-Zterminal-urls` and found its output a bit hard to read. So, I decided to switch it to an SVG test, as I found it easier to differentiate the link and link text. Note: `anstyle-svg` needed to be upgraded to at least `0.1.8` to support links in SVGs, so I went ahead and upgraded it to the latest version (`0.1.11`).

bjorn3 · 2025-09-23T09:41:27Z

Github's svg preview doesn't give any indication about the link and I imagine neither would any non-browser svg viewer.

Rollup of 8 pull requests Successful merges: - #146632 (Fix uses of "adaptor") - #146731 (test: Use SVG for terminal url test) - #146775 (fixes for numerous clippy warnings) - #146802 (mbe: Simplifications and refactoring) - #146875 (tests/run-make/crate-loading: Rename source files for clarity) - #146896 (rustc-dev-guide subtree update) - #146898 (Update books) - #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 10 pull requests Successful merges: - #146632 (Fix uses of "adaptor") - #146731 (test: Use SVG for terminal url test) - #146775 (fixes for numerous clippy warnings) - #146784 ([win] Use find-msvc-tools instead of cc to find the linker and rc on Windows) - #146799 (Fix a dangling reference in `rustc_thread_pool`) - #146802 (mbe: Simplifications and refactoring) - #146806 (add private module override re-export test) - #146827 (Linker-plugin-based LTO: update list of good combinations (inc. beta + nightly)) - #146875 (tests/run-make/crate-loading: Rename source files for clarity) - #146877 (prevent line number from being copied in chrome) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #146731 - Muscraft:svg-test-terminal-url, r=jdonszelmann test: Use SVG for terminal url test I came across the test for `-Zterminal-urls` and found its output a bit hard to read. So, I decided to switch it to an SVG test, as I found it easier to differentiate the link and link text. Note: `anstyle-svg` needed to be upgraded to at least `0.1.8` to support links in SVGs, so I went ahead and upgraded it to the latest version (`0.1.11`).

…jdonszelmann test: Use SVG for terminal url test I came across the test for `-Zterminal-urls` and found its output a bit hard to read. So, I decided to switch it to an SVG test, as I found it easier to differentiate the link and link text. Note: `anstyle-svg` needed to be upgraded to at least `0.1.8` to support links in SVGs, so I went ahead and upgraded it to the latest version (`0.1.11`).

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#146632 (Fix uses of "adaptor") - rust-lang#146731 (test: Use SVG for terminal url test) - rust-lang#146775 (fixes for numerous clippy warnings) - rust-lang#146784 ([win] Use find-msvc-tools instead of cc to find the linker and rc on Windows) - rust-lang#146799 (Fix a dangling reference in `rustc_thread_pool`) - rust-lang#146802 (mbe: Simplifications and refactoring) - rust-lang#146806 (add private module override re-export test) - rust-lang#146827 (Linker-plugin-based LTO: update list of good combinations (inc. beta + nightly)) - rust-lang#146875 (tests/run-make/crate-loading: Rename source files for clarity) - rust-lang#146877 (prevent line number from being copied in chrome) r? `@ghost` `@rustbot` modify labels: rollup

rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2025

rustbot assigned BoxyUwU Sep 18, 2025

rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 18, 2025

Muscraft changed the title ~~Svg test terminal url~~ test: Use SVG for terminal url test Sep 18, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2025

jdonszelmann assigned jdonszelmann and unassigned BoxyUwU Sep 18, 2025

jdonszelmann mentioned this pull request Sep 18, 2025

Fix incorrect suggestion for enum variant #146672

Draft

jhpratt mentioned this pull request Sep 19, 2025

Rollup of 8 pull requests #146746

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2025

tshepang mentioned this pull request Sep 19, 2025

Automated pull from upstream master ferrocene/ferrocene#1754

Merged

Muscraft added 2 commits September 19, 2025 12:28

chore(compiletest): Use newest anstyle-svg version

82eed00

test: Use SVG for terminal url test

4f02ec2

Muscraft force-pushed the svg-test-terminal-url branch from 6375083 to 4f02ec2 Compare September 19, 2025 18:28

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 20, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2025

Zalathar mentioned this pull request Sep 23, 2025

Rollup of 13 pull requests #146916

Closed

Kobzol mentioned this pull request Sep 23, 2025

Rollup of 8 pull requests #146920

Closed

klensy mentioned this pull request Sep 23, 2025

Weekly cargo update + update allowed dependencies list #145849

Closed

matthiaskrgr mentioned this pull request Sep 23, 2025

Rollup of 10 pull requests #146938

Merged

bors merged commit ba9d057 into rust-lang:master Sep 23, 2025
10 checks passed

rustbot added this to the 1.92.0 milestone Sep 23, 2025

Muscraft deleted the svg-test-terminal-url branch September 23, 2025 23:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: Use SVG for terminal url test#146731

test: Use SVG for terminal url test#146731
bors merged 2 commits intorust-lang:masterfrom
Muscraft:svg-test-terminal-url

Muscraft commented Sep 18, 2025

Uh oh!

rustbot commented Sep 18, 2025

Uh oh!

rustbot commented Sep 18, 2025

Uh oh!

jdonszelmann commented Sep 18, 2025

Uh oh!

bors commented Sep 18, 2025

Uh oh!

Zalathar commented Sep 19, 2025

Uh oh!

Muscraft commented Sep 20, 2025

Uh oh!

jdonszelmann commented Sep 22, 2025

Uh oh!

bors commented Sep 22, 2025

Uh oh!

bjorn3 commented Sep 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

Muscraft commented Sep 18, 2025

Uh oh!

rustbot commented Sep 18, 2025

Uh oh!

rustbot commented Sep 18, 2025

Uh oh!

jdonszelmann commented Sep 18, 2025

Uh oh!

bors commented Sep 18, 2025

Uh oh!

Zalathar commented Sep 19, 2025

Uh oh!

Muscraft commented Sep 20, 2025

Uh oh!

jdonszelmann commented Sep 22, 2025

Uh oh!

bors commented Sep 22, 2025

Uh oh!

bjorn3 commented Sep 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants