Rollup of 6 pull requests

[matthiaskrgr]

Successful merges:

• constify {float}::total_cmp() #146818 (constify {float}::total_cmp())
• rustc-dev-guide subtree update #146896 (rustc-dev-guide subtree update)
• Update books #146898 (Update books)
• Fix a crash/mislex when more than one frontmatter closing possibility is considered #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
• #140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn #146904 (Tracking Issue for {Mutex, RwLock, ReentrantLock}::data_ptr #140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn)
• add regression test for issue 146537 #146907 (add regression test for issue 146537)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=5

[bors]

📌 Commit 6617536 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 6617536 with merge 2b403c4...

[bors]

💔 Test failed - checks-actions

[matthiaskrgr]

@bors retry

[bors]

⌛ Testing commit 6617536 with merge 4b9e564...

[rust-log-analyzer]

The job dist-various-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
error: failed to get `rustversion` as a dependency of package `term v0.7.0`
    ... which satisfies dependency `term = "^0.7"` (locked to 0.7.0) of package `rustfmt-nightly v1.8.0 (/checkout/src/tools/rustfmt)`

Caused by:
  download of ru/st/rustversion failed

Caused by:
  failed to download from `https://index.crates.io/ru/st/rustversion`

Caused by:
  [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
Bootstrap failed while executing `dist --host= --target x86_64-unknown-fuchsia,aarch64-unknown-fuchsia,wasm32-unknown-unknown,wasm32-wasip1,wasm32-wasip1-threads,wasm32-wasip2,wasm32v1-none,x86_64-unknown-linux-gnux32,x86_64-fortanix-unknown-sgx,nvptx64-nvidia-cuda,armv7-unknown-linux-gnueabi,armv7-unknown-linux-musleabi,i686-unknown-freebsd,x86_64-unknown-none,aarch64-unknown-uefi,i686-unknown-uefi,x86_64-unknown-uefi,riscv64gc-unknown-linux-musl`
Build completed unsuccessfully in 0:11:47

[matthiaskrgr]

@bors retry

[bors]

⌛ Testing commit 6617536 with merge e9385f9...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e9385f9 to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#146818	constify {float}::total_cmp()	9b77832b24ff443e952b9d33cb29b7b02a26f931 (link)
#146896	rustc-dev-guide subtree update	110989f30b5b2430c50952bc8e028e50ea1a5a43 (link)
#146898	Update books	a967e7c063729f3d560575a3699bc173d701e17c (link)
#146899	Fix a crash/mislex when more than one frontmatter closing p…	20e53c9eee9bbb6e84cc74949b2351c6864c585c (link)
#146904	#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn	5e1b33550cfbe38f4c5d2654818f68606a3898b0 (link)
#146907	add regression test for issue 146537	f64b573872a3020182fc7534eee77df4f67107de (link)

previous master: 3e887f5faa

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3e887f5 (parent) -> e9385f9 (this PR)

Test differences

Show 275 test diffs

Stage 1

• floats::total_cmp::const_::test_f128: [missing] -> pass (J1)
• floats::total_cmp::const_::test_f16: [missing] -> pass (J1)
• floats::total_cmp::const_::test_f32: [missing] -> pass (J1)
• floats::total_cmp::const_::test_f64: [missing] -> pass (J1)
• [ui] tests/ui/frontmatter/unclosed-6.rs: [missing] -> pass (J3)
• [ui] tests/ui/suggestions/non_copy_move_out_of_tuple.rs: [missing] -> pass (J3)

Stage 2

• floats::total_cmp::const_::test_f128: [missing] -> pass (J0)
• floats::total_cmp::const_::test_f16: [missing] -> pass (J0)
• floats::total_cmp::const_::test_f32: [missing] -> pass (J0)
• floats::total_cmp::const_::test_f64: [missing] -> pass (J0)
• [ui] tests/ui/frontmatter/unclosed-6.rs: [missing] -> pass (J2)
• [ui] tests/ui/suggestions/non_copy_move_out_of_tuple.rs: [missing] -> pass (J2)
• [run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend (we want LLVM/LLD to be built with zstd support)) -> pass (J4)

Additionally, 262 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-20-1, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-gnu, x86_64-gnu-aux, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
• J1: pr-check-2, x86_64-gnu-llvm-20-3
• J2: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-20-1, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-gnu, x86_64-gnu-debug, x86_64-gnu-llvm-20, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
• J3: x86_64-gnu-llvm-20-3
• J4: x86_64-gnu-nopt

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e9385f9eea0221ef295a188d49d16f8f5189abf1 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. dist-arm-linux-musl: 16901.5s -> 5603.2s (-66.8%)
2. pr-check-1: 4374.7s -> 1474.0s (-66.3%)
3. dist-x86_64-solaris: 15388.6s -> 5262.0s (-65.8%)
4. dist-sparcv9-solaris: 14014.7s -> 5258.6s (-62.5%)
5. dist-x86_64-illumos: 16672.8s -> 6278.7s (-62.3%)
6. pr-check-2: 5277.3s -> 2180.3s (-58.7%)
7. x86_64-rust-for-linux: 6130.7s -> 2549.1s (-58.4%)
8. dist-android: 3651.2s -> 1536.2s (-57.9%)
9. dist-x86_64-freebsd: 11319.8s -> 5041.3s (-55.5%)
10. dist-ohos-x86_64: 9669.8s -> 4307.2s (-55.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (e9385f9): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.7%	[3.7%, 3.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[-2.0%, 3.7%]	2

Cycles

Results (secondary 3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.5%	[3.5%, 3.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.082s -> 471.559s (0.10%)
Artifact size: 387.87 MiB -> 387.91 MiB (0.01%)