Rollup of 8 pull requests by matthiaskrgr · Pull Request #146999 · rust-lang/rust

matthiaskrgr · 2025-09-24T18:34:32Z

Successful merges:

fix 2 borrowck issues #146711 (fix 2 borrowck issues)
revert change removing has_infer check. Commit conservatively patch… #146857 (revert change removing has_infer check. Commit conservatively patch…)
fix ICE in rustdoc::invalid_html_tags #146897 (fix ICE in rustdoc::invalid_html_tags)
Make missed precondition-free float intrinsics safe #146915 (Make missed precondition-free float intrinsics safe)
Switch next-solver related rustc dependencies of r-a to crates.io ones #146932 (Switch next-solver related rustc dependencies of r-a to crates.io ones)
temporary-lifetime-extension-tuple-ctor.rs: make usable on all editions #146959 (temporary-lifetime-extension-tuple-ctor.rs: make usable on all editions)
library: std: sys: pal: uefi: Add some comments #146964 (library: std: sys: pal: uefi: Add some comments)
const-eval: better wording for errors involving maybe-null pointers #146969 (const-eval: better wording for errors involving maybe-null pointers)

r? @ghost
@rustbot modify labels: rollup

…es for now, but more development proceeding. Also contains a more concise test

Also - add Reference id - fix typo

I seemed to have forgotten that since I am using GET_PROTOCOL attribute for the std usecases, I did not need to close the protocols explicitly. So adding these comments as a note to future self not to waste time on the same thing again. Signed-off-by: Ayush Singh <ayush@beagleboard.org>

Co-authored-by: Rémy Rakic <remy.rakic+github@gmail.com>

…be outside the range of a scalar

fix 2 borrowck issues fixes rust-lang#146467 cc ``@amandasystems`` our understanding here is as follows: region constraints from computing implied bounds gets `ConstraintCategory::Internal`. If there's a higher-ranked subtyping errors while computing implied bounds we then ended up with only `ConstraintCategory::Internal` and `ConstraintCategory::OutlivesUnnameablePlaceholder(_)` constraints. The path was something like - `'placeholderU2: 'placeholderU1` (`Internal`) - `'placeholderU1: 'static` (`OutlivesUnnameablePlaceholder('placeholderU2)`) It's generally somewhat subtle here as ideally relating placeholders doesn't introduce `'static` constraints. Relating the placeholders themselves will always error regardless, cc rust-lang#142623. --- separately fixes rust-lang#145925 (comment) by updating the location for deferred closure requirements inside of promoteds. I am not updating their category as doing so is 1) effort and 2) imo actually undesirable 🤔 see the comments in `TypeChecker::check_promoted` cc ``@lqd`` r? lqd

…fer, r=lcnr revert change removing `has_infer` check. Commit conservatively patch… …es for now, but more development proceeding. Hotfix for rust-lang#146852.

…tags-ice-146890, r=GuillaumeGomez fix ICE in rustdoc::invalid_html_tags fixes rust-lang#146890 r? ```@GuillaumeGomez```

…alfJung Make missed precondition-free float intrinsics safe So, in my defence, these were both separated out from the other intrinsics in the file *and* had a different safety comment in the stable versions, so, I didn't notice them before. But, in my offence, the entire reason I did the previous PR was because I was using them for SIMD intrinsic fallbacks, and `fabs` is needed for those too, so, I don't really have an excuse. Extra follow-up to rust-lang#146683. r? ```@RalfJung``` who reviewed the previous one These don't appear to be used anywhere outside of the standard locations, at least.

Switch next-solver related rustc dependencies of r-a to crates.io ones r? ``@ghost`` cc ``@lnicola`` ``@lcnr``

temporary-lifetime-extension-tuple-ctor.rs: make usable on all editions Also - add Reference id - fix typo

library: std: sys: pal: uefi: Add some comments I seemed to have forgotten that since I am using GET_PROTOCOL attribute for the std usecases, I did not need to close the protocols explicitly. So adding these comments as a note to future self not to waste time on the same thing again.

const-eval: better wording for errors involving maybe-null pointers Fixes rust-lang#146748 r? ``@oli-obk``

matthiaskrgr · 2025-09-24T18:34:42Z

@bors r+ rollup=never p=5

bors · 2025-09-24T18:34:45Z

📌 Commit ec378dc has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-09-24T18:36:01Z

⌛ Testing commit ec378dc with merge caccb4d...

bors · 2025-09-24T21:46:15Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing caccb4d to master...

rust-timer · 2025-09-24T21:48:34Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#146711	fix 2 borrowck issues	`8727a686a30a677f7135404d0b58e06fd236cccf` (link)
#146857	revert change removing `has_infer` check. Commit conservati…	`c376c9aec400e06c3ef65cb3d6ceba732647bb73` (link)
#146897	fix ICE in rustdoc::invalid_html_tags	`6c6e37d5706f84b956dc6d7ccf86adf2b1cb5d1e` (link)
#146915	Make missed precondition-free float intrinsics safe	`ddfdf91188369dd9776cb13e0734bd22f3e337d8` (link)
#146932	Switch next-solver related rustc dependencies of r-a to cra…	`09da2edd3a50eec3a74f74ca6a219eae61575e02` (link)
#146959	temporary-lifetime-extension-tuple-ctor.rs: make usable on …	`0eab70c3572ce415912c6bbc56b8d9fb72174a2f` (link)
#146964	library: std: sys: pal: uefi: Add some comments	`04cbe53eb0ec99375ef1e36e3e8e3c7764142d3a` (link)
#146969	const-eval: better wording for errors involving maybe-null …	`9b88675bffec0c3045c080d542db354b0af2566f` (link)

previous master: 15283f6fe9

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-09-24T21:49:06Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 15283f6 (parent) -> caccb4d (this PR)

Test differences

Show 234 test diffs

Stage 1

[ui] tests/rustdoc-ui/lints/invalid-html-tags-ice-146890.rs: [missing] -> pass (J1)
[ui] tests/ui/associated-inherent-types/hr-do-not-blame-outlives-static-ice.rs: [missing] -> pass (J1)
[ui] tests/ui/consts/const_transmute_type_id7.rs: [missing] -> pass (J1)
[ui] tests/ui/higher-ranked/do-not-blame-outlives-static-ice.rs: [missing] -> pass (J1)
[ui] tests/ui/type-inference/box_has_sigdrop.rs: [missing] -> pass (J1)
[ui] tests/ui/type-inference/dropper_has_sigdrop.rs: [missing] -> pass (J1)
[ui] tests/ui/type-inference/has_sigdrop.rs: pass -> [missing] (J1)

Stage 2

[ui] tests/ui/associated-inherent-types/hr-do-not-blame-outlives-static-ice.rs: [missing] -> pass (J0)
[ui] tests/ui/consts/const_transmute_type_id7.rs: [missing] -> pass (J0)
[ui] tests/ui/higher-ranked/do-not-blame-outlives-static-ice.rs: [missing] -> pass (J0)
[ui] tests/ui/type-inference/box_has_sigdrop.rs: [missing] -> pass (J0)
[ui] tests/ui/type-inference/dropper_has_sigdrop.rs: [missing] -> pass (J0)
[ui] tests/ui/type-inference/has_sigdrop.rs: pass -> [missing] (J0)
[ui] tests/rustdoc-ui/lints/invalid-html-tags-ice-146890.rs: [missing] -> pass (J2)

Additionally, 220 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard caccb4d0368bd918ef6668af8e13834d07040417 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-gnu-debug: 9697.6s -> 4006.0s (-58.7%)
aarch64-gnu: 8865.2s -> 6445.2s (-27.3%)
pr-check-1: 1857.3s -> 1456.5s (-21.6%)
aarch64-gnu-llvm-20-2: 2626.6s -> 2222.4s (-15.4%)
x86_64-gnu-llvm-20: 2789.7s -> 2424.0s (-13.1%)
aarch64-apple: 6194.3s -> 6988.7s (12.8%)
aarch64-gnu-llvm-20-1: 3921.4s -> 3456.7s (-11.9%)
pr-check-2: 2478.9s -> 2185.3s (-11.8%)
dist-riscv64-linux: 5535.3s -> 4895.7s (-11.6%)
x86_64-gnu-tools: 3695.7s -> 3314.7s (-10.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-24T22:56:21Z

Finished benchmarking commit (caccb4d): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-2.7%, -2.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.9%	[-2.7%, 1.0%]	2

Cycles

Results (primary 2.1%, secondary 4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	4.2%	[4.2%, 4.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.213s -> 472.505s (0.27%)
Artifact size: 387.83 MiB -> 387.91 MiB (0.02%)

rust-log-analyzer · 2025-09-25T00:01:03Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v5' (SHA:08c6903cd8c0fde910a37f88322edcfb5dd907a8)
Complete job name: DockerHub mirror
##[group]Run actions/checkout@v5
with:
  persist-credentials: false
  repository: rust-lang/rust
  token: ***
---
http.https://github.com/.extraheader
[command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
##[endgroup]
##[group]Run echo "***" | docker login ghcr.io -u rust-lang --password-stdin
echo "***" | docker login ghcr.io -u rust-lang --password-stdin
shell: /usr/bin/bash -e {0}
##[endgroup]

WARNING! Your credentials are stored unencrypted in '/home/runner/.docker/config.json'.
Configure a credential helper to remove this warning. See
https://docs.docker.com/go/credential-store/

Login Succeeded
##[group]Run curl -sL "https://github.com/google/go-containerregistry/releases/download/${VERSION}/go-containerregistry_${OS}_${ARCH}.tar.gz" | tar -xzf -
curl -sL "https://github.com/google/go-containerregistry/releases/download/${VERSION}/go-containerregistry_${OS}_${ARCH}.tar.gz" | tar -xzf -
shell: /usr/bin/bash -e {0}
---
  VERSION: v0.20.2
  OS: Linux
  ARCH: x86_64
##[endgroup]
##[group]Run # List of DockerHub images to mirror to ghcr.io
# List of DockerHub images to mirror to ghcr.io
images=(
  # Mirrored because used by the tidy job, which doesn't cache Docker images
  "ubuntu:22.04"
  # Mirrored because used by all linux CI jobs, including tidy
  "moby/buildkit:buildx-stable-1"
  # Mirrored because used when CI is running inside a Docker container
  "alpine:3.4"
  # Mirrored because used by dist-x86_64-linux
  "centos:7"
)

# Mirror each image from DockerHub to ghcr.io
for img in "${images[@]}"; do
  echo "Mirroring ${img}..."
  # Remove namespace from the image if any.
  # E.g. "moby/buildkit:buildx-stable-1" becomes "buildkit:buildx-stable-1"
  dest_image=$(echo "${img}" | cut -d'/' -f2-)
  ./crane copy \
    "docker.io/${img}" \
    "ghcr.io/rust-lang/${dest_image}"
done
shell: /usr/bin/bash -e {0}
##[endgroup]
Mirroring ubuntu:22.04...
2025/09/25 00:00:53 Copying from docker.io/ubuntu:22.04 to ghcr.io/rust-lang/ubuntu:22.04
Error: fetching "docker.io/ubuntu:22.04": GET https://index.docker.io/v2/library/ubuntu/manifests/22.04: UNAUTHORIZED: authentication required; [map[Action:pull Class: Name:library/ubuntu Type:repository]]
##[error]Process completed with exit code 1.
Post job cleanup.

lcnr and others added 19 commits September 18, 2025 10:50

fix location for nested bodies in promoteds

4919d55

internal constraints are better than placeholder outlives

3b2bbcd

fix ICE in rustdoc::invalid_html_tags

82c4018

revert change removing has_infer check. Commit conservatively patch…

60b3563

…es for now, but more development proceeding. Also contains a more concise test

Make missed precondition-free float intrinsics safe

e8a8e06

temporary-lifetime-extension-tuple-ctor.rs: make usable on all editions

c9dc0e3

Also - add Reference id - fix typo

fix wording

3378997

Co-authored-by: Rémy Rakic <remy.rakic+github@gmail.com>

const-eval: improve and actually test the errors when pointers might …

0a41add

…be outside the range of a scalar

const validation: better error for maybe-null references

8328c3d

Switch next-solver related rustc dependencies of r-a to crates.io ones

0e7cc32

Rollup merge of rust-lang#146857 - tnuha:revert_self_has_no_region_in…

79bb3c4

…fer, r=lcnr revert change removing `has_infer` check. Commit conservatively patch… …es for now, but more development proceeding. Hotfix for rust-lang#146852.

Rollup merge of rust-lang#146897 - lolbinarycat:rustdoc-invalid_html_…

4e225ee

…tags-ice-146890, r=GuillaumeGomez fix ICE in rustdoc::invalid_html_tags fixes rust-lang#146890 r? ```@GuillaumeGomez```

Rollup merge of rust-lang#146932 - ShoyuVanilla:ra-in-tree-hack, r=lcnr

4300cd6

Switch next-solver related rustc dependencies of r-a to crates.io ones r? ``@ghost`` cc ``@lnicola`` ``@lcnr``

Rollup merge of rust-lang#146959 - tshepang:patch-2, r=nnethercote

af22499

temporary-lifetime-extension-tuple-ctor.rs: make usable on all editions Also - add Reference id - fix typo

Rollup merge of rust-lang#146969 - RalfJung:maybe-null-errors, r=oli-obk

ec378dc

const-eval: better wording for errors involving maybe-null pointers Fixes rust-lang#146748 r? ``@oli-obk``

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 24, 2025

bors merged commit caccb4d into rust-lang:master Sep 24, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Sep 24, 2025

bors mentioned this pull request Sep 24, 2025

Guard HIR lowered contracts with contract_checks #144438

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 8 pull requests#146999

Rollup of 8 pull requests#146999
bors merged 19 commits intorust-lang:masterfrom
matthiaskrgr:rollup-0gbkm82

matthiaskrgr commented Sep 24, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Sep 24, 2025

Uh oh!

rust-log-analyzer commented Sep 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Uh oh!

Conversation

matthiaskrgr commented Sep 24, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

bors commented Sep 24, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Sep 24, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rust-log-analyzer commented Sep 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

matthiaskrgr commented Sep 24, 2025 •

edited by rustbot

Loading