Merged
Conversation
rustbot
added
A-tidy
Collaborator
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
30 tasks
Collaborator
|
☔ The latest upstream changes (presumably #148938) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
r=me after the rebase. |
joboet
force-pushed
the
mov_kernel_copy_sys
branch
from
21ab568 to
d589d2f
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
Collaborator
bors
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
Nov 18, 2025
Rollup merge of #147077 - joboet:mov_kernel_copy_sys, r=ibraheemdev std: move `kernel_copy` to `sys` Part of #117276. The current organisation of the `kernel_copy` mechanism used to specialise `io::copy` on Linux necessitated circular links between the `io::copy` module and the implementation in `sys::pal::unix::kernel_copy`, as well as presenting an exception to the tidy PAL rule that forbids OS-based `#[cfg]`s outside of `sys` and `os`. This PR fixes this by moving `kernel_copy` to `sys` (as per #117276) and returning a `CopyState` from that function specifying whether `io::copy` should use its fallback. The `kernel_copy` function on other platforms just unconditionally returns `CopyState::Fallback`.
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Nov 19, 2025
Rollup of 4 pull requests Successful merges: - rust-lang/rust#147077 (std: move `kernel_copy` to `sys`) - rust-lang/rust#149030 (doc: fix `strict_provenance_lints` tracking issue link) - rust-lang/rust#149031 (Update books) - rust-lang/rust#149034 (update my email in mailmap) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
…heemdev std: move `kernel_copy` to `sys` Part of rust-lang#117276. The current organisation of the `kernel_copy` mechanism used to specialise `io::copy` on Linux necessitated circular links between the `io::copy` module and the implementation in `sys::pal::unix::kernel_copy`, as well as presenting an exception to the tidy PAL rule that forbids OS-based `#[cfg]`s outside of `sys` and `os`. This PR fixes this by moving `kernel_copy` to `sys` (as per rust-lang#117276) and returning a `CopyState` from that function specifying whether `io::copy` should use its fallback. The `kernel_copy` function on other platforms just unconditionally returns `CopyState::Fallback`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #117276.
The current organisation of the
kernel_copymechanism used to specialiseio::copyon Linux necessitated circular links between theio::copymodule and the implementation insys::pal::unix::kernel_copy, as well as presenting an exception to the tidy PAL rule that forbids OS-based#[cfg]s outside ofsysandos.This PR fixes this by moving
kernel_copytosys(as per #117276) and returning aCopyStatefrom that function specifying whetherio::copyshould use its fallback. Thekernel_copyfunction on other platforms just unconditionally returnsCopyState::Fallback.