You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Oct 3, 2025
rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
I don't see any existing uses of //@ edition ranges in the test suite.
When is it supposed to be used? Why in this test specifically?
When are the //@ reference directives supposed to be used?
If ~all tests will have them then it's fine, otherwise it's not clear why this test should have them. It's not directly related to some reference clause, it's not even useful in general, and is mostly an example of reddit-oriented testing.
I've seen #146166, but it doesn't answer the question.
I'd expect the edition ranges to be (semi) automatically mass-annotated as a part of #145364.
For addition of the reference annotations I'd also expect to be done more systematically, similarly to #132376, but that's probably less likely to happen.
The change itself is harmless, but it's sort of like manually formatting code one function at a time instead of rustfmting the whole codebase, I don't want to encourage this.
lowered edition to 2018 because that test can run on that edition
made it a range because the test can also run on later editions
I do not expect an automatic edition mass-annotation to lower the edition of this test automatically
I added a reference id since I was touching it anyway... doing it more systematically feels much out of scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, add Reference ids