Rollup of 7 pull requests by Zalathar · Pull Request #147363 · rust-lang/rust

Zalathar · 2025-10-05T04:35:06Z

Successful merges:

compiletest: Make DirectiveLine responsible for name/value splitting #147288 (compiletest: Make DirectiveLine responsible for name/value splitting)
Add documentation about unwinding to wasm targets #147309 (Add documentation about unwinding to wasm targets)
Mark PatternTypo suggestion as maybe incorrect #147310 (Mark PatternTypo suggestion as maybe incorrect)
Avoid to suggest pattern match on the similarly named in fn signature #147320 (Avoid to suggest pattern match on the similarly named in fn signature)
Implement non-poisoning Mutex::with_mut, RwLock::with and RwLock::with_mut #147328 (Implement non-poisoning Mutex::with_mut, RwLock::with and RwLock::with_mut)
Make fmt::Write a diagnostic item #147337 (Make fmt::Write a diagnostic item)
Improve the advice given by panic_immediate_abort #147349 (Improve the advice given by panic_immediate_abort)

r? @ghost
@rustbot modify labels: rollup

This commit adds some documentation about the state of `-Cpanic=unwind` for the following wasm targets: * `wasm32-unknown-unknown` * `wasm32-wasip1` * `wasm32-wasip2` * `wasm32v1-none` Notably it's possible to use `-Cpanic=unwind` with `-Zbuild-std` and it's also mentioned that there are no concrete proposals at this time to adding a new set of targets which support unwinding. My hunch is that in a few years' time it would make sense to enable it by default on these targets (except for `wasm32v1-none`) but that's a problem for future folks to debate. For now this is an attempt to document the status quo.

…::with_mut` ACP: rust-lang/libs-team#497.

compiletest: Make `DirectiveLine` responsible for name/value splitting - Follow-up to rust-lang#147170. --- Now that all of the directive-parsing functions have access to a `DirectiveLine`, we can move all of the ad-hoc name/value splitting code into `DirectiveLine` itself, making directive parsing simpler and more consistent. The first commit is just moving code into a submodule, so the actual changes can be seen in the subsequent commits. r? jieyouxu

…r=jieyouxu Add documentation about unwinding to wasm targets This commit adds some documentation about the state of `-Cpanic=unwind` for the following wasm targets: * `wasm32-unknown-unknown` * `wasm32-wasip1` * `wasm32-wasip2` * `wasm32v1-none` Notably it's possible to use `-Cpanic=unwind` with `-Zbuild-std` and it's also mentioned that there are no concrete proposals at this time to adding a new set of targets which support unwinding. My hunch is that in a few years' time it would make sense to enable it by default on these targets (except for `wasm32v1-none`) but that's a problem for future folks to debate. For now this is an attempt to document the status quo.

…ttern-typo, r=chenyukang Mark `PatternTypo` suggestion as maybe incorrect Partial fix for rust-lang#147303. `@rustbot` label A-diagnostics A-suggestion-diagnostics D-invalid-suggestion

…g, r=jieyouxu Avoid to suggest pattern match on the similarly named in fn signature Fixes rust-lang#147303

Implement non-poisoning `Mutex::with_mut`, `RwLock::with` and `RwLock::with_mut` ACP: rust-lang/libs-team#497.

Make `fmt::Write` a diagnostic item I'm working on an enhancement to [`clippy::format_push_string`](https://rust-lang.github.io/rust-clippy/master/index.html#format_push_string), which would suggest an autofix to replace `push_str`/`+=` with `write!`. But that could require importing `std::fmt::Write`, and so I need this diagnostic item to check if it's already in scope. The reason I called it `FmtWrite` and not just `Write` is that there's already an `IoWrite` defined.

…=Noratrieb Improve the advice given by panic_immediate_abort Now that rust-lang#147338 is merged, users should consider using the Cargo support for immediate-aborting panics.

Zalathar · 2025-10-05T04:35:23Z

Subset of #147359.

@bors r+ rollup=never p=5

bors · 2025-10-05T04:35:26Z

📌 Commit a0a4905 has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-10-05T04:36:52Z

⌛ Testing commit a0a4905 with merge e2c96cc...

bors · 2025-10-05T07:46:11Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing e2c96cc to master...

rust-timer · 2025-10-05T07:48:11Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#147288	compiletest: Make `DirectiveLine` responsible for name/valu…	`449bbf645926d3a7a60846d1b3ad5660a6aee856` (link)
#147309	Add documentation about unwinding to wasm targets	`8bf26047c31267d110b64f887438dfe116dc3ca4` (link)
#147310	Mark `PatternTypo` suggestion as maybe incorrect	`313bbf13ee787cdd834dac5fd3bd864fefb92801` (link)
#147320	Avoid to suggest pattern match on the similarly named in fn…	`b621d3f4815f3d2515891be665fbb9b0b2a1f03f` (link)
#147328	Implement non-poisoning `Mutex::with_mut`, `RwLock::with` a…	`7cb2363b60040f6ec99ed977c6785d0b63dce051` (link)
#147337	Make `fmt::Write` a diagnostic item	`3e6ad318e74cb4416ac0ca41e374c28e03454bc9` (link)
#147349	Improve the advice given by panic_immediate_abort	`bf93a0f229380748e8382febeb95e98116e4a183` (link)

previous master: 227ac7c3cd

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-10-05T07:48:57Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 227ac7c (parent) -> e2c96cc (this PR)

Test differences

Show 216 test diffs

Stage 1

[run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored on targets without Rust's LLD (the system linker will most likely not support zstd)) -> ignore (ignored on targets without Rust's LLD) (J3)
[ui] tests/ui/fn/invalid-sugg-for-unused-fn-arg-147303.rs: [missing] -> pass (J3)
mutex::test_mutex_with_mut: [missing] -> pass (J4)
rwlock::test_rwlock_with: [missing] -> pass (J4)
rwlock::test_rwlock_with_mut: [missing] -> pass (J4)

Stage 2

[run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend (we want LLVM/LLD to be built with zstd support)) -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) (J0)
mutex::test_mutex_with_mut: [missing] -> pass (J1)
rwlock::test_rwlock_with: [missing] -> pass (J1)
rwlock::test_rwlock_with_mut: [missing] -> pass (J1)
[run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored on targets without Rust's LLD (the system linker will most likely not support zstd)) -> ignore (ignored on targets without Rust's LLD) (J2)
[ui] tests/ui/fn/invalid-sugg-for-unused-fn-arg-147303.rs: [missing] -> pass (J5)

Additionally, 205 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e2c96cc06bdbdbc6f59c7551194d6a742260d6ff --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 8739.6s -> 6057.8s (-30.7%)
pr-check-1: 1667.5s -> 1393.5s (-16.4%)
x86_64-gnu-debug: 7167.8s -> 6265.2s (-12.6%)
dist-x86_64-apple: 7241.3s -> 6388.6s (-11.8%)
i686-gnu-nopt-1: 8026.6s -> 7098.1s (-11.6%)
x86_64-rust-for-linux: 2941.0s -> 2639.4s (-10.3%)
x86_64-gnu-llvm-20-3: 6857.5s -> 6155.7s (-10.2%)
dist-i686-msvc: 7597.1s -> 8366.1s (10.1%)
aarch64-gnu-debug: 4280.0s -> 3850.7s (-10.0%)
i686-gnu-1: 8107.0s -> 7320.8s (-9.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-05T08:58:00Z

Finished benchmarking commit (e2c96cc): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-0.5%	[-1.6%, -0.2%]	6
Improvements ✅ (secondary)	-0.5%	[-1.6%, -0.0%]	4
All ❌✅ (primary)	-0.5%	[-1.6%, -0.2%]	6

Max RSS (memory usage)

Results (primary 0.4%, secondary 4.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.1%]	2
Regressions ❌ (secondary)	4.6%	[4.6%, 4.6%]	1
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[-0.8%, 1.1%]	3

Cycles

Results (primary 2.6%, secondary 4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.6%	[2.6%, 2.6%]	1
Regressions ❌ (secondary)	4.2%	[4.2%, 4.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.6%	[2.6%, 2.6%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.078s -> 471.388s (0.28%)
Artifact size: 388.29 MiB -> 388.34 MiB (0.01%)

panstromek · 2025-10-06T15:54:26Z

perf triage:

Improvements outweigh a small regression in secondary stress test.

@rustbot label: +perf-regression-triaged

Jules-Bertholet and others added 16 commits October 3, 2025 16:00

Mark PatternTypo suggestion as maybe incorrect

d5ba5c1

Avoid to suggest pattern match on the similarly named in fn signature

e9a45e6

Implement non-poisoning Mutex::with_mut, RwLock::with and `RwLock…

ba42380

…::with_mut` ACP: rust-lang/libs-team#497.

Make fmt::Write a diagnostic item

2688f60

Improve the advice given by panic_immediate_abort

b5fb01d

Move DirectiveLine into its own submodule

757d98c

Allow easy extraction of name/value from a DirectiveLine

6783e94

Use new DirectiveLine features in directive parsing

33c99a0

Rollup merge of rust-lang#147310 - Jules-Bertholet:maybe-incorrect-pa…

620ffe6

…ttern-typo, r=chenyukang Mark `PatternTypo` suggestion as maybe incorrect Partial fix for rust-lang#147303. `@rustbot` label A-diagnostics A-suggestion-diagnostics D-invalid-suggestion

Rollup merge of rust-lang#147320 - chenyukang:yukang-fix-147303-fn-ar…

cae84c6

…g, r=jieyouxu Avoid to suggest pattern match on the similarly named in fn signature Fixes rust-lang#147303

Rollup merge of rust-lang#147328 - EFanZh:lock-with, r=joboet

56c96ae

Implement non-poisoning `Mutex::with_mut`, `RwLock::with` and `RwLock::with_mut` ACP: rust-lang/libs-team#497.

Rollup merge of rust-lang#147349 - saethlin:panic-immediate-advice, r…

a0a4905

…=Noratrieb Improve the advice given by panic_immediate_abort Now that rust-lang#147338 is merged, users should consider using the Cargo support for immediate-aborting panics.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 5, 2025

bors merged commit e2c96cc into rust-lang:master Oct 5, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Oct 5, 2025

Zalathar deleted the rollup-d9kd06g branch October 5, 2025 07:52

bors mentioned this pull request Oct 5, 2025

Perform unused assignment and unused variables lints on MIR. #142390

Merged

rustbot added the perf-regression Performance regression. label Oct 5, 2025

rustbot added the perf-regression-triaged The performance regression has been triaged. label Oct 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests#147363

Rollup of 7 pull requests#147363
bors merged 16 commits intorust-lang:masterfrom
Zalathar:rollup-d9kd06g

Zalathar commented Oct 5, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Oct 5, 2025

Uh oh!

bors commented Oct 5, 2025

Uh oh!

bors commented Oct 5, 2025

Uh oh!

bors commented Oct 5, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 5, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Oct 5, 2025

Uh oh!

panstromek commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Conversation

Zalathar commented Oct 5, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Oct 5, 2025

Uh oh!

bors commented Oct 5, 2025

Uh oh!

bors commented Oct 5, 2025

Uh oh!

bors commented Oct 5, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 5, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Oct 5, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

panstromek commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Zalathar commented Oct 5, 2025 •

edited by rustbot

Loading