Add a test for the cold attribute by ehuss · Pull Request #147476 · rust-lang/rust

ehuss · 2025-10-08T13:55:31Z

This adds a test for the cold attribute to verify that it actually does something, and that it applies correctly in all the positions it is expected to work.

rustbot · 2025-10-08T13:55:36Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

chenyukang · 2025-10-08T16:35:11Z

@bors r=chenyukang

bors · 2025-10-08T16:35:14Z

📌 Commit 849feea has been approved by chenyukang

It is now in the queue for this repository.

…ukang Add a test for the cold attribute This adds a test for the cold attribute to verify that it actually does something, and that it applies correctly in all the positions it is expected to work.

Rollup of 6 pull requests Successful merges: - #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition) - #147420 (Add diagnostic items for `pub mod consts` of FP types) - #147467 (Fix double warnings on `#[no_mangle]`) - #147476 (Add a test for the cold attribute) - #147480 (Do not invalidate CFG caches in CtfeLimit.) - #147481 (format: some small cleanup) r? `@ghost` `@rustbot` modify labels: rollup

chenyukang · 2025-10-09T03:17:51Z

@bors r-
seems failed for: #147492 (comment)

This adds a test for the cold attribute to verify that it actually does something, and that it applies correctly in all the positions it is expected to work.

ehuss · 2025-10-10T03:25:47Z

I was worried that the exact match could be a problem there. I have updated it to use CHECK-NOT which I think should be more robust, and tested that job in docker.

ehuss · 2025-10-21T01:59:08Z

Ping @chenyukang, just wondering if you have any questions?

chenyukang · 2025-10-21T02:17:46Z

sorry for the delay.

@bors r=chenyukang

bors · 2025-10-21T02:17:49Z

📌 Commit 50e1884 has been approved by chenyukang

It is now in the queue for this repository.

bors · 2025-10-21T07:41:36Z

⌛ Testing commit 50e1884 with merge cf8346d...

bors · 2025-10-21T10:53:05Z

☀️ Test successful - checks-actions
Approved by: chenyukang
Pushing cf8346d to master...

github-actions · 2025-10-21T10:56:25Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e821cb8 (parent) -> cf8346d (this PR)

Test differences

Show 4 test diffs

Stage 1

[codegen] tests/codegen-llvm/cold-attribute.rs: [missing] -> pass (J1)

Stage 2

[codegen] tests/codegen-llvm/cold-attribute.rs: [missing] -> pass (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard cf8346dd4ccb3514c8b48c6890297e16abafd814 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-apple: 7527.1s -> 8775.6s (16.6%)
aarch64-apple: 7321.5s -> 8367.1s (14.3%)
x86_64-msvc-ext2: 5602.5s -> 6168.5s (10.1%)
x86_64-gnu-llvm-20-3: 5756.1s -> 6298.1s (9.4%)
i686-msvc-1: 10406.0s -> 9537.7s (-8.3%)
aarch64-gnu-debug: 4041.6s -> 3750.2s (-7.2%)
x86_64-gnu-miri: 4392.7s -> 4094.8s (-6.8%)
x86_64-mingw-2: 7834.5s -> 7314.8s (-6.6%)
dist-powerpc64le-linux-musl: 5837.2s -> 5458.4s (-6.5%)
dist-various-1: 3781.6s -> 4024.5s (6.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-21T12:04:17Z

Finished benchmarking commit (cf8346d): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.0%	[1.2%, 5.2%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-3.0%, -2.3%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.0%	[1.8%, 9.0%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.4%	[-9.5%, -1.9%]	8
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.699s -> 472.752s (0.01%)
Artifact size: 390.70 MiB -> 388.66 MiB (-0.52%)

Add a test for the cold attribute This adds a test for the cold attribute to verify that it actually does something, and that it applies correctly in all the positions it is expected to work.

rustbot assigned Mark-Simulacrum Oct 8, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 8, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025

matthiaskrgr mentioned this pull request Oct 8, 2025

Rollup of 6 pull requests #147490

Closed

matthiaskrgr mentioned this pull request Oct 8, 2025

Rollup of 6 pull requests #147492

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 9, 2025

Add a test for the cold attribute

50e1884

This adds a test for the cold attribute to verify that it actually does something, and that it applies correctly in all the positions it is expected to work.

ehuss force-pushed the cold-attribute-test branch from 849feea to 50e1884 Compare October 10, 2025 03:24

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 21, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 21, 2025

bors merged commit cf8346d into rust-lang:master Oct 21, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Oct 21, 2025

Uh oh!

Conversation

ehuss commented Oct 8, 2025

Uh oh!

rustbot commented Oct 8, 2025

Uh oh!

chenyukang commented Oct 8, 2025

Uh oh!

bors commented Oct 8, 2025

Uh oh!

chenyukang commented Oct 9, 2025

Uh oh!

ehuss commented Oct 10, 2025

Uh oh!

ehuss commented Oct 21, 2025

Uh oh!

chenyukang commented Oct 21, 2025

Uh oh!

bors commented Oct 21, 2025

Uh oh!

bors commented Oct 21, 2025

Uh oh!

bors commented Oct 21, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 21, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Oct 21, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants