Rollup of 6 pull requests by GuillaumeGomez · Pull Request #147629 · rust-lang/rust

GuillaumeGomez · 2025-10-13T09:25:26Z

Successful merges:

repr_transparent_external_private_fields: normalize types during traversal #147514 (repr_transparent_external_private_fields: normalize types during traversal)
Add doc links between {integer}::from_str_radix and from_str #147605 (Add doc links between {integer}::from_str_radix and from_str)
cg_llvm: Use LLVMDIBuilderCreateGlobalVariableExpression #147608 (cg_llvm: Use LLVMDIBuilderCreateGlobalVariableExpression)
Clear ChunkedBitSet without reallocating #147623 (Clear ChunkedBitSet without reallocating)
Add a warning when running tests with the GCC backend and debug assertions are enabled #147625 (Add a warning when running tests with the GCC backend and debug assertions are enabled)
Generalize configuring LLD as the default linker in bootstrap #147626 (Generalize configuring LLD as the default linker in bootstrap)

r? @ghost
@rustbot modify labels: rollup

…ersal

Note that the code in `LLVMRustDIBuilderCreateStaticVariable` that tried to downcast `InitVal` appears to have been dead, because `llvm::ConstantInt` and `llvm::ConstantFP` are not subclasses of `llvm::GlobalVariable`.

…tions are enabled

…-normalize, r=lcnr repr_transparent_external_private_fields: normalize types during traversal Determining whether a type is a 1-ZST will internally do full normalization, so we better do the same when scanning for non-exhaustive types. r? ``@lcnr``

…mulacrum Add doc links between `{integer}::from_str_radix` and `from_str` When parsing base-10 numbers, it's easy to miss `<Self as FromStr>::from_str` and `str::parse` as potential alternatives to `from_str_radix`. - A similar suggestion is given by https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10

cg_llvm: Use `LLVMDIBuilderCreateGlobalVariableExpression` - Part of rust-lang#134001 - Follow-up to rust-lang#146763 --- This PR dismantles the somewhat complicated `LLVMRustDIBuilderCreateStaticVariable` function, and replaces it with equivalent calls to `LLVMDIBuilderCreateGlobalVariableExpression` and `LLVMGlobalSetMetadata`. A key difference is that the new code does not replicate the attempted downcast of `InitVal`. As far as I can tell, those downcasts were actually dead, because `llvm::ConstantInt` and `llvm::ConstantFP` are not subclasses of `llvm::GlobalVariable`. I tried replacing those code paths with fatal errors, and was unable to induce failure in any of the relevant test suites I ran. I have also confirmed that if the calls to `create_static_variable` are commented out, debuginfo tests will fail, demonstrating some amount of relevant test coverage. The new `DIBuilder` methods have been added via an extension trait, not as inherent methods, to avoid impeding rust-lang#142897.

Clear `ChunkedBitSet` without reallocating There doesn't appear to be any reason to clear a ChunkedBitSet via its constructor (which allocates a new list of chunks), when we could just fill the existing allocation with `Chunk::Zeros` instead. For comparison, the `insert_all` impl added by the same PR (rust-lang#93984) does the simple thing here and just overwrites every chunk with `Chunk::Ones`. (That fill was then made somewhat easier by rust-lang#145480, which removes the chunk size from all-zero/all-one chunks.) r? nnethercote (or compiler)

…llaumeGomez Add a warning when running tests with the GCC backend and debug assertions are enabled Discussed at https://rust-lang.zulipchat.com/#narrow/channel/233931-t-compiler.2Fmajor-changes/topic/Run.20more.20tests.20for.20rustc_codegen_gcc.20in.20t.E2.80.A6.20compiler-team.23891/with/543701828. r? ``@GuillaumeGomez``

Generalize configuring LLD as the default linker in bootstrap Reopen of rust-lang#147157, because apparently bors can't deal with it for some reason. r? ``@ghost``

GuillaumeGomez · 2025-10-13T09:25:37Z

@bors r+ p=5 rollup=never

bors · 2025-10-13T09:25:40Z

📌 Commit 0e6ec72 has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2025-10-13T12:13:09Z

⌛ Testing commit 0e6ec72 with merge 9b82646...

bors · 2025-10-13T15:23:03Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 9b82646 to master...

rust-timer · 2025-10-13T15:24:49Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#147514	repr_transparent_external_private_fields: normalize types d…	`f6ec643da501608f25dae9270046e59b6ed6949d` (link)
#147605	Add doc links between `{integer}::from_str_radix` and `from…	`ea0a8fff77bae1303949e03b317d46053b7c02db` (link)
#147608	cg_llvm: Use `LLVMDIBuilderCreateGlobalVariableExpression`	`a0ff00ecb620202ac920e9b4da489873e5a26b60` (link)
#147623	Clear `ChunkedBitSet` without reallocating	`8e73ac269b89e201d9f8078fb0a96504ef479571` (link)
#147625	Add a warning when running tests with the GCC backend and d…	`514fdd0323104856df570c24752e02a01a3e8789` (link)
#147626	Generalize configuring LLD as the default linker in bootstr…	`a68f179a9509e7d496014b070d2555adea815065` (link)

previous master: 956f47c32f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-10-13T15:26:44Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 956f47c (parent) -> 9b82646 (this PR)

Test differences

Show 387 test diffs

Stage 0

core::builder::tests::snapshot::build_compiler_lld_opt_in_lld_disabled: [missing] -> pass (J0)

Additionally, 386 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-20-2, aarch64-msvc-2, i686-gnu-2, i686-gnu-nopt-2, i686-msvc-2, x86_64-gnu, x86_64-gnu-llvm-20-1, x86_64-gnu-llvm-20-3, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-2, x86_64-msvc-2

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 9b8264604ef800b5539d04bf78ebdef5c5fa4968 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-apple: 5878.1s -> 7659.5s (30.3%)
dist-x86_64-apple: 8213.0s -> 6792.5s (-17.3%)
aarch64-msvc-2: 5269.8s -> 4636.4s (-12.0%)
dist-aarch64-msvc: 5614.1s -> 6278.6s (11.8%)
x86_64-gnu-llvm-20: 2547.3s -> 2845.0s (11.7%)
dist-arm-linux-gnueabi: 4910.8s -> 5419.1s (10.4%)
x86_64-gnu-miri: 4331.3s -> 4775.5s (10.3%)
aarch64-gnu: 7197.2s -> 6473.3s (-10.1%)
dist-aarch64-linux: 6616.2s -> 6011.7s (-9.1%)
aarch64-gnu-llvm-20-1: 3583.8s -> 3886.8s (8.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-13T16:52:13Z

Finished benchmarking commit (9b82646): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 3.1%, secondary -1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.5%	[-1.5%, -1.5%]	1
All ❌✅ (primary)	3.1%	[3.1%, 3.1%]	1

Cycles

Results (secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.3%	[2.2%, 4.1%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-5.6%, -2.6%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.655s -> 474.96s (0.06%)
Artifact size: 388.12 MiB -> 388.14 MiB (0.01%)

Kobzol and others added 21 commits October 6, 2025 09:35

Generalize setting rust-lld as the default linker on Linux

b6c9a6a

Destructure TomlConfig and add missing default_linker config

8dd97f8

Allow manually opting in and out of Linux linker overrides

902cec2

Update change tracker

e7c9e12

Handle external LLVM config

b07d88f

repr_transparent_external_private_fields: normalize types during trav…

3452415

…ersal

Rename default linker linux field

da86710

Add LLDB commands to tests/debuginfo/basic-types-globals.rs

10393a8

Add doc links between {integer}::from_str_radix and from_str

2be88e3

Hoist some stranded use declarations

b6ea824

Extract DIBuilderExt::create_expression

45e9ebe

Extract DIBuilderExt::create_static_variable

1db7d41

Use LLVMDIBuilderCreateGlobalVariableExpression

1081d98

Note that the code in `LLVMRustDIBuilderCreateStaticVariable` that tried to downcast `InitVal` appears to have been dead, because `llvm::ConstantInt` and `llvm::ConstantFP` are not subclasses of `llvm::GlobalVariable`.

Clear ChunkedBitSet without reallocating

9ff52bf

Add a warning when running tests with the GCC backend and debug asser…

e755d71

…tions are enabled

Rollup merge of rust-lang#147626 - Kobzol:lld-generalize2, r=jieyouxu

0e6ec72

Generalize configuring LLD as the default linker in bootstrap Reopen of rust-lang#147157, because apparently bors can't deal with it for some reason. r? ``@ghost``

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 13, 2025

bors merged commit 9b82646 into rust-lang:master Oct 13, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Oct 13, 2025

GuillaumeGomez deleted the rollup-i1zinjv branch October 13, 2025 15:27

This was referenced Oct 13, 2025

cg_llvm: More preparation for moving FFI bindings to rustc_llvm #147430

Merged

[crater only] complain about uninhabited types being ignored in repr(transparent) #147589

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests#147629

Rollup of 6 pull requests#147629
bors merged 21 commits intorust-lang:masterfrom
GuillaumeGomez:rollup-i1zinjv

GuillaumeGomez commented Oct 13, 2025 •

edited by rustbot

Loading

Uh oh!

GuillaumeGomez commented Oct 13, 2025

Uh oh!

bors commented Oct 13, 2025

Uh oh!

bors commented Oct 13, 2025

Uh oh!

bors commented Oct 13, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Stage 0

Uh oh!

rust-timer commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

GuillaumeGomez commented Oct 13, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented Oct 13, 2025

Uh oh!

bors commented Oct 13, 2025

Uh oh!

bors commented Oct 13, 2025

Uh oh!

bors commented Oct 13, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Test differences

Stage 0

Job duration changes

Uh oh!

rust-timer commented Oct 13, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

GuillaumeGomez commented Oct 13, 2025 •

edited by rustbot

Loading