Rollup of 12 pull requests by Zalathar · Pull Request #147662 · rust-lang/rust

Zalathar · 2025-10-14T05:31:04Z

Successful merges:

Enable u64 limbs in core::num::bignum #146277 (Enable u64 limbs in core::num::bignum)
constify basic Clone impls #146976 (constify basic Clone impls)
Do two passes of handle_opaque_type_uses_next #147249 (Do two passes of handle_opaque_type_uses_next)
fix 2 search graph bugs #147266 (fix 2 search graph bugs)
proc_macro cleanups (3/N) #147497 (proc_macro cleanups (3/N))
Suppress unused_parens for labeled break #147546 (Suppress unused_parens for labeled break)
Fix ICE for never pattern as closure parameters #147548 (Fix ICE for never pattern as closure parameters)
std: implement pal::os::exit for VEXos #147594 (std: implement pal::os::exit for VEXos)
Adjust the Arm targets in CI to reflect latest changes #147596 (Adjust the Arm targets in CI to reflect latest changes)
GVN: Invalidate derefs at loop headers #147607 (GVN: Invalidate derefs at loop headers)
Avoid redundant UB check in RangeFrom slice indexing #147620 (Avoid redundant UB check in RangeFrom slice indexing)
Hide vendoring and copyright in GHA group #147647 (Hide vendoring and copyright in GHA group)

r? @ghost
@rustbot modify labels: rollup

we should not get the certainty from the current result of the provisional cache entry

…pre-fallback where we equate hidden types but do not report errors

…ve the assert in favor over a comment, and change to & for &mut

* Adds armv7a-none-eabihf (rust-lang#146522) * Adds armv8r-none-eabihf (rust-lang#146520) * Drops armeb*-none-* (rust-lang#146523)

Not all ARMv7-A CPUs have a double-precision FPU. So adjust the CFLAGS from `+vfpv3` (which assumes 32 double-precision registers) to `+fp` (which only assumes 16 double-precision registers).

These two steps are currently the most verbose steps in a dist-linux build, which makes it harder to find more interesting parts. Hide them in a group like most things.

…inimizations. Update comment and test.

Enable `u64` limbs in `core::num::bignum` Since `u128` is stable now, I guess, we can safely add this, not sure if this requires tests or anything cc rust-lang#137887

constify basic Clone impls

Do two passes of `handle_opaque_type_uses_next` Fixes rust-lang/trait-system-refactor-initiative#240 Also did a little bit of cleanup, can squash the commits if decided. r? lcnr

fix 2 search graph bugs wooooooooops, i should really run the fuzzer even when not changing the structure of the search graph as a whole :3 fixes the `ml-kem` ICE in the next-solver crater run r? ````@BoxyUwU````

…etrochenkov `proc_macro` cleanups (3/N) Followup to rust-lang#147386, which removed the old `Decode` trait. Can be reviewed commit by commit.

…147542, r=jackh726 Suppress unused_parens for labeled break Fixes rust-lang#147542

…ets, r=Mark-Simulacrum Adjust the Arm targets in CI to reflect latest changes * Adds build of `armv7a-none-eabihf` (rust-lang#146522) * Adds build of `armv8r-none-eabihf` (rust-lang#146520) * Drops build of `armeb*-none-*` (rust-lang#146523) I wasn't sure why `armv7a-none-eabihf` was missing from the build-manifest program, but `armv8r-none-eabihf` was there, as they were both Tier 3 targets up until very recently. So, I added it, but that might be wrong.

GVN: Invalidate derefs at loop headers Fix a miscompiled case I found when re-reviewing rust-lang#132527. r? cjgillot r? oli-obk

…ottmcm Avoid redundant UB check in RangeFrom slice indexing I noticed this while picking through the IR we generate for rust-lang#134938. I think we just forgot to apply this trick to `RangeFrom`?

…thar Hide vendoring and copyright in GHA group These two steps are currently the most verbose steps in a dist-linux build, which makes it harder to find more interesting parts. Hide them in a group like most things. For example, see https://github.com/rust-lang/rust/actions/runs/18462295959/job/52596384752

Zalathar · 2025-10-14T05:32:01Z

Rollup of everything; I don't think it's worth making a subset of #147659.

@bors r+ rollup=never p=5

bors · 2025-10-14T05:32:04Z

📌 Commit 0f6fe91 has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-10-14T12:32:35Z

⌛ Testing commit 0f6fe91 with merge e100792...

bors · 2025-10-14T15:42:29Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing e100792 to master...

github-actions · 2025-10-14T15:45:38Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2f7620a (parent) -> e100792 (this PR)

Test differences

Show 100 test diffs

Stage 1

[mir-opt] tests/mir-opt/gvn_loop.rs: [missing] -> pass (J1)
[ui] tests/ui/lint/unused/break-label-with-parens-147542.rs: [missing] -> pass (J1)
[ui] tests/ui/mir/gvn-loop-miscompile.rs: [missing] -> pass (J1)
[ui] tests/ui/never_type/never-pattern-as-closure-param-141592.rs: [missing] -> pass (J1)
[ui] tests/ui/traits/next-solver/cycles/forced_ambiguity-use-head-maybe-cause.rs: [missing] -> pass (J1)
[ui] tests/ui/traits/next-solver/opaques/hidden-types-equate-before-fallback.rs#current: [missing] -> pass (J1)
[ui] tests/ui/traits/next-solver/opaques/hidden-types-equate-before-fallback.rs#next: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/lint/unused/break-label-with-parens-147542.rs: [missing] -> pass (J0)
[ui] tests/ui/mir/gvn-loop-miscompile.rs: [missing] -> pass (J0)
[ui] tests/ui/never_type/never-pattern-as-closure-param-141592.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/next-solver/cycles/forced_ambiguity-use-head-maybe-cause.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/next-solver/opaques/hidden-types-equate-before-fallback.rs#current: [missing] -> pass (J0)
[ui] tests/ui/traits/next-solver/opaques/hidden-types-equate-before-fallback.rs#next: [missing] -> pass (J0)
[mir-opt] tests/mir-opt/gvn_loop.rs: [missing] -> pass (J2)

Additionally, 86 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e100792918c8bd9e0cb830f96fc9b171e8892fa1 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 4017.0s -> 2962.6s (-26.2%)
dist-x86_64-apple: 6970.7s -> 8574.2s (23.0%)
aarch64-apple: 8761.6s -> 10523.4s (20.1%)
dist-aarch64-apple: 7065.3s -> 8429.7s (19.3%)
test-various: 4235.0s -> 4848.0s (14.5%)
aarch64-msvc-1: 6973.3s -> 7862.6s (12.8%)
dist-aarch64-windows-gnullvm: 4605.1s -> 5163.8s (12.1%)
i686-msvc-2: 7397.9s -> 8098.1s (9.5%)
dist-i686-mingw: 8939.0s -> 9733.1s (8.9%)
aarch64-gnu-llvm-20-1: 3196.9s -> 3474.5s (8.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-14T15:46:01Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#146277	Enable `u64` limbs in `core::num::bignum`	`05a01f4af8172edefab7295924b3e57c6943e145` (link)
#146976	constify basic Clone impls	`27e8c7f9910af7086a73aac8f3c183eff6807581` (link)
#147249	Do two passes of `handle_opaque_type_uses_next`	`d2b54b83ba681b61c7329d1180986eedb030e6da` (link)
#147266	fix 2 search graph bugs	`2db323a53f26fb73adabd845c65ac8fe53193012` (link)
#147497	`proc_macro` cleanups (3/N)	`b83bae4cf8ba54ad2574fea597e9efbde0ceb3b2` (link)
#147546	Suppress unused_parens for labeled break	`dabe66a12ead40171cad82d8a34e47a69877fb96` (link)
#147548	Fix ICE for never pattern as closure parameters	`d5e3a2098b8517f962be062fe4f9d5fd07bffb94` (link)
#147594	std: implement `pal::os::exit` for VEXos	`bea97e2c98323adb5ee307031f94e64ed5d3cbb6` (link)
#147596	Adjust the Arm targets in CI to reflect latest changes	`3f7bfed2e47d41839976eafa025edaca70170ca5` (link)
#147607	GVN: Invalidate derefs at loop headers	`173ae98d9bd3b77da8abe647339a968fb6adaef2` (link)
#147620	Avoid redundant UB check in RangeFrom slice indexing	`55b1ddf8a07dfa01e6011deeb6d306ba96d35991` (link)
#147647	Hide vendoring and copyright in GHA group	`10e9340eaea24c440c3d31302faff7b1c5f0429e` (link)

previous master: 2f7620a5cc

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-10-14T16:54:23Z

Finished benchmarking commit (e100792): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.3%, 0.5%]	2
Regressions ❌ (secondary)	0.2%	[0.0%, 0.5%]	3
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.2%]	2
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	3
All ❌✅ (primary)	0.1%	[-0.4%, 0.5%]	4

Max RSS (memory usage)

Results (primary 2.5%, secondary -3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.6%	[2.9%, 6.3%]	2
Regressions ❌ (secondary)	1.7%	[1.2%, 2.2%]	2
Improvements ✅ (primary)	-1.7%	[-1.7%, -1.7%]	1
Improvements ✅ (secondary)	-4.5%	[-5.8%, -2.1%]	12
All ❌✅ (primary)	2.5%	[-1.7%, 6.3%]	3

Cycles

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.1%, 3.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.8%, -1.4%]	3
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.1%, secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.6%]	9
Regressions ❌ (secondary)	1.7%	[0.1%, 3.2%]	2
Improvements ✅ (primary)	-0.2%	[-0.6%, -0.0%]	38
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.0%]	55
All ❌✅ (primary)	-0.1%	[-0.6%, 0.6%]	47

Bootstrap: 475.635s -> 473.51s (-0.45%)
Artifact size: 388.48 MiB -> 388.11 MiB (-0.10%)

saethlin · 2025-10-15T01:06:08Z

The perf change is from #147620 (comment)

Rollup of 12 pull requests Successful merges: - rust-lang#146277 (Enable `u64` limbs in `core::num::bignum`) - rust-lang#146976 (constify basic Clone impls) - rust-lang#147249 (Do two passes of `handle_opaque_type_uses_next`) - rust-lang#147266 (fix 2 search graph bugs) - rust-lang#147497 (`proc_macro` cleanups (3/N)) - rust-lang#147546 (Suppress unused_parens for labeled break) - rust-lang#147548 (Fix ICE for never pattern as closure parameters) - rust-lang#147594 (std: implement `pal::os::exit` for VEXos) - rust-lang#147596 (Adjust the Arm targets in CI to reflect latest changes) - rust-lang#147607 (GVN: Invalidate derefs at loop headers) - rust-lang#147620 (Avoid redundant UB check in RangeFrom slice indexing) - rust-lang#147647 (Hide vendoring and copyright in GHA group) r? `@ghost` `@rustbot` modify labels: rollup

Kivooeo and others added 30 commits September 6, 2025 15:45

uncommented u64 impl

13ed4a3

check for empty heads after adding parent

1e772f9

fix RebaseReason::Ambiguity

36283bc

we should not get the certainty from the current result of the provisional cache entry

When computing opaque types in the next solver, take an initial pass …

db3c9b6

…pre-fallback where we equate hidden types but do not report errors

Cleanup opaque_type computation a bit

9a5cef1

Remove UsageKind::HasError

c6c58e3

Merge match and if

a3fbae5

Fix comment, change first_pass to error_on_missing_defining_use, remo…

283ad66

…ve the assert in favor over a comment, and change to & for &mut

Remove unneeded get_hidden_type

8b17827

constify basic Clone impls

04c2724

run zero-size assertion in const {}

0355358

inline constants in generated enum Encode impls

e3d2016

Fix ice 141592, change diverge assertion to struct error with delay

ca8020a

rename DecodeMut to Decode

6a12470

vexos: implement pal::os::exit

04da682

Adjust the Arm targets in CI to reflect latest changes

cc96d3f

* Adds armv7a-none-eabihf (rust-lang#146522) * Adds armv8r-none-eabihf (rust-lang#146520) * Drops armeb*-none-* (rust-lang#146523)

Add miscompiled test cases

64c023b

Add CFLAGS for armv8r-none-eabihf

9b91c3e

Change armv7a-none-eabihf CFLAGS to assume only single-precision FPU

fef16d2

Not all ARMv7-A CPUs have a double-precision FPU. So adjust the CFLAGS from `+vfpv3` (which assumes 32 double-precision registers) to `+fp` (which only assumes 16 double-precision registers).

Avoid redundant UB check in RangeFrom slice indexing

4f1b945

Hide vendoring and copyright in GHA group

11977b2

These two steps are currently the most verbose steps in a dist-linux build, which makes it harder to find more interesting parts. Hide them in a group like most things.

Review comments. Move resolve_vars_if_possible into fn and add test m…

d51f09e

…inimizations. Update comment and test.

GVN: Invalidate derefs at loop headers

2048b9c

Suppress unused_parens for labeled break

d658bcf

Rollup merge of rust-lang#146277 - Kivooeo:u64-unlock, r=scottmcm

6e07b25

Enable `u64` limbs in `core::num::bignum` Since `u128` is stable now, I guess, we can safely add this, not sure if this requires tests or anything cc rust-lang#137887

Rollup merge of rust-lang#146976 - npmccallum:clone, r=scottmcm

ed290fd

constify basic Clone impls

Rollup merge of rust-lang#147249 - jackh726:opaque-type-fallback, r=lcnr

3a80521

Do two passes of `handle_opaque_type_uses_next` Fixes rust-lang/trait-system-refactor-initiative#240 Also did a little bit of cleanup, can squash the commits if decided. r? lcnr

Rollup merge of rust-lang#147266 - lcnr:fix-search_graph, r=BoxyUwU

4321adf

fix 2 search graph bugs wooooooooops, i should really run the fuzzer even when not changing the structure of the search graph as a whole :3 fixes the `ml-kem` ICE in the next-solver crater run r? ````@BoxyUwU````

Rollup merge of rust-lang#147497 - cyrgani:proc-macro-cleanups-3, r=p…

428be2f

…etrochenkov `proc_macro` cleanups (3/N) Followup to rust-lang#147386, which removed the old `Decode` trait. Can be reviewed commit by commit.

Rollup merge of rust-lang#147546 - chenyukang:yukang-fix-break-label-…

a49246a

…147542, r=jackh726 Suppress unused_parens for labeled break Fixes rust-lang#147542

Zalathar added 4 commits October 14, 2025 16:31

Rollup merge of rust-lang#147607 - dianqk:gvn-deref-loop, r=cjgillot

4fc3a05

GVN: Invalidate derefs at loop headers Fix a miscompiled case I found when re-reviewing rust-lang#132527. r? cjgillot r? oli-obk

Rollup merge of rust-lang#147620 - saethlin:RangeFrom-noubcheck, r=sc…

4a67c01

…ottmcm Avoid redundant UB check in RangeFrom slice indexing I noticed this while picking through the IR we generate for rust-lang#134938. I think we just forgot to apply this trick to `RangeFrom`?

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 14, 2025

bors merged commit e100792 into rust-lang:master Oct 14, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Oct 14, 2025

rustbot added the perf-regression Performance regression. label Oct 14, 2025

Zalathar deleted the rollup-j8ci0f2 branch October 14, 2025 21:49

Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Oct 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 12 pull requests#147662

Rollup of 12 pull requests#147662
bors merged 36 commits intorust-lang:masterfrom
Zalathar:rollup-j8ci0f2

Zalathar commented Oct 14, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Oct 14, 2025

Uh oh!

bors commented Oct 14, 2025

Uh oh!

bors commented Oct 14, 2025

Uh oh!

bors commented Oct 14, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Oct 14, 2025

Uh oh!

rust-timer commented Oct 14, 2025

Uh oh!

saethlin commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

Uh oh!

Conversation

Zalathar commented Oct 14, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Oct 14, 2025

Uh oh!

bors commented Oct 14, 2025

Uh oh!

bors commented Oct 14, 2025

Uh oh!

bors commented Oct 14, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Oct 14, 2025

Uh oh!

rust-timer commented Oct 14, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

saethlin commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

Zalathar commented Oct 14, 2025 •

edited by rustbot

Loading