Do not enable LLD if we don't build host code for targets that opt into it#147698
Do not enable LLD if we don't build host code for targets that opt into it#147698bors merged 1 commit intorust-lang:masterfrom
Conversation
|
This PR modifies If appropriate, please update |
|
|
This comment was marked as outdated.
This comment was marked as outdated.
|
@bors r+ rollup=never |
|
Validated that this change fixes the issue in our Arm64EC validation pipeline: we no longer need to set |
Do not enable LLD if we don't build host code for targets that opt into it Should fix the problem mentioned in #147626 (comment). r? `@jieyouxu`
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
|
@bors retry Spurious. |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 33cab8c (parent) -> c6efb90 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard c6efb9019b3169fc672248339dbbf13e6a134de3 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (c6efb90): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.834s -> 472.659s (-0.25%) |
Should fix the problem mentioned in #147626 (comment).
r? @jieyouxu