constify comparison traits on slices#147790
Open
npmccallum wants to merge 2 commits intorust-lang:mainfrom
Open
constify comparison traits on slices#147790npmccallum wants to merge 2 commits intorust-lang:mainfrom
npmccallum wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
oli-obk
requested changes
Oct 19, 2025
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Oct 23, 2025
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Oct 25, 2025
constify comparison traits on slices r? oli-obk Tracking issue rust-lang#143800
bors
added a commit
that referenced
this pull request
Oct 25, 2025
Rollup of 6 pull requests Successful merges: - #147406 (Remove needs-asm-support directive in tests with explicit targets) - #147790 (constify comparison traits on slices) - #148056 (refactor(rustdoc): Remove redundant langstr checks) - #148065 (compiletest: Add concrete examples for some config/test path fields) - #148072 (Fix compiling `CondVar::wait_timeout` on 32-bit Apple platforms) - #148073 (test(frontmatter): Rename tests to make coverage more obvious) r? `@ghost` `@rustbot` modify labels: rollup
Member
bors
added
S-waiting-on-author
Contributor
|
Changing slices PartialEq implementation breaks codegen tests, I've encountered this in the past |
Contributor
|
☔ The latest upstream changes (presumably #150945) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? oli-obk
Tracking issue #143800