Store chunk_domain_size explicitly in Chunk.#147802
Store chunk_domain_size explicitly in Chunk.#147802nnethercote wants to merge 1 commit intorust-lang:mainfrom
chunk_domain_size explicitly in Chunk.#147802Conversation
Currently we compute it on demand, but it's a little simpler and slightly faster to store it.
be864b6 to
3f23715
Compare
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Store `chunk_domain_size` explicitly in `Chunk`.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (f2dee36): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 3.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 474.3s -> 474.199s (-0.02%) |
|
Haha I removed it 2 months ago... #145480 |
Currently we compute it on demand, but it's a little simpler and slightly faster to store it.
r? @ghost