Rollup of 4 pull requests by matthiaskrgr · Pull Request #147884 · rust-lang/rust

matthiaskrgr · 2025-10-19T12:04:56Z

Successful merges:

Refactor move analysis subpath representation #147575 (Refactor move analysis subpath representation)
Parse const unsafe trait properly #147864 (Parse const unsafe trait properly)
MirPatch: Simplify new_local. #147868 (MirPatch: Simplify new_local.)
comments for deduce_param_attrs #147873 (comments for deduce_param_attrs)

r? @ghost
@rustbot modify labels: rollup

Previously, this was greedily stolen by the `fn` parsing logic.

Refactor move analysis subpath representation Follow up to rust-lang#147055 This PR does two things: 1. Document/validate move analysis's assumptions about `Subslice` projections 2. Decouple move paths from `ProjectionElem`, using a new enum `MoveSubPath` instead - This would be needed eventually when `ProjectionElem::Deref` is removed I wanted to do even more abstraction, making `MovePathLookup::find` return an iterator to remove the special handling of subslices in borrowck, but that regressed diagnostics and just wasn't worth the complexity.

… r=fmease Parse `const unsafe trait` properly Previously, this was greedily stolen by the `fn` parsing logic. r? project-const-traits

MirPatch: Simplify new_local. Small simplification.

…asko comments for deduce_param_attrs Cc `@saethlin` since IIRC you experimented with codegen doing post-mono MIR ops? That seems to be in conflict with this pass. Cc `@tmiasko` r? `@scottmcm`

matthiaskrgr · 2025-10-19T12:05:08Z

@bors r+ rollup=never p=5

bors · 2025-10-19T12:05:12Z

📌 Commit 362c9e2 has been approved by matthiaskrgr

It is now in the queue for this repository.

Rollup of 4 pull requests Successful merges: - #147575 (Refactor move analysis subpath representation) - #147864 (Parse `const unsafe trait` properly) - #147868 (MirPatch: Simplify new_local.) - #147873 (comments for deduce_param_attrs) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-10-19T15:05:29Z

⌛ Testing commit 362c9e2 with merge b4f28c6...

rust-log-analyzer · 2025-10-19T17:04:13Z

The job x86_64-msvc-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


error: test failed, to rerun pass `-p std --test sync`
Bootstrap failed while executing `test --stage 2 --skip=compiler --skip=src`
Build completed unsuccessfully in 1:51:44
make: *** [Makefile:112: ci-msvc-py] Error 1
  local time: Sun Oct 19 17:03:57 CUT 2025
  network time: Sun, 19 Oct 2025 17:03:57 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

bors · 2025-10-19T17:04:46Z

💔 Test failed - checks-actions

matthiaskrgr · 2025-10-19T17:16:49Z

@bors retry
#147885

bors · 2025-10-19T17:18:30Z

⌛ Testing commit 362c9e2 with merge 4ddbb60...

bors · 2025-10-19T20:28:59Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 4ddbb60 to master...

rust-timer · 2025-10-19T20:30:10Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#147575	Refactor move analysis subpath representation	`a14017dafea20e672b499728eb0d8d08134ef176` (link)
#147864	Parse `const unsafe trait` properly	`cc0071a62edf32b61ee32094c472ab23820983d1` (link)
#147868	MirPatch: Simplify new_local.	`749cc9d793d0dbfd8460a7ef2f7c0b11b0464bc3` (link)
#147873	comments for deduce_param_attrs	`1be004b6b70de1bf33b42bb5b252ad28588de7f0` (link)

previous master: c6efb9019b

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-10-19T20:32:02Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c6efb90 (parent) -> 4ddbb60 (this PR)

Test differences

Show 50 test diffs

Stage 1

[ui] tests/ui/traits/const-traits/parse-const-unsafe-trait.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/traits/const-traits/parse-const-unsafe-trait.rs: [missing] -> pass (J0)

Additionally, 48 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4ddbb6051271237f4192333e06b8129148995eef --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-apple: 7245.5s -> 5659.3s (-21.9%)
pr-check-1: 1832.3s -> 1491.8s (-18.6%)
x86_64-gnu-distcheck: 6929.1s -> 6263.6s (-9.6%)
aarch64-msvc-2: 5324.9s -> 4845.8s (-9.0%)
dist-loongarch64-linux: 5243.9s -> 5669.4s (8.1%)
dist-ohos-armv7: 4391.3s -> 4035.6s (-8.1%)
dist-loongarch64-musl: 5417.6s -> 4982.2s (-8.0%)
armhf-gnu: 5317.4s -> 4894.4s (-8.0%)
dist-aarch64-windows-gnullvm: 4750.5s -> 4374.7s (-7.9%)
dist-various-1: 4226.2s -> 3892.7s (-7.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-19T21:39:10Z

Finished benchmarking commit (4ddbb60): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.2%]	2
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.1%]	5
All ❌✅ (primary)	-0.3%	[-0.3%, -0.2%]	2

Max RSS (memory usage)

Results (primary 2.0%, secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	4.4%	[2.9%, 5.8%]	10
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-3.5%, -2.2%]	5
All ❌✅ (primary)	2.0%	[2.0%, 2.0%]	1

Cycles

Results (primary -2.1%, secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.3%	[2.3%, 9.7%]	5
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-5.1%	[-9.1%, -2.3%]	7
All ❌✅ (primary)	-2.1%	[-2.1%, -2.1%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.659s -> 471.841s (-0.17%)
Artifact size: 390.57 MiB -> 388.67 MiB (-0.49%)

beepster4096 and others added 12 commits October 11, 2025 22:49

sort visit_projection_elem by definition order

8f430d6

document unstated condition of Subslice and validate more

3e94dd7

use abstraction over projectionelem in move analysis

fb1c90a

update movepath docs

b151a5e

make move unwrap_binder! a move subpath

bce7f71

Parse const unsafe trait properly

b145213

Previously, this was greedily stolen by the `fn` parsing logic.

Simplify new_local.

a1e42f9

comments for deduce_param_attrs

82f6c60

Rollup merge of rust-lang#147864 - fee1-dead-contrib:consttraitparse,…

467429f

… r=fmease Parse `const unsafe trait` properly Previously, this was greedily stolen by the `fn` parsing logic. r? project-const-traits

Rollup merge of rust-lang#147868 - cjgillot:patch-local, r=saethlin

3f1d4fb

MirPatch: Simplify new_local. Small simplification.

Rollup merge of rust-lang#147873 - RalfJung:deduce_param_attrs, r=tmi…

362c9e2

…asko comments for deduce_param_attrs Cc `@saethlin` since IIRC you experimented with codegen doing post-mono MIR ops? That seems to be in conflict with this pass. Cc `@tmiasko` r? `@scottmcm`

rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 19, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 19, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2025

matthiaskrgr mentioned this pull request Oct 19, 2025

Refactor move analysis subpath representation #147575

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 19, 2025

bors merged commit 4ddbb60 into rust-lang:master Oct 19, 2025
12 checks passed

rustbot added this to the 1.92.0 milestone Oct 19, 2025

bors mentioned this pull request Oct 19, 2025

Deduce captures(none) for a return place and parameters #147890

Merged

Uh oh!

Conversation

matthiaskrgr commented Oct 19, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Oct 19, 2025

Uh oh!

bors commented Oct 19, 2025

Uh oh!

bors commented Oct 19, 2025

Uh oh!

rust-log-analyzer commented Oct 19, 2025

Uh oh!

bors commented Oct 19, 2025

Uh oh!

matthiaskrgr commented Oct 19, 2025

Uh oh!

bors commented Oct 19, 2025

Uh oh!

bors commented Oct 19, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 19, 2025

Uh oh!

github-actions bot commented Oct 19, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Oct 19, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

matthiaskrgr commented Oct 19, 2025 •

edited by rustbot

Loading