Add check for `+=` typo in let chains by Kivooeo · Pull Request #147951 · rust-lang/rust

Kivooeo · 2025-10-21T22:43:00Z

it does affect only cases where variable exist in scope, because if the variable is not exist in scope, the suggestion will not make any sense

I wanted to add suggestion for case where variable does not in scope to fix y += 1 to let y = 1 but I guess it's too much (not too much work, but too much wild predict of what user wants)? if it's good addition in your opinion I can add this in follow up

in other things I guess impl is pretty much self-explanatory, if you see there is some possibilities to improve code or/and some edge-cases that I could overlooked feel free to tell about it

ah, also about why I think this change is good and why I originally took it, so it seems to me that this is possible to make this typo (I explained this in comment a little), like, both + and = is the same button (in most of layouts) and for this reasons I didn't added something like -= it seems more harder to make this typo

r? diagnostics

Kivooeo · 2025-10-21T22:48:08Z

(info for assigned reviewer or whoever wants pick this up for review, if you found that this is in good state as it, and there is nothing crucial that needed to be added or improved, and you want to rollup this, please, before doing so run bors try on aarch64-msvc-1, i have some kind of paranoia after this #147421 (comment), thanks)

aklaiber · 2025-10-23T05:00:11Z

A suggestion to improve readability: Add a layer of abstraction to this 535-line check_overloaded_binop method.

#64297

Kivooeo · 2025-10-23T09:43:44Z

@aklaiber I'm quite unsure, but in my opinion this is a little outside the scope of the current PR

compiler/rustc_hir_typeck/src/expr.rs

compiler/rustc_hir_typeck/src/op.rs

compiler/rustc_hir_typeck/src/expr.rs

tests/ui/parser/let-chains-assign-add-incorrect.rs

compiler/rustc_hir_typeck/src/errors.rs

tests/ui/parser/let-chains-assign-add-incorrect.stderr

compiler/rustc_hir_typeck/src/expr.rs

Kivooeo · 2025-10-31T18:24:58Z

I will squash this commit before merge, just to make review easier for now

davidtwco · 2025-11-03T16:40:55Z

I don't mind the extra commit so we can save another cycle of back and forth

@bors r+ rollup

bors · 2025-11-03T16:40:59Z

📌 Commit d472d91 has been approved by davidtwco

It is now in the queue for this repository.

…avidtwco Add check for `+=` typo in let chains Fixes rust-lang#147664 it does affect only cases where variable exist in scope, because if the variable is not exist in scope, the suggestion will not make any sense I wanted to add suggestion for case where variable does not in scope to fix `y += 1` to `let y = 1` but I guess it's too much (not too much work, but too much wild predict of what user wants)? if it's good addition in your opinion I can add this in follow up in other things I guess impl is pretty much self-explanatory, if you see there is some possibilities to improve code or/and some _edge-cases_ that I could overlooked feel free to tell about it ah, also about why I think this change is good and why I originally took it, so it seems to me that this is possible to make this typo (I explained this in comment a little), like, both `+` and `=` is the same button (in most of layouts) and for this reasons I didn't added something like `-=` it seems more harder to make this typo r? diagnostics

Rollup of 7 pull requests Successful merges: - #147141 (Suggest making binding `mut` on `&mut` reborrow) - #147945 (Port `cfg!()` macro to the new attribute parsing system ) - #147951 (Add check for `+=` typo in let chains) - #148004 (fix: Only special case single line item attribute suggestions) - #148264 (reflect that type and const parameter can be intermixed) - #148363 (Fix `wasm_import_module` attribute cross-crate) - #148447 (Tweak E0401) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147951 - Kivooeo:plus-equal-let-chains, r=davidtwco Add check for `+=` typo in let chains Fixes #147664 it does affect only cases where variable exist in scope, because if the variable is not exist in scope, the suggestion will not make any sense I wanted to add suggestion for case where variable does not in scope to fix `y += 1` to `let y = 1` but I guess it's too much (not too much work, but too much wild predict of what user wants)? if it's good addition in your opinion I can add this in follow up in other things I guess impl is pretty much self-explanatory, if you see there is some possibilities to improve code or/and some _edge-cases_ that I could overlooked feel free to tell about it ah, also about why I think this change is good and why I originally took it, so it seems to me that this is possible to make this typo (I explained this in comment a little), like, both `+` and `=` is the same button (in most of layouts) and for this reasons I didn't added something like `-=` it seems more harder to make this typo r? diagnostics

rustbot assigned davidtwco Oct 21, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 21, 2025

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the plus-equal-let-chains branch from 96dba30 to e4d765b Compare October 21, 2025 22:51

davidtwco requested changes Oct 25, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2025

add check for typo in let chains

806b443

rust-cloud-vms bot force-pushed the plus-equal-let-chains branch from e4d765b to 806b443 Compare October 25, 2025 13:27

Kivooeo commented Oct 25, 2025

View reviewed changes

compiler/rustc_hir_typeck/src/expr.rs Outdated Show resolved Hide resolved

estebank approved these changes Oct 31, 2025

View reviewed changes

address review

d472d91

davidtwco approved these changes Nov 3, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 3, 2025

GuillaumeGomez mentioned this pull request Nov 3, 2025

Rollup of 8 pull requests #148454

Closed

matthiaskrgr mentioned this pull request Nov 3, 2025

Rollup of 7 pull requests #148456

Merged

bors merged commit 3de72f6 into rust-lang:master Nov 4, 2025
11 checks passed

rustbot added this to the 1.93.0 milestone Nov 4, 2025

Uh oh!

Conversation

Kivooeo commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kivooeo commented Oct 21, 2025

Uh oh!

This comment has been minimized.

aklaiber commented Oct 23, 2025

Uh oh!

Kivooeo commented Oct 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kivooeo commented Oct 31, 2025

Uh oh!

davidtwco commented Nov 3, 2025

Uh oh!

bors commented Nov 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Kivooeo commented Oct 21, 2025 •

edited

Loading