Rollup of 3 pull requests by jhpratt · Pull Request #148014 · rust-lang/rust

jhpratt · 2025-10-23T05:22:07Z

Successful merges:

Add String::replace_first and String::replace_last #134316 (Add String::replace_first and String::replace_last)
Retire ast::TyAliasWhereClauses. #147713 (Retire ast::TyAliasWhereClauses.)
Revert constification of AsRef for Cow due to inference failure #148011 (Revert constification of AsRef for Cow due to inference failure )

r? @ghost
@rustbot modify labels: rollup

Rebased and modified by zachs18. Co-authored-by: zachs18 <8355914+zachs18@users.noreply.github.com>

…base, r=joshtriplett Add `String::replace_first` and `String::replace_last` Rebase of rust-lang#97977 (cc `@WilliamVenner)` > Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows. The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs. ACP: rust-lang/libs-team#506

Retire ast::TyAliasWhereClauses. `ast::TyAliasWhereClauses` is a tentative to avoid forgetting predicates when manipulating the AST. It is incompatible with `cfg` attributes on where clauses. This PR uses a regular `WhereClause` for the "second" clause. Fixes rust-lang#138010 cc rust-lang#138037

…r=oli-obk Revert constification of `AsRef for Cow` due to inference failure Reported issue: rust-lang#147964 Original PR: rust-lang#145279 `const AsRef` tracking issue: rust-lang#143773 Should have additional crater run to verify this fixes the issue.

jhpratt · 2025-10-23T05:22:17Z

@bors r+ rollup=never p=3

bors · 2025-10-23T05:22:20Z

📌 Commit 5d55418 has been approved by jhpratt

It is now in the queue for this repository.

bors · 2025-10-23T08:17:08Z

⌛ Testing commit 5d55418 with merge 469357e...

bors · 2025-10-23T11:21:31Z

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 469357e to master...

rust-timer · 2025-10-23T11:22:25Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#134316	Add `String::replace_first` and `String::replace_last`	`b14dfec6484e1986bea1f06780eb440d3a73d5ff` (link)
#147713	Retire ast::TyAliasWhereClauses.	`a309d0136b09c891ab29627879b175579eccc297` (link)
#148011	Revert constification of `AsRef for Cow` due to inference f…	`6ae63b7059954ee4d7adec6ba973621b339ba3f9` (link)

previous master: 4b3ba5844e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-10-23T11:24:45Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4b3ba58 (parent) -> 469357e (this PR)

Test differences

Show 120 test diffs

Stage 1

string::test_replace_first: [missing] -> pass (J0)
string::test_replace_last: [missing] -> pass (J0)
[ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J3)
[ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J3)

Stage 2

[ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J1)
[ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J1)
string::test_replace_first: [missing] -> pass (J2)
string::test_replace_last: [missing] -> pass (J2)

Additionally, 112 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 469357eb48d1c1b583386785ed0f846b9e7e0904 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 6096.5s -> 8250.5s (35.3%)
dist-aarch64-apple: 5767.2s -> 7136.7s (23.7%)
pr-check-1: 1762.9s -> 1507.3s (-14.5%)
dist-various-2: 1967.1s -> 2189.1s (11.3%)
i686-msvc-1: 10440.6s -> 9428.9s (-9.7%)
pr-check-2: 2350.1s -> 2570.5s (9.4%)
dist-apple-various: 3467.7s -> 3766.1s (8.6%)
x86_64-gnu-llvm-20-2: 5960.0s -> 5460.8s (-8.4%)
aarch64-apple: 6923.8s -> 7469.2s (7.9%)
dist-aarch64-msvc: 6133.2s -> 5676.6s (-7.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-23T12:32:40Z

Finished benchmarking commit (469357e): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	1

Max RSS (memory usage)

Results (primary -0.4%, secondary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-2.1%, -1.1%]	2
Improvements ✅ (secondary)	-1.1%	[-1.1%, -1.1%]	1
All ❌✅ (primary)	-0.4%	[-2.1%, 2.0%]	3

Cycles

Results (primary 2.1%, secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.2%	[-3.9%, -2.5%]	2
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.933s -> 474.879s (-0.01%)
Artifact size: 390.48 MiB -> 390.43 MiB (-0.01%)

Rollup of 3 pull requests Successful merges: - rust-lang#134316 (Add `String::replace_first` and `String::replace_last`) - rust-lang#147713 (Retire ast::TyAliasWhereClauses.) - rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure ) r? `@ghost` `@rustbot` modify labels: rollup

WilliamVenner and others added 6 commits October 21, 2025 16:11

Add String::replace_first and String::replace_last

8ed7fca

Rebased and modified by zachs18. Co-authored-by: zachs18 <8355914+zachs18@users.noreply.github.com>

Revert inference failure from AsRef constification

cb7fb35

Retire ast::TyAliasWhereClauses.

15c91bf

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025

Zalathar mentioned this pull request Oct 23, 2025

Rollup of 2 pull requests #148022

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2025

bors merged commit 469357e into rust-lang:master Oct 23, 2025
12 checks passed

rustbot added this to the 1.92.0 milestone Oct 23, 2025

bors mentioned this pull request Oct 23, 2025

Stabilize vec_deque_pop_if #145992

Merged

jhpratt deleted the rollup-aglren3 branch October 23, 2025 14:28

github-actions bot mentioned this pull request Oct 30, 2025

Toolchain upgrade to nightly-2026-01-30 flux-rs/flux#1345

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 3 pull requests#148014

Rollup of 3 pull requests#148014
bors merged 6 commits intorust-lang:masterfrom
jhpratt:rollup-aglren3

jhpratt commented Oct 23, 2025 •

edited by rustbot

Loading

Uh oh!

jhpratt commented Oct 23, 2025

Uh oh!

bors commented Oct 23, 2025

Uh oh!

bors commented Oct 23, 2025

Uh oh!

bors commented Oct 23, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Oct 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

jhpratt commented Oct 23, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Oct 23, 2025

Uh oh!

bors commented Oct 23, 2025

Uh oh!

bors commented Oct 23, 2025

Uh oh!

bors commented Oct 23, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Oct 23, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jhpratt commented Oct 23, 2025 •

edited by rustbot

Loading