Skip to content

AliasRelate: don't discard constraints on overflow#148069

Draft
lcnr wants to merge 3 commits intorust-lang:mainfrom
lcnr:alias-relate-no-discard-constraints
Draft

AliasRelate: don't discard constraints on overflow#148069
lcnr wants to merge 3 commits intorust-lang:mainfrom
lcnr:alias-relate-no-discard-constraints

Conversation

@lcnr
Copy link
Contributor

@lcnr lcnr commented Oct 24, 2025

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 24, 2025
@bors
Copy link
Collaborator

bors commented Oct 26, 2025

☔ The latest upstream changes (presumably #148066) made this pull request unmergeable. Please resolve the merge conflicts.

jdonszelmann
jdonszelmann reviewed Nov 5, 2025
View reviewed changes
jdonszelmann
jdonszelmann reviewed Nov 5, 2025
View reviewed changes
jdonszelmann
jdonszelmann reviewed Nov 5, 2025
View reviewed changes
compiler/rustc_next_trait_solver/src/solve/eval_ctxt/mod.rs
// won't be a breaking change, so this is good enough for now.
return Ok(self.make_ambiguous_response_no_constraints(cause, opaque_types_jank));
match self.current_goal_kind {
CurrentGoalKind::AliasRelate | CurrentGoalKind::NormalizesTo => {}
Copy link
Contributor

@jdonszelmann jdonszelmann Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right so here you'd have previously discarded (since AliasRelate got CurrentGoalKind::Misc but now you take this top branch). I'm not 100% sure why you also go here for NormalizesTo. That'd have previously discarded.

Copy link
Contributor Author

@lcnr lcnr Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd have previously discarded.

they wouldn't have, because for NormalizesTo we use the shallow_certainty due to the above match (self.current_goal_kind, shallow_certainty). That's subtle though

Copy link
Contributor

@jdonszelmann jdonszelmann Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe document it?

Copy link
Contributor

@jdonszelmann jdonszelmann Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or somehow combine the two checks, such that all the ways in which we care about self.current_goal_kind are handled exhaustively. I'm not sure that ends up working though, could also turn out more confusing rather than less

Copy link
Contributor

@jdonszelmann jdonszelmann Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried: combining doesn't produce a nice check, maybe just document?

@jdonszelmann jdonszelmann force-pushed the alias-relate-no-discard-constraints branch from 3620c77 to eaf4dbd Compare November 5, 2025 11:55
@jdonszelmann jdonszelmann mentioned this pull request Nov 6, 2025
Open
@bors
Copy link
Collaborator

bors commented Nov 9, 2025

☔ The latest upstream changes (presumably #148721) made this pull request unmergeable. Please resolve the merge conflicts.

@jdonszelmann jdonszelmann force-pushed the alias-relate-no-discard-constraints branch from eaf4dbd to a45a475 Compare November 10, 2025 11:07
@jdonszelmann
Copy link
Contributor

jdonszelmann commented Nov 10, 2025

(rebased, I was doing some rebasing anyway)

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Nov 10, 2025

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
  PR_CI_JOB: 1
  SKIP_SUBMODULES: src/gcc
  IMAGE: tidy
##[endgroup]
error: PRs changing the `nightly` channel should be sent to the `master` branch!
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Nov 10, 2025 •
edited
Loading

spurious?

PRs changing the nightly channel should be sent to the master branch!

we changed to main ofc

see: #148564

@bors
Copy link
Collaborator

bors commented Nov 27, 2025

☔ The latest upstream changes (presumably #149397) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdonszelmann jdonszelmann jdonszelmann left review comments

Assignees

@BoxyUwU BoxyUwU

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ml-kem-0.2.1 incorrect overflow error

6 participants

@lcnr @bors @jdonszelmann @rust-log-analyzer @BoxyUwU @rustbot