Conversation
rustbot
added
S-waiting-on-review
Collaborator
This comment was marked as resolved.
This comment was marked as resolved.
…th multi byte chars The issue cannot be reproduced with the former testcase of creating external crates because rust refuses to use "external crate 28_找出字符串中第一个匹配项的下标" because it is not a valid indentifier (starts with number, and contain non ascii chars) But still using 28_找出字符串中第一个匹配项的下标.rs as a filename is accepted by previous rustc releases So we consider it valid, and add an integration test for it to catch any regression on other code related to non ascii filenames. (cherry picked from commit c6acffe)
Member
Author
|
@bors r+ p=1 rollup=never |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 25, 2025
[beta] backports - Revert constification of `AsRef for Cow` due to inference failure #148011 - Revert constification of `Borrow` and `Deref for Cow` due to inference failure #148016 - Revert "fix: Filter suggestion parts that match existing code" #148043 - Revert "feat: implement `hash_map!` macro" #148049 - fix panic when rustc tries to reduce intermediate filenames len with utf8 #148018 r? cuviper
Collaborator
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
Author
|
No apparent error, just stopped while scraping licenses... @bors retry |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Oct 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsRef for Cowdue to inference failure Revert constification ofAsRef for Cowdue to inference failure #148011BorrowandDeref for Cowdue to inference failure Revert constification ofBorrowandDeref for Cowdue to inference failure #148016hash_map!macro" Revert "feat: implementhash_map!macro" #148049r? cuviper