Closed
Conversation
rustbot
added
A-testsuite
Collaborator
|
This PR modifies If appropriate, please update This PR modifies If appropriate, please update |
rustbot
added
S-waiting-on-review
Collaborator
yotamofek
reviewed
Nov 7, 2025
src/build_helper/src/npm.rs
Outdated
| cmd.arg("install"); | ||
|
|
||
| // ensure pnpm obeys the lockfile, and disable command shims so we can controll the nodejs version easily | ||
| //cmd.args(&["--config.extendNodePath=false", "--config.nodeLinker=hoisted", "--frozen-lockfile", "--shamefully-hoist"]); |
yotamofek
reviewed
Nov 7, 2025
src/build_helper/src/npm.rs
Outdated
| let exit_status = cmd.spawn()?.wait()?; | ||
| if !exit_status.success() { | ||
| eprintln!("npm install did not exit successfully"); | ||
| eprintln!("pnpm install did not exit successfully"); |
yotamofek
reviewed
Nov 7, 2025
src/build_helper/src/npm.rs
Outdated
| eprintln!("pnpm install did not exit successfully"); | ||
| return Err(io::Error::other(Box::<dyn Error + Send + Sync>::from(format!( | ||
| "npm install returned exit code {exit_status}" | ||
| "pnpm install returned exit code {exit_status}" |
yotamofek
reviewed
Nov 7, 2025
bootstrap.example.toml
Outdated
Comment on lines
315
to
320
| # The npm executable to use. Note that this is used for rustdoc-gui tests, | ||
| # otherwise this can be omitted. | ||
| # The pnpm executable to use. Note that this is used for rustdoc-gui tests and | ||
| # tidy js extra-checks, otherwise this can be omitted. | ||
| # | ||
| # Under Windows this should be `npm.cmd` or path to it (verified on nodejs v18.06), or | ||
| # Under Windows this should be `pnpm.cmd` or path to it (verified on nodejs v18.06), or | ||
| # error will be emitted. | ||
| #build.npm = "npm" | ||
| #build.pnpm = "pnpm" |
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
use-yarn
branch
from
dd4b4c9 to
b5bcc0e
Compare
Contributor
Author
|
Removed all the references to pnpm, I think tidy still references will also update change_tracker once CI is done. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
☔ The latest upstream changes (presumably #148721) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
do you have a link to more information about this? did it cause breakage that i could look at? |
Member
|
Essentially #t-infra > CI keeps failing because of npm error @ 💬 and this. If you depend on a git dependency with npm, it will unconditionally do |
bors
added a commit
that referenced
this pull request
Nov 17, 2025
Use `yarn` instead of `npm` for JS/TS dependencies Building on `@lolbinarycat` 's excellent work ( #148672 ). `npm` apparently has certain edge-cases where it doesn't actually respect the lockfile it's fed, which has led to at least one [CI breakage](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/CI.20keeps.20failing.20because.20of.20npm.20error/near/554420543). `yarn` seems to not suffer from those same issues, and also has a `--frozen` flag for its `install` command
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Nov 24, 2025
Use `yarn` instead of `npm` for JS/TS dependencies Building on `@lolbinarycat` 's excellent work ( rust-lang/rust#148672 ). `npm` apparently has certain edge-cases where it doesn't actually respect the lockfile it's fed, which has led to at least one [CI breakage](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/CI.20keeps.20failing.20because.20of.20npm.20error/near/554420543). `yarn` seems to not suffer from those same issues, and also has a `--frozen` flag for its `install` command
Contributor
Author
|
#148763 has been merged, closing this. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm lockfile implementation is nonfunctional