mgca: Finish implementation of #[type_const]#148716
Merged
bors merged 4 commits intorust-lang:masterfrom Nov 9, 2025
Merged
Conversation
Collaborator
|
|
rustbot
added
A-attributes
camelid
added
the
A-const-generics
BoxyUwU
removed
T-rustdoc
camelid
added
F-min_generic_const_args
This comment has been minimized.
This comment has been minimized.
29 tasks
camelid
force-pushed
the
finish-type_const
branch
from
cd05dad to
f9326cd
Compare
rustbot
added
T-clippy
camelid
force-pushed
the
finish-type_const
branch
from
f9326cd to
db2fbdb
Compare
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_passes/src/check_attr.rs This PR changes a file inside |
rustbot
added
S-waiting-on-review
BoxyUwU
removed
WG-trait-system-refactor
BoxyUwU
approved these changes
Nov 9, 2025
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 9, 2025
mgca: Finish implementation of `#[type_const]` tracking issue: rust-lang#132980 fixes rust-lang#140729 fixes rust-lang#140860 - **Fix `#[type_const]` attribute placement validation** - **Perform WF-checking on type_const RHS's** - **Check type_const type is ConstParamTy_ and that RHS matches it** - **Check that impls of `#[type_const]` consts also have the attr** r? `@BoxyUwU`
bors
added a commit
that referenced
this pull request
Nov 9, 2025
Rollup of 10 pull requests Successful merges: - #148608 (Add test for --test-builder success path) - #148683 (Remove `#[const_trait]`) - #148687 (std: use a non-poisoning `RwLock` for the panic hook) - #148709 (fix: disable self-contained linker when bootstrap-override-lld is set) - #148716 (mgca: Finish implementation of `#[type_const]`) - #148722 (Add Crystal Durham to .mailmap) - #148723 (bootstrap: Render doctest timing reports as text, not JSON) - #148724 (tidy: Don't bypass stderr output capture in unit tests) - #148734 (miri subtree update) - #148736 (Fix typo in unstable-book link) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 9, 2025
mgca: Finish implementation of `#[type_const]` tracking issue: rust-lang#132980 fixes rust-lang#140729 fixes rust-lang#140860 - **Fix `#[type_const]` attribute placement validation** - **Perform WF-checking on type_const RHS's** - **Check type_const type is ConstParamTy_ and that RHS matches it** - **Check that impls of `#[type_const]` consts also have the attr** r? ``@BoxyUwU``
bors
added a commit
that referenced
this pull request
Nov 9, 2025
Rollup of 10 pull requests Successful merges: - #148683 (Remove `#[const_trait]`) - #148687 (std: use a non-poisoning `RwLock` for the panic hook) - #148709 (fix: disable self-contained linker when bootstrap-override-lld is set) - #148716 (mgca: Finish implementation of `#[type_const]`) - #148722 (Add Crystal Durham to .mailmap) - #148723 (bootstrap: Render doctest timing reports as text, not JSON) - #148724 (tidy: Don't bypass stderr output capture in unit tests) - #148734 (miri subtree update) - #148736 (Fix typo in unstable-book link) - #148744 (Add myself(chenyukang) to the review rotation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 9, 2025
Rollup merge of #148716 - camelid:finish-type_const, r=BoxyUwU mgca: Finish implementation of `#[type_const]` tracking issue: #132980 fixes #140729 fixes #140860 - **Fix `#[type_const]` attribute placement validation** - **Perform WF-checking on type_const RHS's** - **Check type_const type is ConstParamTy_ and that RHS matches it** - **Check that impls of `#[type_const]` consts also have the attr** r? ```@BoxyUwU```
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 10, 2025
Rollup of 10 pull requests Successful merges: - rust-lang/rust#148683 (Remove `#[const_trait]`) - rust-lang/rust#148687 (std: use a non-poisoning `RwLock` for the panic hook) - rust-lang/rust#148709 (fix: disable self-contained linker when bootstrap-override-lld is set) - rust-lang/rust#148716 (mgca: Finish implementation of `#[type_const]`) - rust-lang/rust#148722 (Add Crystal Durham to .mailmap) - rust-lang/rust#148723 (bootstrap: Render doctest timing reports as text, not JSON) - rust-lang/rust#148724 (tidy: Don't bypass stderr output capture in unit tests) - rust-lang/rust#148734 (miri subtree update) - rust-lang/rust#148736 (Fix typo in unstable-book link) - rust-lang/rust#148744 (Add myself(chenyukang) to the review rotation) r? `@ghost` `@rustbot` modify labels: rollup
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #132980
fixes #140729
fixes #140860
#[type_const]attribute placement validation#[type_const]consts also have the attrr? @BoxyUwU