Merged
Conversation
It belongs here, because it moves from a `rustc_*` type to a `rustdoc_json_types` type.
and remove unused Steal::get_mut
… Box<dyn Trait>`
```
error[E0310]: the parameter type `R` may not live long enough
--> $DIR/implicit-static-lifetime-in-dyn-trait-return-type.rs:10:5
|
LL | fn bb<R>(r: R) -> Box<dyn Foo> {
| ------- this `dyn Trait` has an implicit `'static` lifetime bound
LL | Box::new(Bar(r))
| ^^^^^^^^^^^^^^^^
| |
| the parameter type `R` must be valid for the static lifetime...
| ...so that the type `R` will meet its required lifetime bounds
|
help: consider adding an explicit lifetime bound
|
LL | fn bb<R: 'static>(r: R) -> Box<dyn Foo> {
| +++++++++
```
Adds missing test coverage for rustdoc's `--test-builder` option. The existing test only covered the error case (non-executable builder). This PR adds: - A custom test builder that logs arguments and forwards to rustc - A test verifying that `--test-builder` successfully invokes the custom builder with rustc-style arguments - Improved comments explaining both the error and success test scenarios The test validates that custom builders can properly intercept and handle doctest compilation. Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Point at statics and consts being mutable borrowed or written to:
```
error[E0594]: cannot assign to immutable static item `NUM`
--> $DIR/E0594.rs:4:5
|
LL | static NUM: i32 = 18;
| --------------- this `static` cannot be written to
...
LL | NUM = 20;
| ^^^^^^^^ cannot assign
```
Point at the expression that couldn't be mutably borrowed from a pattern:
```
error[E0596]: cannot borrow data in a `&` reference as mutable
--> $DIR/mut-pattern-of-immutable-borrow.rs:19:14
|
LL | match &arg.field {
| ---------- this cannot be borrowed as mutable
LL | Some(ref mut s) => s.push('a'),
| ^^^^^^^^^ cannot borrow as mutable
```
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
This step consists of two changes: - Renaming `self` to `props` - Inserting temporary comments to preserve line breaks This will make it easier to verify that the main migration commit preserves all of the lines being migrated.
Use `git diff --color-moved --color-moved-ws=ignore-all-space` (or similar) to verify that the directive-processing lines have been moved without changes.
…without a pattern outside of `extern` blocks
…the stage0 rustc.
…nwind and compiler crates
rustbot
added
O-windows
Member
Author
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing c8f22ca (parent) -> 9312cd6 (this PR) Test differencesShow 923 test diffsStage 0
Stage 1
Stage 2
Additionally, 832 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 9312cd6d38396a13a08be73bb589fb1cf3dd32e6 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: c8f22ca269 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Nov 11, 2025
Merged
Collaborator
|
Finished benchmarking commit (9312cd6): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.6%, secondary -2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 476.181s -> 477.625s (0.30%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
function_casts_as_integerlint #141470 (Add newfunction_casts_as_integerlint)c_variadic: Add future-incompatibility warning for...arguments without a pattern outside ofexternblocks #143619 (c_variadic: Add future-incompatibility warning for...arguments without a pattern outside ofexternblocks)#![doc(document_private_items)]#146495 (rustdoc: Erase#![doc(document_private_items)])*exact_{div,shr,shl}to*{div,shr,shl}_exact#147771 (Rename*exact_{div,shr,shl}to*{div,shr,shl}_exact)targettojson::conversions#147833 (rustdoc-json: movetargettojson::conversions)TestPropsdirective handling to a system of named handlers #147955 (compiletest: MigrateTestPropsdirective handling to a system of named handlers)Steal::risky_hack_borrow_mut#148480 (AddSteal::risky_hack_borrow_mut)'staticlifetime requirement coming from-> Box<dyn Trait>#148506 (Special case detecting'staticlifetime requirement coming from-> Box<dyn Trait>)build.pythonon macOS #148636 (bootstrap: respectbuild.pythonon macOS)validate_attr#148647 (Check unsafety for non-macro attributes invalidate_attr)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup