Skip to content

Share Timespec between Unix and Hermit#148847

Open
stepancheg wants to merge 2 commits intorust-lang:mainfrom
stepancheg:timespec
Open

Share Timespec between Unix and Hermit#148847
stepancheg wants to merge 2 commits intorust-lang:mainfrom
stepancheg:timespec

Conversation

@stepancheg
Copy link
Contributor

@stepancheg stepancheg commented Nov 11, 2025 •
edited
Loading

  • move unix version of struct Timespec to common, as is, add a few #[cfg(unix)] and absolute imports
  • use it in hermit instead of own Timespec

Code is nearly identical, and before this PR, changes to time requires additional and nearly identical changes in hermit's version of Timespec.

@rustbot rustbot added O-hermit Operating System: Hermit O-unix Operating system: Unix-like labels Nov 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2025

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 11, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@hkBst
Copy link
Member

hkBst commented Nov 14, 2025

For easier reviewing perhaps you could do the move in a separate commit, and then the changes in a commit thereafter?

@rustbot

This comment has been minimized.

Sign in to view
@stepancheg
Copy link
Contributor Author

stepancheg commented Nov 19, 2025

@hkBst I split the PR into two commits. Hope that helps.

hkBst
hkBst approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@hkBst hkBst left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkBst I split the PR into two commits. Hope that helps.

Thanks, that helped enough that I'm willing to say: this looks good to me.

View changes since this review

@bors
Copy link
Collaborator

bors commented Dec 9, 2025

☔ The latest upstream changes (presumably #147572) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot

This comment has been minimized.

Sign in to view
@stepancheg
Copy link
Contributor Author

stepancheg commented Dec 10, 2025

Ping @ChrisDenton.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@stepancheg
Copy link
Contributor Author

stepancheg commented Dec 12, 2025

r? @alexcrichton

@rustbot rustbot assigned alexcrichton and unassigned ChrisDenton Dec 12, 2025
@alexcrichton
Copy link
Member

alexcrichton commented Dec 13, 2025

Alas I'm not the best person to review changes such as this any more, so I'm going to roll the dice and select someone else

r? libs

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Dec 13, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 13, 2025

📌 Commit 1be8960 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#148847 - stepancheg:timespec, r=Mark-Simula…
0bce65e 
…crum

Share Timespec between Unix and Hermit

- move unix version of `struct Timespec` to `common`, as is, add a few `#[cfg(unix)]` and absolute imports
- use it in hermit instead of own `Timespec`

Code is nearly identical, and before this PR, changes to time requires additional and nearly identical changes in hermit's version of `Timespec`.
This was referenced Dec 14, 2025
Closed
Closed
bors added a commit that referenced this pull request Dec 14, 2025
@bors
Auto merge of #149993 - matthiaskrgr:rollup-4jhq5oa, r=matthiaskrgr
c2c72b8 
Rollup of 7 pull requests

Successful merges:

 - #146794 (std: reorganize pipe implementations)
 - #148196 (Implement create_dir_all() to operate iteratively instead of recursively)
 - #148490 (dangling pointer from temp cleanup)
 - #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
 - #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
 - #149949 (Cleanup of attribute parsing errors)
 - #149969 (don't use no_main and no_core to test IBT)

Failed merges:

 - #148847 (Share Timespec between Unix and Hermit)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Dec 14, 2025

☔ The latest upstream changes (presumably #149979) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 14, 2025
@rustbot

This comment has been minimized.

Sign in to view
@stepancheg stepancheg requested a review from hkBst December 15, 2025 09:42
@bors
Copy link
Collaborator

bors commented Dec 15, 2025

☔ The latest upstream changes (presumably #149930) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@stepancheg
Copy link
Contributor Author

stepancheg commented Dec 15, 2025

Rebased again.

@joboet
Copy link
Member

joboet commented Dec 16, 2025

I'd like to hold off merging this, as I'd like to remove sys::pal::common (see #150047). While I like the idea here, this would be better accomplished by moving all the time logic into sys as per #117276 and then unifying the UNIX and Hermit variants.

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 3, 2026

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Jan 3, 2026

☔ The latest upstream changes (presumably #150628) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hkBst hkBst Awaiting requested review from hkBst

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

O-hermit Operating System: Hermit O-unix Operating system: Unix-like S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@stepancheg @rustbot @rust-log-analyzer @hkBst @bors @alexcrichton @Mark-Simulacrum @joboet @ChrisDenton