feat: Enable annotate-snippets' simd feature#149077
Conversation
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
feat: Enable annotate-snippets' simd feature
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (142ba45): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 5.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.456s -> 474.214s (0.16%) |
|
@bors r+ rollup |
…=davidtwco feat: Enable annotate-snippets' simd feature `annotate-snippets` `simd` feature enables the use of `memchr` when searching for `char`/`str`. This should hopefully improve performance when [`annotate-snippets` is passed large `source`](rust-lang#148188 (comment)).
Rollup of 9 pull requests Successful merges: - #148407 (Warn against calls which mutate an interior mutable `const`-item) - #149065 (Address annotate-snippets test differences) - #149072 (Fix the issue of unused assignment from MIR liveness checking) - #149077 (feat: Enable annotate-snippets' simd feature) - #149168 (Fix ICE when collecting opaques from trait method declarations) - #149180 (Couple of refactors to SharedEmitter) - #149185 (Handle cycles when checking impl candidates for `doc(hidden)`) - #149194 (Move safe computation out of unsafe block) - #149204 (Fix typo in HashMap performance comment) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #149077 - Muscraft:annotate-snippets-simd, r=davidtwco feat: Enable annotate-snippets' simd feature `annotate-snippets` `simd` feature enables the use of `memchr` when searching for `char`/`str`. This should hopefully improve performance when [`annotate-snippets` is passed large `source`](#148188 (comment)).
annotate-snippetssimdfeature enables the use ofmemchrwhen searching forchar/str. This should hopefully improve performance whenannotate-snippetsis passed largesource.