Formally deprecate numeric consts modules#149249
Formally deprecate numeric consts modules#149249bstrie wants to merge 1 commit intorust-lang:mainfrom
Conversation
|
cc @tgross35 |
This comment has been minimized.
This comment has been minimized.
|
I'm unclear about the order of operations when it comes to updating compiler-builtins (which only requires a single-line change). I'll submit a PR there to make the change, but what needs to be done on the rust-lang/rust side? |
This comment has been minimized.
This comment has been minimized.
|
Actually, now I'm even more confused, because I can't actually find the equivalent line in the upstream compiler-builtins. |
d5bf725 to
4beceab
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4beceab to
96f75b8
Compare
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
|
@rust-lang/libs-api |
96f75b8 to
6e65dd8
Compare
This comment has been minimized.
This comment has been minimized.
6e65dd8 to
026d21a
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
#146882 is also open, which does the deprecation but not the rest of the updates. I'll try to do a compiler-builtins sync soon. |
| #![deny(unsafe_op_in_unsafe_fn)] | ||
| #![deny(fuzzy_provenance_casts)] | ||
| #![warn(deprecated_in_future)] | ||
| #![warn(deprecated)] |
There was a problem hiding this comment.
unsure: seems like we wouldn't want this? Is it just temporary while figuring out other things?
|
Looks like this is waiting on things other than me, so |
|
Reminder, once the PR becomes ready for a review, use |
|
This needs to fix the CI errors but more to the point it needs libs-api to confirm the decision to formally mark these as deprecated. This was the plan in #68490. |
|
FCP for this already passed in #146882. Unless I'm missing something, this PR is just a duplicate of that one? |
|
Oh there an FCP on another PR. I forgot about that. Un-nominating... |
Long-overdue successor to #80958
Closes #68490