Rollup of 5 pull requests by Zalathar · Pull Request #149410 · rust-lang/rust

Zalathar · 2025-11-28T04:30:46Z

Successful merges:

Stabilize unchecked_neg and unchecked_shifts #149087 (Stabilize unchecked_neg and unchecked_shifts)
rustc_borrowck: Don't suggest changing closure param type not under user control #149107 (rustc_borrowck: Don't suggest changing closure param type not under user control)
Use cg_llvm's target_config in miri #149323 (Use cg_llvm's target_config in miri)
Run eval_config_entry on all branches so we always emit lints #149380 (Run eval_config_entry on all branches so we always emit lints)
add regression test for guard patterns liveness ICE #149394 (add regression test for guard patterns liveness ICE)

r? @ghost
@rustbot modify labels: rollup

…ser control All removed suggestions in tests were invalid.

…lize, r=Amanieu Stabilize `unchecked_neg` and `unchecked_shifts` Features: `unchecked_neg`, `unchecked_shifts` Tracking issue: rust-lang#85122 r? `@Amanieu`

…=jieyouxu rustc_borrowck: Don't suggest changing closure param type not under user control This changes output of a handful of tests more than the one added in the first commit, but as far as I can tell, all removed suggestions were invalid. Closes rust-lang#128381 which is **D-invalid-suggestion** with two 👍-votes.

…RalfJung Use cg_llvm's target_config in miri Fixes rust-lang#149314 r? `@RalfJung`

…r=Urgau Run `eval_config_entry` on all branches so we always emit lints Fixes rust-lang#149090 Ideally I'd have liked to fix this issue using rust-lang#149215, and this is still the long term plan, but this is slightly more annoying to implement than I'd have liked to, and this is also a nice and easy solution to the problem. r? `@tgross35`

…rd-patterns-liveness, r=Kivooeo add regression test for guard patterns liveness ICE closes rust-lang#146445

Zalathar · 2025-11-28T04:31:17Z

Rollup of everything.

@bors r+ rollup=never p=5

bors · 2025-11-28T04:31:19Z

📌 Commit 28fae11 has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-11-28T05:03:14Z

⌛ Testing commit 28fae11 with merge 88bd39b...

bors · 2025-11-28T08:16:25Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 88bd39b to main...

rust-timer · 2025-11-28T08:17:54Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#149087	Stabilize `unchecked_neg` and `unchecked_shifts`	`a9b303e9448947b706e851b8cd09d3144d05e2a3` (link)
#149107	rustc_borrowck: Don't suggest changing closure param type n…	`d4c61285b978ee698c5cf66949daba09aac772a7` (link)
#149323	Use cg_llvm's target_config in miri	`11f14863b162ff3191e7162ece02201cbcd0ca80` (link)
#149380	Run `eval_config_entry` on all branches so we always emit l…	`c1f765072754479e85a8974f7a66cceec127138d` (link)
#149394	add regression test for guard patterns liveness ICE	`fa949bdfc43f93a4d64c41f3c4c3bdb9c809645d` (link)

previous master: 10776a4071

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-11-28T08:19:41Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 10776a4 (parent) -> 88bd39b (this PR)

Test differences

Show 4018 test diffs

Stage 1

[ui] tests/ui/borrowck/option-inspect-mutation.rs: [missing] -> pass (J1)
[ui] tests/ui/check-cfg/cfg-select.rs: [missing] -> pass (J1)
[ui] tests/ui/pattern/rfc-3637-guard-patterns/liveness-ice-issue-146445.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/borrowck/option-inspect-mutation.rs: [missing] -> pass (J0)
[ui] tests/ui/check-cfg/cfg-select.rs: [missing] -> pass (J0)
[ui] tests/ui/pattern/rfc-3637-guard-patterns/liveness-ice-issue-146445.rs: [missing] -> pass (J0)

Additionally, 4012 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 88bd39beb342e2ae7ded1eb7d58697416686d679 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-apple: 7710.8s -> 5953.0s (-22.8%)
x86_64-gnu-gcc: 3852.0s -> 3038.8s (-21.1%)
dist-x86_64-apple: 7231.3s -> 6037.7s (-16.5%)
pr-check-1: 1932.1s -> 1644.1s (-14.9%)
x86_64-gnu-llvm-20: 2816.7s -> 2435.8s (-13.5%)
dist-aarch64-llvm-mingw: 5865.7s -> 5167.0s (-11.9%)
aarch64-apple: 8835.0s -> 7870.4s (-10.9%)
pr-check-2: 2621.8s -> 2338.0s (-10.8%)
i686-gnu-1: 8291.5s -> 7396.0s (-10.8%)
armhf-gnu: 5479.1s -> 4887.3s (-10.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-28T09:37:39Z

Finished benchmarking commit (88bd39b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[0.5%, 0.5%]	1

Cycles

Results (primary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-3.3%, -2.6%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.9%	[-3.3%, -2.6%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.457s -> 472.29s (0.18%)
Artifact size: 386.89 MiB -> 386.94 MiB (0.01%)

nxsaken and others added 14 commits November 19, 2025 13:19

Stabilize unchecked_neg and unchecked_shifts

47153b5

tests: Check stderr when trying to mutate inside Option::inspect()

6004968

rustc_borrowck: Don't suggest changing closure param type not under u…

f186e53

…ser control All removed suggestions in tests were invalid.

Run eval_config_entry on all branches so we always emit lints

e59a6f8

add regression test for guard patterns liveness ICE

2425f80

Use cg_llvm's target_config in miri

9964970

simplify and explain MiriBeRustCompilerCalls logic for crate types

d3901cd

Improve test

57b57b8

Add regression test

41900f8

Rollup merge of rust-lang#149087 - nxsaken:unchecked_neg_shifts_stabi…

549c577

…lize, r=Amanieu Stabilize `unchecked_neg` and `unchecked_shifts` Features: `unchecked_neg`, `unchecked_shifts` Tracking issue: rust-lang#85122 r? `@Amanieu`

Rollup merge of rust-lang#149323 - bjorn3:miri_llvm_target_config, r=…

b8b7041

…RalfJung Use cg_llvm's target_config in miri Fixes rust-lang#149314 r? `@RalfJung`

Rollup merge of rust-lang#149394 - Aditya-PS-05:test-issue-146445-gua…

28fae11

…rd-patterns-liveness, r=Kivooeo add regression test for guard patterns liveness ICE closes rust-lang#146445

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 28, 2025

bors merged commit 88bd39b into rust-lang:main Nov 28, 2025
12 checks passed

rustbot added this to the 1.93.0 milestone Nov 28, 2025

bors mentioned this pull request Nov 28, 2025

Emit check-cfg lints during attribute parsing rather than evaluation #149215

Merged

Zalathar deleted the rollup-wke6axp branch November 28, 2025 10:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests#149410

Rollup of 5 pull requests#149410
bors merged 14 commits intorust-lang:mainfrom
Zalathar:rollup-wke6axp

Zalathar commented Nov 28, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Nov 28, 2025

Uh oh!

bors commented Nov 28, 2025

Uh oh!

bors commented Nov 28, 2025

Uh oh!

bors commented Nov 28, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 28, 2025

Uh oh!

github-actions bot commented Nov 28, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

Zalathar commented Nov 28, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Nov 28, 2025

Uh oh!

bors commented Nov 28, 2025

Uh oh!

bors commented Nov 28, 2025

Uh oh!

bors commented Nov 28, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 28, 2025

Uh oh!

github-actions bot commented Nov 28, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Nov 28, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Zalathar commented Nov 28, 2025 •

edited by rustbot

Loading