Remove suggestion from importing unstable items on stable channel by chenyukang · Pull Request #149440 · rust-lang/rust

chenyukang · 2025-11-29T01:43:12Z

rustbot · 2025-11-29T01:43:17Z

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

fee1-dead

r=me after addressing nit

View changes since this review

fee1-dead · 2025-11-30T01:24:10Z

tests/ui/resolve/suggest-unresolve-nightly-149402.rs

@@ -0,0 +1,9 @@
+//@ only-nightly


Is it possible to use revisions here to avoid duplicating the same file?

thanks, fixed in https://github.com/rust-lang/rust/compare/5b003456246ad18d3141eb748d750f152f51194f..34c80e46389304d906fcb50efe4cf32a0270fab7

chenyukang · 2025-11-30T01:40:48Z

@bors r=fee1-dead

bors · 2025-11-30T01:40:51Z

📌 Commit 34c80e4 has been approved by fee1-dead

It is now in the queue for this repository.

Remove suggestion from importing unstable items on stable channel Fixes #149402

bors · 2025-11-30T01:46:15Z

⌛ Testing commit 34c80e4 with merge 2699798...

Remove suggestion from importing unstable items on stable channel Fixes #149402

bors · 2025-11-30T02:22:44Z

⌛ Testing commit 34c80e4 with merge 8787ed6...

bors · 2025-11-30T03:17:47Z

💔 Test failed - checks-actions

chenyukang · 2025-11-30T13:08:52Z

@jieyouxu
do you know how to add test case only for stable channel?

I build a stage2 on local machine, and found out the is_nightly_build() returns true, I think it's the same in CI testing.

https://github.com/chenyukang/rust/blob/34c80e46389304d906fcb50efe4cf32a0270fab7/compiler/rustc_resolve/src/diagnostics.rs#L1612

From the code, seems we will set CFG_DISABLE_UNSTABLE_FEATURES for stable channel.
https://github.com/chenyukang/rust/blob/34c80e46389304d906fcb50efe4cf32a0270fab7/compiler/rustc_feature/src/lib.rs#L84

jieyouxu · 2025-12-01T06:07:56Z

Ok, it looks like RUSTC_BOOTSTRAP overriding CFG_DISABLE_UNSTABLE_FEATURES is intentional (at least, that's what the original logic was also doing), as otherwise, you can't even bootstrap.

One option you may have is to write this as a run-make test, with two stderr tracked: a stable rustc, and an unstable rustc. Gate the run-make itself using //@ only-nightly, but have the nightly rustc "pretend" to be a stable rustc with RUSTC_BOOTSTRAP=-1. Have a look at

rust/tests/run-make/print-request-help-stable-unstable/rmake.rs

Line 8 in dfe1b8c

.env("RUSTC_BOOTSTRAP", "-1")

for an example. That should still allow you to compare the diffs generated by the same rustc as if it reached stable.

fee1-dead · 2025-12-05T19:03:02Z

@rustbot author

jhpratt · 2026-01-04T21:42:42Z

@bors r- (sync)

Remove suggestion from importing unstable items on stable channel Fixes rust-lang#149402

@ghost

Rollup of 9 pull requests Successful merges: - #148769 (Stabilize `alloc_layout_extra`) - #149440 (Remove suggestion from importing unstable items on stable channel) - #150200 (Add title field to `ice.md` issue template) - #150955 (Underscore-prefixed bindings are explicitly allowed to be unused) - #151200 (time: Add saturating arithmetic for `SystemTime`) - #151235 (Change field `bit_width: usize` to `bits: u32` in type info) - #151242 (Port #[needs_allocator] to attribute parser) - #151274 (Include a link to `count_ones` in the docs for `uN::count_zeros` [docs only]) - #151279 (remove trailing periods in built-in attribute gate messages) r? @ghost

jhpratt · 2026-01-18T08:16:19Z

@bors r-

#151285 (comment)

rust-bors · 2026-01-18T08:16:23Z

Commit e1aee29 has been unapproved.

chenyukang · 2026-01-18T12:03:23Z

@bors try jobs=dist-various-1

Remove suggestion from importing unstable items on stable channel try-job: dist-various-1

rust-bors · 2026-01-18T13:27:40Z

☀️ Try build successful (CI)
Build commit: e8af78d (e8af78d927e50dba8c849a2b95b5a5e142f826b8, parent: 621d76794c76fc21c0a6151fbc090120e0230a91)

chenyukang · 2026-01-19T02:37:58Z

@rustbot ready

fee1-dead · 2026-01-22T17:29:20Z

@bors r+ rollup

rust-bors · 2026-01-22T17:29:24Z

📌 Commit c578560 has been approved by fee1-dead

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

rust-bors · 2026-01-22T21:25:40Z

☀️ Test successful - CI
Approved by: fee1-dead
Duration: 3h 15m 40s
Pushing 39052da to main...

github-actions · 2026-01-22T21:29:24Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0f14563 (parent) -> 39052da (this PR)

Test differences

Show 23 test diffs

Stage 1

[run-make] tests/run-make/issue-149402-suggest-unresolve: [missing] -> pass (J2)

Stage 2

[run-make] tests/run-make/issue-149402-suggest-unresolve: [missing] -> ignore (ignored if target does not support std) (J0)
[run-make] tests/run-make/issue-149402-suggest-unresolve: [missing] -> ignore (only executed when the release channel is nightly) (J1)
[run-make] tests/run-make/issue-149402-suggest-unresolve: [missing] -> pass (J3)

Additionally, 19 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 39052daf937d46373ac29778e1b8853c52c0cc25 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-apple: 8171.3s -> 6757.8s (-17.3%)
x86_64-gnu-llvm-21-1: 3727.3s -> 4130.7s (+10.8%)
dist-x86_64-mingw: 8791.2s -> 9663.5s (+9.9%)
i686-gnu-nopt-1: 7431.2s -> 6824.2s (-8.2%)
dist-various-1: 4095.3s -> 4404.7s (+7.6%)
dist-x86_64-apple: 8582.2s -> 7979.1s (-7.0%)
dist-ohos-aarch64: 4571.5s -> 4252.1s (-7.0%)
dist-aarch64-msvc: 5954.2s -> 5561.1s (-6.6%)
i686-gnu-1: 7909.1s -> 7408.6s (-6.3%)
x86_64-gnu-stable: 8762.0s -> 8217.7s (-6.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-01-22T22:06:56Z

Finished benchmarking commit (39052da): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.1%, secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.9%, 1.9%]	1
Regressions ❌ (secondary)	4.5%	[3.0%, 6.1%]	2
Improvements ✅ (primary)	-1.7%	[-1.7%, -1.7%]	1
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	0.1%	[-1.7%, 1.9%]	2

Cycles

Results (primary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.4%	[-2.4%, -2.4%]	1

Binary size

Results (primary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	4

Bootstrap: 475.466s -> 473.794s (-0.35%)
Artifact size: 383.19 MiB -> 383.23 MiB (0.01%)

rustbot assigned fee1-dead Nov 29, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 29, 2025

fee1-dead requested changes Nov 30, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2025

chenyukang force-pushed the yukang/issue-149402 branch from 5b00345 to 34c80e4 Compare November 30, 2025 01:38

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 30, 2025

bors added a commit that referenced this pull request Nov 30, 2025

Auto merge of #149440 - chenyukang:yukang/issue-149402, r=fee1-dead

2699798

Remove suggestion from importing unstable items on stable channel Fixes #149402

bors added a commit that referenced this pull request Nov 30, 2025

Auto merge of #149440 - chenyukang:yukang/issue-149402, r=fee1-dead

8787ed6

Remove suggestion from importing unstable items on stable channel Fixes #149402

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 30, 2025

jieyouxu self-assigned this Dec 1, 2025

This comment was marked as outdated.

Sign in to view

jieyouxu removed their assignment Dec 1, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2025

chenyukang force-pushed the yukang/issue-149402 branch from 34c80e4 to 1aac0b4 Compare January 11, 2026 03:19

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2026

jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 18, 2026

Rollup merge of rust-lang#149440 - yukang/issue-149402, r=fee1-dead

b9dd401

Remove suggestion from importing unstable items on stable channel Fixes rust-lang#149402

jhpratt mentioned this pull request Jan 18, 2026

Rollup of 9 pull requests #151285

Closed

rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 18, 2026

rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 18, 2026

Surpress suggestion from unstable items on stable channel

c578560

chenyukang force-pushed the yukang/issue-149402 branch from e1aee29 to c578560 Compare January 18, 2026 12:02

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Jan 18, 2026

Auto merge of #149440 - chenyukang:yukang/issue-149402, r=<try>

e8af78d

Remove suggestion from importing unstable items on stable channel try-job: dist-various-1

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 19, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 22, 2026

rust-bors bot merged commit 39052da into rust-lang:main Jan 22, 2026
13 checks passed

rustbot added this to the 1.95.0 milestone Jan 22, 2026

Uh oh!

Conversation

chenyukang commented Nov 29, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 29, 2025

Uh oh!

fee1-dead left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fee1-dead Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

chenyukang Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

chenyukang commented Nov 30, 2025

Uh oh!

bors commented Nov 30, 2025

Uh oh!

bors commented Nov 30, 2025

Uh oh!

bors commented Nov 30, 2025

Uh oh!

This comment has been minimized.

bors commented Nov 30, 2025

Uh oh!

chenyukang commented Nov 30, 2025

Uh oh!

This comment was marked as outdated.

jieyouxu commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fee1-dead commented Dec 5, 2025

Uh oh!

jhpratt commented Jan 4, 2026

Uh oh!

jhpratt commented Jan 18, 2026

Uh oh!

rust-bors bot commented Jan 18, 2026

Uh oh!

chenyukang commented Jan 18, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 18, 2026

Uh oh!

chenyukang commented Jan 19, 2026

Uh oh!

fee1-dead commented Jan 22, 2026

Uh oh!

rust-bors bot commented Jan 22, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 22, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 22, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jan 22, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

chenyukang commented Nov 29, 2025 •

edited by rustbot

Loading

fee1-dead left a comment •

edited by rustbot

Loading

jieyouxu commented Dec 1, 2025 •

edited

Loading