Fix span note for question mark expression

[chenyukang]

Fixes #144304

Seems it's better to fix the note instead of modifying the span to cover the whole expression.

r? @estebank

[estebank]

@bors r+

[bors]

📌 Commit 7a9e0df has been approved by estebank

It is now in the queue for this repository.

[matthiaskrgr]

@bors r-
https://triage.rust-lang.org/gha-logs/rust-lang/rust/57103201357

[Zalathar]

Failed in rollup: #149628 (comment)

[chenyukang]

@bors try jobs=armhf-gnu

[rust-bors]

☀️ Try build successful (CI)
Build commit: 82bb8d7 (82bb8d75dc5252396b7f00c6a8e47c2a54df6925, parent: dc47a69ed94bc88b10b7d500cceacf29b87bcbbe)

[chenyukang]

@rustbot ready

[estebank]

@bors r+

[bors]

📌 Commit d0bd4df has been approved by estebank

It is now in the queue for this repository.

[bors]

⌛ Testing commit d0bd4df with merge 31010ca...

[bors]

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 31010ca to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 95a27ad (parent) -> 31010ca (this PR)

Test differences

Show 5 test diffs

Stage 1

• [ui] tests/ui/traits/question-mark-span-144304.rs: [missing] -> pass (J1)

Stage 2

• [ui] tests/ui/traits/question-mark-span-144304.rs: [missing] -> pass (J0)
• [ui] tests/ui/traits/question-mark-span-144304.rs: [missing] -> ignore (ignored when the architecture is arm (armhf-gnu have more types implement trait From<T>, let's skip it)) (J2)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-20-1, aarch64-msvc-1, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-gnu, x86_64-gnu-debug, x86_64-gnu-gcc, x86_64-gnu-llvm-20, x86_64-gnu-llvm-20-2, x86_64-gnu-llvm-21-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
• J1: x86_64-gnu-llvm-20-3, x86_64-gnu-llvm-21-3
• J2: arm-android, armhf-gnu

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 31010ca61c3ff019e1480dda0a7ef16bd2bd51c0 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. dist-x86_64-apple: 6997.4s -> 10149.6s (+45.0%)
2. aarch64-apple: 10788.9s -> 12648.5s (+17.2%)
3. dist-x86_64-llvm-mingw: 7387.7s -> 8292.1s (+12.2%)
4. dist-x86_64-solaris: 5016.9s -> 5510.0s (+9.8%)
5. dist-android: 1527.1s -> 1671.5s (+9.5%)
6. dist-apple-various: 3854.4s -> 4216.0s (+9.4%)
7. dist-x86_64-netbsd: 4885.2s -> 5302.5s (+8.5%)
8. dist-ohos-x86_64: 4200.6s -> 4501.4s (+7.2%)
9. x86_64-gnu-miri: 5105.1s -> 4749.5s (-7.0%)
10. x86_64-rust-for-linux: 3175.6s -> 2960.6s (-6.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (31010ca): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.8%, secondary -0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-3.9%	[-3.9%, -3.9%]	1
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Cycles

Results (secondary -3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-3.9%, -3.9%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 479.485s -> 479.038s (-0.09%)
Artifact size: 390.32 MiB -> 390.32 MiB (0.00%)