rustdoc: sort stable items first#149460
Open
lolbinarycat wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
Collaborator
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @notriddle rustbot has assigned @notriddle. Use |
This comment has been minimized.
This comment has been minimized.
notriddle
reviewed
Nov 29, 2025
Contributor
There was a problem hiding this comment.
The PR title says it sorts unstable items first. This test seems to show the unstable item appearing last. Which is it?
Contributor
Author
There was a problem hiding this comment.
pr title was a typo, fixed (need to go back and fix the commit description too)
| return a - b; | ||
| } | ||
|
|
||
| // sort unstable items later |
Member
There was a problem hiding this comment.
That confirms that title is wrong. 😉
lolbinarycat
changed the title
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
rustdoc-search-sort-stable-first
branch
from
0a9a15a to
22ac5f7
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally tackling this again now that the search system refactor is done. The tests and the general approach were taken from the original PR.